Commit ea242f82 authored by Conor Dooley's avatar Conor Dooley Committed by Jakub Kicinski

net: macb: simplify error paths in init_reset_optional()

The error handling paths in init_reset_optional() can all be
simplified to return dev_err_probe(). Do so.
Reviewed-by: default avatarClaudiu Beznea <claudiu.beznea@microchip.com>
Signed-off-by: default avatarConor Dooley <conor.dooley@microchip.com>
Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 649bef9c
...@@ -4699,27 +4699,21 @@ static int init_reset_optional(struct platform_device *pdev) ...@@ -4699,27 +4699,21 @@ static int init_reset_optional(struct platform_device *pdev)
/* Ensure PHY device used in SGMII mode is ready */ /* Ensure PHY device used in SGMII mode is ready */
bp->sgmii_phy = devm_phy_optional_get(&pdev->dev, NULL); bp->sgmii_phy = devm_phy_optional_get(&pdev->dev, NULL);
if (IS_ERR(bp->sgmii_phy)) { if (IS_ERR(bp->sgmii_phy))
ret = PTR_ERR(bp->sgmii_phy); return dev_err_probe(&pdev->dev, PTR_ERR(bp->sgmii_phy),
dev_err_probe(&pdev->dev, ret,
"failed to get SGMII PHY\n"); "failed to get SGMII PHY\n");
return ret;
}
ret = phy_init(bp->sgmii_phy); ret = phy_init(bp->sgmii_phy);
if (ret) { if (ret)
dev_err(&pdev->dev, "failed to init SGMII PHY: %d\n", return dev_err_probe(&pdev->dev, ret,
ret); "failed to init SGMII PHY\n");
return ret;
}
} }
/* Fully reset controller at hardware level if mapped in device tree */ /* Fully reset controller at hardware level if mapped in device tree */
ret = device_reset_optional(&pdev->dev); ret = device_reset_optional(&pdev->dev);
if (ret) { if (ret) {
dev_err_probe(&pdev->dev, ret, "failed to reset controller");
phy_exit(bp->sgmii_phy); phy_exit(bp->sgmii_phy);
return ret; return dev_err_probe(&pdev->dev, ret, "failed to reset controller");
} }
ret = macb_init(pdev); ret = macb_init(pdev);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment