Commit ebb5b260 authored by David Arcari's avatar David Arcari Committed by Len Brown

tools/power turbostat: option '-n' is ambiguous

In some cases specifying the '-n' command line argument will cause
turbostat to fail.  For instance 'turbostat -n 1' works fine; however,
'turbostat -n 1 -d' will fail.  This is the result of the first call
to getopt_long_only() where "MP" is specified as the optstring.  This can
be easily fixed by changing the optstring from "MP" to "MPn:" to remove
ambiguity between the arguments.

tools/power turbostat: option '-n' is ambiguous; possibilities: '-num_iterations' '-no-msr' '-no-perf'

Fixes: a0e86c90 ("tools/power turbostat: Add --no-perf option")
Signed-off-by: default avatarDavid Arcari <darcari@redhat.com>
Signed-off-by: default avatarLen Brown <len.brown@intel.com>
parent f2661062
...@@ -8424,7 +8424,7 @@ void cmdline(int argc, char **argv) ...@@ -8424,7 +8424,7 @@ void cmdline(int argc, char **argv)
* Parse some options early, because they may make other options invalid, * Parse some options early, because they may make other options invalid,
* like adding the MSR counter with --add and at the same time using --no-msr. * like adding the MSR counter with --add and at the same time using --no-msr.
*/ */
while ((opt = getopt_long_only(argc, argv, "MP", long_options, &option_index)) != -1) { while ((opt = getopt_long_only(argc, argv, "MPn:", long_options, &option_index)) != -1) {
switch (opt) { switch (opt) {
case 'M': case 'M':
no_msr = 1; no_msr = 1;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment