Commit ef498438 authored by Pintu Kumar's avatar Pintu Kumar Committed by Linus Torvalds

mm/compaction: remove unused variable sysctl_compact_memory

The sysctl_compact_memory is mostly unused in mm/compaction.c It just
acts as a place holder for sysctl to store .data.

But the .data itself is not needed here.

So we can get ride of this variable completely and make .data as NULL.
This will also eliminate the extern declaration from header file.  No
functionality is broken or changed this way.

Link: https://lkml.kernel.org/r/1614852224-14671-1-git-send-email-pintu@codeaurora.orgSigned-off-by: default avatarPintu Kumar <pintu@codeaurora.org>
Signed-off-by: default avatarPintu Agarwal <pintu.ping@gmail.com>
Reviewed-by: default avatarVlastimil Babka <vbabka@suse.cz>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 18bb473e
...@@ -81,7 +81,6 @@ static inline unsigned long compact_gap(unsigned int order) ...@@ -81,7 +81,6 @@ static inline unsigned long compact_gap(unsigned int order)
} }
#ifdef CONFIG_COMPACTION #ifdef CONFIG_COMPACTION
extern int sysctl_compact_memory;
extern unsigned int sysctl_compaction_proactiveness; extern unsigned int sysctl_compaction_proactiveness;
extern int sysctl_compaction_handler(struct ctl_table *table, int write, extern int sysctl_compaction_handler(struct ctl_table *table, int write,
void *buffer, size_t *length, loff_t *ppos); void *buffer, size_t *length, loff_t *ppos);
......
...@@ -2830,7 +2830,7 @@ static struct ctl_table vm_table[] = { ...@@ -2830,7 +2830,7 @@ static struct ctl_table vm_table[] = {
#ifdef CONFIG_COMPACTION #ifdef CONFIG_COMPACTION
{ {
.procname = "compact_memory", .procname = "compact_memory",
.data = &sysctl_compact_memory, .data = NULL,
.maxlen = sizeof(int), .maxlen = sizeof(int),
.mode = 0200, .mode = 0200,
.proc_handler = sysctl_compaction_handler, .proc_handler = sysctl_compaction_handler,
......
...@@ -2692,9 +2692,6 @@ static void compact_nodes(void) ...@@ -2692,9 +2692,6 @@ static void compact_nodes(void)
compact_node(nid); compact_node(nid);
} }
/* The written value is actually unused, all memory is compacted */
int sysctl_compact_memory;
/* /*
* Tunable for proactive compaction. It determines how * Tunable for proactive compaction. It determines how
* aggressively the kernel should compact memory in the * aggressively the kernel should compact memory in the
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment