Commit efd8d907 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by David S. Miller

net: mdio: sun4i: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new() which already returns void. Eventually after all drivers
are converted, .remove_new() is renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: default avatarJernej Skrabec <jernej.skrabec@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 1e39b224
...@@ -142,7 +142,7 @@ static int sun4i_mdio_probe(struct platform_device *pdev) ...@@ -142,7 +142,7 @@ static int sun4i_mdio_probe(struct platform_device *pdev)
return ret; return ret;
} }
static int sun4i_mdio_remove(struct platform_device *pdev) static void sun4i_mdio_remove(struct platform_device *pdev)
{ {
struct mii_bus *bus = platform_get_drvdata(pdev); struct mii_bus *bus = platform_get_drvdata(pdev);
struct sun4i_mdio_data *data = bus->priv; struct sun4i_mdio_data *data = bus->priv;
...@@ -151,8 +151,6 @@ static int sun4i_mdio_remove(struct platform_device *pdev) ...@@ -151,8 +151,6 @@ static int sun4i_mdio_remove(struct platform_device *pdev)
if (data->regulator) if (data->regulator)
regulator_disable(data->regulator); regulator_disable(data->regulator);
mdiobus_free(bus); mdiobus_free(bus);
return 0;
} }
static const struct of_device_id sun4i_mdio_dt_ids[] = { static const struct of_device_id sun4i_mdio_dt_ids[] = {
...@@ -166,7 +164,7 @@ MODULE_DEVICE_TABLE(of, sun4i_mdio_dt_ids); ...@@ -166,7 +164,7 @@ MODULE_DEVICE_TABLE(of, sun4i_mdio_dt_ids);
static struct platform_driver sun4i_mdio_driver = { static struct platform_driver sun4i_mdio_driver = {
.probe = sun4i_mdio_probe, .probe = sun4i_mdio_probe,
.remove = sun4i_mdio_remove, .remove_new = sun4i_mdio_remove,
.driver = { .driver = {
.name = "sun4i-mdio", .name = "sun4i-mdio",
.of_match_table = sun4i_mdio_dt_ids, .of_match_table = sun4i_mdio_dt_ids,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment