Commit f04eba13 authored by Lucy Mielke's avatar Lucy Mielke Committed by Andrew Morton

mm: add printf attribute to shrinker_debugfs_name_alloc

This fixes a compiler warning when compiling an allyesconfig with W=1:

mm/internal.h:1235:9: error: function might be a candidate for `gnu_printf'
format attribute [-Werror=suggest-attribute=format]

[akpm@linux-foundation.org: fix shrinker_alloc() as welll per Qi Zheng]
  Link: https://lkml.kernel.org/r/822387b7-4895-4e64-5806-0f56b5d6c447@bytedance.com
Link: https://lkml.kernel.org/r/ZSBue-3kM6gI6jCr@mainframe
Fixes: c42d50ae ("mm: shrinker: add infrastructure for dynamically allocating shrinker")
Signed-off-by: default avatarLucy Mielke <lucymielke@icloud.com>
Cc: Qi Zheng <zhengqi.arch@bytedance.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent 7a81751f
...@@ -131,6 +131,7 @@ struct shrinker { ...@@ -131,6 +131,7 @@ struct shrinker {
*/ */
#define SHRINKER_NONSLAB BIT(4) #define SHRINKER_NONSLAB BIT(4)
__printf(2, 3)
struct shrinker *shrinker_alloc(unsigned int flags, const char *fmt, ...); struct shrinker *shrinker_alloc(unsigned int flags, const char *fmt, ...);
void shrinker_register(struct shrinker *shrinker); void shrinker_register(struct shrinker *shrinker);
void shrinker_free(struct shrinker *shrinker); void shrinker_free(struct shrinker *shrinker);
......
...@@ -1219,8 +1219,8 @@ unsigned long shrink_slab(gfp_t gfp_mask, int nid, struct mem_cgroup *memcg, ...@@ -1219,8 +1219,8 @@ unsigned long shrink_slab(gfp_t gfp_mask, int nid, struct mem_cgroup *memcg,
int priority); int priority);
#ifdef CONFIG_SHRINKER_DEBUG #ifdef CONFIG_SHRINKER_DEBUG
static inline int shrinker_debugfs_name_alloc(struct shrinker *shrinker, static inline __printf(2, 0) int shrinker_debugfs_name_alloc(
const char *fmt, va_list ap) struct shrinker *shrinker, const char *fmt, va_list ap)
{ {
shrinker->name = kvasprintf_const(GFP_KERNEL, fmt, ap); shrinker->name = kvasprintf_const(GFP_KERNEL, fmt, ap);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment