Commit f188d26d authored by Vladis Dronov's avatar Vladis Dronov Committed by Willy Tarreau

usb: serial: visor: fix crash on detecting device without write_urbs

commit cb323213 upstream.

The visor driver crashes in clie_5_attach() when a specially crafted USB
device without bulk-out endpoint is detected. This fix adds a check that
the device has proper configuration expected by the driver.
Reported-by: default avatarRalf Spenneberg <ralf@spenneberg.net>
Signed-off-by: default avatarVladis Dronov <vdronov@redhat.com>
Signed-off-by: default avatarBen Hutchings <ben@decadent.org.uk>
Signed-off-by: default avatarWilly Tarreau <w@1wt.eu>
parent 1a5b69df
......@@ -921,8 +921,10 @@ static int clie_5_attach(struct usb_serial *serial)
*/
/* some sanity check */
if (serial->num_ports < 2)
return -1;
if (serial->num_bulk_out < 2) {
dev_err(&serial->interface->dev, "missing bulk out endpoints\n");
return -ENODEV;
}
/* port 0 now uses the modified endpoint Address */
serial->port[0]->bulk_out_endpointAddress =
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment