Commit f7f4df88 authored by Dragan Simic's avatar Dragan Simic Committed by Heiko Stuebner

drm/rockchip: cdn-dp: Clean up a few logged messages

Clean up a few logged messages, which were previously worded as rather
incomplete sentences separated by periods.  This was both a bit unreadable
and grammatically incorrect, so convert them into partial sentences separated
(or connected) by semicolons, together with some wording improvements.
Signed-off-by: default avatarDragan Simic <dsimic@manjaro.org>
Reviewed-by: default avatarAndy Yan <andyshrk@163.com>
Signed-off-by: default avatarHeiko Stuebner <heiko@sntech.de>
Link: https://patchwork.freedesktop.org/patch/msgid/92db74a313547c087cc71059428698c4ec37a9ae.1720048818.git.dsimic@manjaro.org
parent dfa55431
...@@ -965,21 +965,21 @@ static void cdn_dp_pd_event_work(struct work_struct *work) ...@@ -965,21 +965,21 @@ static void cdn_dp_pd_event_work(struct work_struct *work)
/* Not connected, notify userspace to disable the block */ /* Not connected, notify userspace to disable the block */
if (!cdn_dp_connected_port(dp)) { if (!cdn_dp_connected_port(dp)) {
DRM_DEV_INFO(dp->dev, "Not connected. Disabling cdn\n"); DRM_DEV_INFO(dp->dev, "Not connected; disabling cdn\n");
dp->connected = false; dp->connected = false;
/* Connected but not enabled, enable the block */ /* Connected but not enabled, enable the block */
} else if (!dp->active) { } else if (!dp->active) {
DRM_DEV_INFO(dp->dev, "Connected, not enabled. Enabling cdn\n"); DRM_DEV_INFO(dp->dev, "Connected, not enabled; enabling cdn\n");
ret = cdn_dp_enable(dp); ret = cdn_dp_enable(dp);
if (ret) { if (ret) {
DRM_DEV_ERROR(dp->dev, "Enable dp failed %d\n", ret); DRM_DEV_ERROR(dp->dev, "Enabling dp failed: %d\n", ret);
dp->connected = false; dp->connected = false;
} }
/* Enabled and connected to a dongle without a sink, notify userspace */ /* Enabled and connected to a dongle without a sink, notify userspace */
} else if (!cdn_dp_check_sink_connection(dp)) { } else if (!cdn_dp_check_sink_connection(dp)) {
DRM_DEV_INFO(dp->dev, "Connected without sink. Assert hpd\n"); DRM_DEV_INFO(dp->dev, "Connected without sink; assert hpd\n");
dp->connected = false; dp->connected = false;
/* Enabled and connected with a sink, re-train if requested */ /* Enabled and connected with a sink, re-train if requested */
...@@ -988,11 +988,11 @@ static void cdn_dp_pd_event_work(struct work_struct *work) ...@@ -988,11 +988,11 @@ static void cdn_dp_pd_event_work(struct work_struct *work)
unsigned int lanes = dp->max_lanes; unsigned int lanes = dp->max_lanes;
struct drm_display_mode *mode = &dp->mode; struct drm_display_mode *mode = &dp->mode;
DRM_DEV_INFO(dp->dev, "Connected with sink. Re-train link\n"); DRM_DEV_INFO(dp->dev, "Connected with sink; re-train link\n");
ret = cdn_dp_train_link(dp); ret = cdn_dp_train_link(dp);
if (ret) { if (ret) {
dp->connected = false; dp->connected = false;
DRM_DEV_ERROR(dp->dev, "Train link failed %d\n", ret); DRM_DEV_ERROR(dp->dev, "Training link failed: %d\n", ret);
goto out; goto out;
} }
...@@ -1002,9 +1002,7 @@ static void cdn_dp_pd_event_work(struct work_struct *work) ...@@ -1002,9 +1002,7 @@ static void cdn_dp_pd_event_work(struct work_struct *work)
ret = cdn_dp_config_video(dp); ret = cdn_dp_config_video(dp);
if (ret) { if (ret) {
dp->connected = false; dp->connected = false;
DRM_DEV_ERROR(dp->dev, DRM_DEV_ERROR(dp->dev, "Failed to configure video: %d\n", ret);
"Failed to config video %d\n",
ret);
} }
} }
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment