Commit f97769fd authored by Srinivas Kandagatla's avatar Srinivas Kandagatla Committed by Greg Kroah-Hartman

slimbus: core: check get_addr before removing laddr ida

logical address can be either assigned by the SLIMBus controller or the core.
Core uses IDA in cases where get_addr callback is not provided by the
controller.
Core already has this check while allocating IDR, however during absence
reporting this is not checked. This patch fixes this issue.

Fixes: 46a2bb5a ("slimbus: core: Add slim controllers support")
Signed-off-by: default avatarSrinivas Kandagatla <srinivas.kandagatla@linaro.org>
Link: https://lore.kernel.org/r/20200925095520.27316-2-srinivas.kandagatla@linaro.orgSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 5a487cf7
...@@ -326,8 +326,8 @@ void slim_report_absent(struct slim_device *sbdev) ...@@ -326,8 +326,8 @@ void slim_report_absent(struct slim_device *sbdev)
mutex_lock(&ctrl->lock); mutex_lock(&ctrl->lock);
sbdev->is_laddr_valid = false; sbdev->is_laddr_valid = false;
mutex_unlock(&ctrl->lock); mutex_unlock(&ctrl->lock);
if (!ctrl->get_laddr)
ida_simple_remove(&ctrl->laddr_ida, sbdev->laddr); ida_simple_remove(&ctrl->laddr_ida, sbdev->laddr);
slim_device_update_status(sbdev, SLIM_DEVICE_STATUS_DOWN); slim_device_update_status(sbdev, SLIM_DEVICE_STATUS_DOWN);
} }
EXPORT_SYMBOL_GPL(slim_report_absent); EXPORT_SYMBOL_GPL(slim_report_absent);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment