Commit fd2d8565 authored by Thomas Zimmermann's avatar Thomas Zimmermann

drm/fb-helper: Separate shadow-buffer flushing and calling dirty callback

Flushing the shadow framebuffer and invoking the dirty callback are two
separate operations, so do them separately. The flush operation is paired
with calls to vmap and vunmap. They are not needed for the dirty callback,
which performs its own invocations if necessary.
Signed-off-by: default avatarThomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: default avatarSam Ravnborg <sam@ravnborg.org>
Acked-by: default avatarMaxime Ripard <mripard@kernel.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20201120102545.4047-7-tzimmermann@suse.de
parent 2b5f31aa
...@@ -417,13 +417,11 @@ static void drm_fb_helper_damage_work(struct work_struct *work) ...@@ -417,13 +417,11 @@ static void drm_fb_helper_damage_work(struct work_struct *work)
if (ret) if (ret)
return; return;
drm_fb_helper_damage_blit_real(helper, &clip_copy, &map); drm_fb_helper_damage_blit_real(helper, &clip_copy, &map);
drm_client_buffer_vunmap(helper->buffer);
} }
if (helper->fb->funcs->dirty) if (helper->fb->funcs->dirty)
helper->fb->funcs->dirty(helper->fb, NULL, 0, 0, &clip_copy, 1); helper->fb->funcs->dirty(helper->fb, NULL, 0, 0, &clip_copy, 1);
if (helper->buffer)
drm_client_buffer_vunmap(helper->buffer);
} }
/** /**
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment