Commit fd4a5417 authored by Axel Lin's avatar Axel Lin Committed by Luis Henriques

genirq: devres: Fix testing return value of request_any_context_irq()

commit 63781394 upstream.

request_any_context_irq() returns a negative value on failure.
It returns either IRQC_IS_HARDIRQ or IRQC_IS_NESTED on success.
So fix testing return value of request_any_context_irq().

Also fixup the return value of devm_request_any_context_irq() to make it
consistent with request_any_context_irq().

Fixes: 0668d306 ("genirq: Add devm_request_any_context_irq()")
Signed-off-by: default avatarAxel Lin <axel.lin@ingics.com>
Reviewed-by: default avatarStephen Boyd <sboyd@codeaurora.org>
Link: http://lkml.kernel.org/r/1431334978.17783.4.camel@ingics.comSigned-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
Signed-off-by: default avatarLuis Henriques <luis.henriques@canonical.com>
parent e4fa50cd
...@@ -104,7 +104,7 @@ int devm_request_any_context_irq(struct device *dev, unsigned int irq, ...@@ -104,7 +104,7 @@ int devm_request_any_context_irq(struct device *dev, unsigned int irq,
return -ENOMEM; return -ENOMEM;
rc = request_any_context_irq(irq, handler, irqflags, devname, dev_id); rc = request_any_context_irq(irq, handler, irqflags, devname, dev_id);
if (rc) { if (rc < 0) {
devres_free(dr); devres_free(dr);
return rc; return rc;
} }
...@@ -113,7 +113,7 @@ int devm_request_any_context_irq(struct device *dev, unsigned int irq, ...@@ -113,7 +113,7 @@ int devm_request_any_context_irq(struct device *dev, unsigned int irq,
dr->dev_id = dev_id; dr->dev_id = dev_id;
devres_add(dev, dr); devres_add(dev, dr);
return 0; return rc;
} }
EXPORT_SYMBOL(devm_request_any_context_irq); EXPORT_SYMBOL(devm_request_any_context_irq);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment