- 06 Sep, 2024 11 commits
-
-
Tobias Jakobi authored
dc_state_destruct() nulls the resource context of the DC state. The pipe context passed to dcn35_set_drr() is a member of this resource context. If dc_state_destruct() is called parallel to the IRQ processing (which calls dcn35_set_drr() at some point), we can end up using already nulled function callback fields of struct stream_resource. The logic in dcn35_set_drr() already tries to avoid this, by checking tg against NULL. But if the nulling happens exactly after the NULL check and before the next access, then we get a race. Avoid this by copying tg first to a local variable, and then use this variable for all the operations. This should work, as long as nobody frees the resource pool where the timing generators live. Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/3142 Fixes: 06ad7e16 ("drm/amd/display: Destroy DC context while keeping DML and DML2") Signed-off-by:
Tobias Jakobi <tjakobi@math.uni-bielefeld.de> Reviewed-by:
Harry Wentland <harry.wentland@amd.com> Signed-off-by:
Mario Limonciello <mario.limonciello@amd.com> Signed-off-by:
Alex Deucher <alexander.deucher@amd.com>
-
Tobias Jakobi authored
dc_state_destruct() nulls the resource context of the DC state. The pipe context passed to dcn10_set_drr() is a member of this resource context. If dc_state_destruct() is called parallel to the IRQ processing (which calls dcn10_set_drr() at some point), we can end up using already nulled function callback fields of struct stream_resource. The logic in dcn10_set_drr() already tries to avoid this, by checking tg against NULL. But if the nulling happens exactly after the NULL check and before the next access, then we get a race. Avoid this by copying tg first to a local variable, and then use this variable for all the operations. This should work, as long as nobody frees the resource pool where the timing generators live. Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/3142 Fixes: 06ad7e16 ("drm/amd/display: Destroy DC context while keeping DML and DML2") Signed-off-by:
Raoul van Rüschen <raoul.van.rueschen@gmail.com> Tested-by:
Christopher Snowhill <chris@kode54.net> Reviewed-by:
Sefa Eyeoglu <contact@scrumplex.net> Signed-off-by:
-
Li Zetao authored
When it needs to get a value within a certain interval, using clamp() makes the code easier to understand than min(max()). Reviewed-by:
Christian König <christian.koenig@amd.com> Signed-off-by:
Li Zetao <lizetao1@huawei.com> Signed-off-by:
-
Li Zetao authored
When it needs to get a value within a certain interval, using clamp() makes the code easier to understand than min(max()). Reviewed-by:
-
Peng Liu authored
Enabling gfxoff quirk results in perfectly usable graphical user interface on HP 705G4 DM with R5 2400G. Without the quirk, X server is completely unusable as every few seconds there is gpu reset due to ring gfx timeout. Signed-off-by:
Peng Liu <liupeng01@kylinos.cn> Signed-off-by:
-
Peng Liu authored
Fix screen corruption with openkylin. Link: https://bbs.openkylin.top/t/topic/171497Signed-off-by:
-
Colin Ian King authored
There is a spelling mistake in a DRM_DEBUG_DRIVER message. Fix it. Signed-off-by:
Colin Ian King <colin.i.king@gmail.com> Signed-off-by:
-
David Belanger authored
Populate cache line size info in topology based on information from IP discovery table. Signed-off-by:
David Belanger <david.belanger@amd.com> Reviewed-by:
Sreekant Somasekharan <Sreekant.Somasekharan@amd.com> Signed-off-by:
-
Srinivasan Shanmugam authored
This commit addresses a missing kdoc for the 'bs_coeffs_updated' parameter in the 'dpp401_dscl_program_isharp' function. The 'bs_coeffs_updated' is a flag indicating whether the Blur and Scale Coefficients have been updated. The 'dpp401_dscl_program_isharp' function is responsible for programming the isharp, which includes setting the isharp filter, noise gain, and blur and scale coefficients. If the 'bs_coeffs_updated' flag is set to true, the function updates the blur and scale coefficients. Fixes the below with gcc W=1: drivers/gpu/drm/amd/amdgpu/../display/dc/dpp/dcn401/dcn401_dpp_dscl.c:961: warning: Function parameter or struct member 'bs_coeffs_updated' not described in 'dpp401_dscl_program_isharp' Cc: Tom Chung <chiahsuan.chung@amd.com> Cc: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com> Cc: Roman Li <roman.li@amd.com> Cc: Alex Hung <alex.hung@amd.com> Cc: Aurabindo Pillai <aurabindo.pillai@amd.com> Cc: Harry Wentland <harry.wentland@amd.com> Cc: Hamza Mahfooz <hamza.mahfooz@amd.com> Signed-off-by:
Srinivasan Shanmugam <srinivasan.shanmugam@amd.com> Suggested-by:
Tom Chung <chiahsuan.chung@amd.com> Reviewed-by:
-
Lang Yu authored
CPU based update doesn't produce a fence, handle such cases properly. Fixes: d8a3f0a0 ("drm/amdgpu: implement TLB flush fence") Signed-off-by:
Lang Yu <lang.yu@amd.com> Reviewed-by:
-
Christian König authored
Rework how VM operations synchronize to submissions. Provide an amdgpu_sync container to the backends instead of an reservation object and fill in the amdgpu_sync object in the higher layers of the code. No intended functional change, just prepares for upcomming changes. Signed-off-by:
Friedrich Vock <friedrich.vock@gmx.de> Acked-by:
Felix Kuehling <felix.kuehling@amd.com> Signed-off-by:
-
- 05 Sep, 2024 1 commit
-
-
Alex Deucher authored
This reverts commit bbb05f8a. This breaks some manual setting of the profile mode in certain cases. Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/3600Signed-off-by:
-
- 02 Sep, 2024 28 commits
-
-
Alex Deucher authored
Protect the MMIO access with safe mode. Acked-by:
Vitaly Prosyak <vitaly.prosyak@amd.com> Signed-off-by:
-
Alex Deucher authored
Protect the MMIO access with safe mode. Acked-by:
-
Alex Deucher authored
Protect the MMIO access with safe mode. Acked-by:
-
Alex Deucher authored
Rather than open coding it for the queue reset. Acked-by:
-
Alex Deucher authored
Rather than open coding it for the queue reset. Acked-by:
-
Alex Deucher authored
Rather than open coding it for the queue reset. Acked-by:
-
Alex Deucher authored
It's not supported under SR-IOV at the moment. Acked-by:
-
Alex Deucher authored
It's not supported under SR-IOV at the moment. Acked-by:
-
Alex Deucher authored
It's not supported under SR-IOV at the moment. Acked-by:
-
Jiadong Zhu authored
Implement queue reset for graphic and compute queue. v2: use amdgpu_gfx_rlc funcs to enter/exit safe mode. v3: use gfx_v11_0_request_gfx_index_mutex() v4: fix mutex handling Acked-by:
Jiadong Zhu <Jiadong.Zhu@amd.com> Reviewed-by:
-
Jiadong Zhu authored
The reset_queue api could be used from kfd or kgd. v2: add use_mmio parameter for mes_reset_legacy_queue. Acked-by:
-
Jiadong Zhu authored
Add me/pipe/queue parameters for queue reset input. v2: fix build (Alex) Acked-by:
-
Alex Deucher authored
Since the MES FW resets kernel compute queue always failed, this may caused by the KIQ failed to process unmap KCQ. So, before MES FW work properly that will fallback to driver executes dequeue and resets SPI directly. Besides, rework the ring reset function and make the busy ring type reset in each function respectively. Acked-by:
-
Alex Deucher authored
Add ring reset callbacks for gfx and compute. Acked-by:
-
Alex Deucher authored
To match other GFX IPs. Acked-by:
-
Jiadong Zhu authored
There is a racing condition that cp firmware modifies MQD in reset sequence after driver updates it for remapping. We have to wait till CP_HQD_ACTIVE becoming false then remap the queue. v2: fix KIQ locking (Alex) v3: fix KIQ locking harder (Jessie) Acked-by:
-
Jiadong Zhu authored
Kiq command unmap_queues only does the dequeueing action. We have to map the queue back with clean mqd. v2: fix up error handling (Alex) Acked-by:
-
Alex Deucher authored
Add ring reset callbacks for gfx and compute. v2: fix gfx handling v3: wait for KIQ to complete Acked-by:
-
Jiadong Zhu authored
There is a racing condition that cp firmware modifies MQD in reset sequence after driver updates it for remapping. We have to wait till CP_HQD_ACTIVE becoming false then remap the queue. Acked-by:
-
Alex Deucher authored
Rename to gfx_v11_0_kgq_init_queue() to better align with the other naming in the file. Acked-by:
-
Prike Liang authored
Since the MES FW resets kernel compute queue always failed, this may caused by the KIQ failed to process unmap KCQ. So, before MES FW work properly that will fallback to driver executes dequeue and resets SPI directly. Besides, rework the ring reset function and make the busy ring type reset in each function respectively. Acked-by:
Prike Liang <Prike.Liang@amd.com> Reviewed-by:
-
Aric Cyr authored
This version brings along the following: - DCN35 fixes - DML2 fixes - IPS fixes - ODM fixes - Miscellaneous cleanups - MST fixes - SPL fixes Acked-by:
Aurabindo Pillai <aurabindo.pillai@amd.com> Signed-off-by:
Aric Cyr <aric.cyr@amd.com> Signed-off-by:
Hamza Mahfooz <hamza.mahfooz@amd.com> Signed-off-by:
-
Hansen Dsouza authored
Always allow un-gating. Follow legacy workaround for repeated dppclk dto updates Reviewed-by:
Muhammad Ahmed <ahmed.ahmed@amd.com> Signed-off-by:
Hansen Dsouza <Hansen.Dsouza@amd.com> Signed-off-by:
-
Dillon Varone authored
PMO assumes that like timings can be synchronized, but DC only allows this if the signal types match. Reviewed-by:
Austin Zheng <austin.zheng@amd.com> Signed-off-by:
Dillon Varone <dillon.varone@amd.com> Signed-off-by:
-
Gabe Teeger authored
[what] Graphics hang observed with 3 displays connected to DP2.0 mst dock. [why] There's a mismatch in dml and dc between the assignments of hpo link encoders. [how] Add a new array in dml that tracks the current mapping of HPO stream encoders to HPO link encoders in dc. Reviewed-by:
Sung joon Kim <sungjoon.kim@amd.com> Reviewed-by:
Nicholas Kazlauskas <nicholas.kazlauskas@amd.com> Signed-off-by:
Gabe Teeger <Gabe.Teeger@amd.com> Signed-off-by:
-
Relja Vojvodic authored
- Add interface for controlling shapness level input into DCN. - Update SPL to support custom sharpness values. - Add support for different sharpness values depending on YUV/RGB content. Reviewed-by:
Samson Tam <samson.tam@amd.com> Signed-off-by:
Relja Vojvodic <Relja.Vojvodic@amd.com> Signed-off-by:
-
Dillon Varone authored
This reverts commit f0b7dcf2. It is causing graphics hangs. Reviewed-by:
Martin Leung <martin.leung@amd.com> Signed-off-by:
-
Samson Tam authored
[Why] Certain profiles have higher HDR multiplier than SDR boost max which is not currently supported [How] Disable sharpness for these profiles Fixes: 1b0ce903 ("drm/amd/display: add improvements for text display and HDR DWM and MPO") Reviewed-by:
-
