- 16 Nov, 2023 5 commits
-
-
Dmitry Baryshkov authored
While developing and testing the commit bfcc3d8f ("drm/msm/dp: support setting the DP subconnector type") I had the patch [1] in my tree. I haven't noticed that it was a dependency for the commit in question. Mea culpa. Since the patch has not landed yet (and even was not reviewed) and since one of the bridges erroneously uses USB connector type instead of DP, attach the property directly from the MSM DP driver. This fixes the following oops on DP HPD event: drm_object_property_set_value (drivers/gpu/drm/drm_mode_object.c:288) dp_display_process_hpd_high (drivers/gpu/drm/msm/dp/dp_display.c:402) dp_hpd_plug_handle.isra.0 (drivers/gpu/drm/msm/dp/dp_display.c:604) hpd_event_thread (drivers/gpu/drm/msm/dp/dp_display.c:1110) kthread (kernel/kthread.c:388) ret_from_fork (arch/arm64/kernel/entry.S:858) [1] https://patchwork.freedesktop.org/patch/555530/ Fixes: bfcc3d8f ("drm/msm/dp: support setting the DP subconnector type") Reviewed-by:
Abhinav Kumar <quic_abhinavk@quicinc.com> Signed-off-by:
Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Tested-by: Jessica Zhang <quic_jesszhan@quicinc.com> # SC7280 Reviewed-by:
Johan Hovold <johan+linaro@kernel.org> Tested-by:
-
Abel Vesa authored
In case of the eDP connection there is no subconnetor and as such no subconnector property. Put drm_dp_set_subconnector_property() calls under the !is_edp condition. Fixes: bfcc3d8f ("drm/msm/dp: support setting the DP subconnector type") Signed-off-by:
Abel Vesa <abel.vesa@linaro.org> Signed-off-by:
-
Bjorn Andersson authored
During USB transfers on the SC8280XP __arm_smmu_tlb_sync() is seen to typically take 1-2ms to complete. As expected this results in poor performance, something that has been mitigated by proposing running the iommu in non-strict mode (boot with iommu.strict=0). This turns out to be related to the SAFE logic, and programming the QOS SAFE values in the DPU (per suggestion from Rob and Doug) reduces the TLB sync time to below 10us, which means significant less time spent with interrupts disabled and a significant boost in throughput. Fixes: 4a352c2f ("drm/msm/dpu: Introduce SC8280XP") Cc: stable@vger.kernel.org Suggested-by:
Doug Anderson <dianders@chromium.org> Suggested-by:
Rob Clark <robdclark@chromium.org> Signed-off-by:
Bjorn Andersson <quic_bjorande@quicinc.com> Tested-by:
Steev Klimaszewski <steev@kali.org> Reviewed-by:
-
Dmitry Baryshkov authored
It seems during rebases I have left a call to drm_kms_helper_poll_init() which is not guarded by the (priv->kms_init) check. This leads to the crash for the boards which don't have KMS output. Drop this call, as there is a correctly guarded one next to the one being removed. Fixes: 506efcba ("drm/msm: carve out KMS code from msm_drv.c") Signed-off-by:
-
Jonathan Marek authored
Use the same value as the downstream driver. This change is needed for CPHY mode to work correctly. Fixes: 8b034e67 ("drm/msm/dsi: add support for DSI-PHY on SM8550") Signed-off-by:
Jonathan Marek <jonathan@marek.ca> Reviewed-by:
-
- 16 Oct, 2023 9 commits
-
-
Dmitry Baryshkov authored
Make a6xx_get_registers() use a7xx registers instead of a6xx ones if the detected Adreno is from the A7xx family. Fixes: e997ae5f ("drm/msm/a6xx: Mostly implement A7xx gpu_state") Signed-off-by:
-
Neil Armstrong authored
Enable WB2 hardware block, enabling writeback support on this platform. Reviewed-by:
Neil Armstrong <neil.armstrong@linaro.org> Patchwork: https://patchwork.freedesktop.org/patch/562328/Signed-off-by:
-
Neil Armstrong authored
The SM8550 has the SSPP clk_ctrl in the SSPP registers, remove the duplicate clock controls from the MDP top. Reviewed-by:
-
Neil Armstrong authored
Now SSPP and WB can have setup_force_clk_ctrl() ops, it's simpler to call them from the plane and wb code and call into the mdp ops if not present. Reviewed-by:
-
Neil Armstrong authored
Starting from SM8550, the SSPP & WB clock controls are moved the SSPP and WB register range, as it's called "VBIF_CLK_SPLIT" downstream. Implement setup_clk_force_ctrl() only starting from major version 9 which corresponds to SM8550 MDSS. Reviewed-by:
-
Neil Armstrong authored
Add an helper to setup the force clock control as it will be used in multiple HW files. Reviewed-by:
-
Konrad Dybcio authored
The commit referenced in the Fixes tag had a couple problems (as pointed out by Dan): - qmp_put was never called, resulting in refcnt leaks - failling to acquire the QMP mailbox on A7xx would not undo the probe function properly - the qmp_put call present in the code was unreachable Fix all of these issues. Reported-by:
Dan Carpenter <dan.carpenter@linaro.org> Fixes: 88a0997f ("drm/msm/a6xx: Send ACD state to QMP at GMU resume") Signed-off-by:
Konrad Dybcio <konrad.dybcio@linaro.org> Patchwork: https://patchwork.freedesktop.org/patch/562761/Signed-off-by:
-
Dmitry Baryshkov authored
If the drm/msm init code gets an error during output modeset initialisation, the kernel will report an error regarding DRM memory manager not being clean during shutdown. This is because msm_dsi_modeset_init() allocates a piece of GEM memory for the TX buffer, but destruction of the buffer happens only at msm_dsi_host_destroy(), which is called during DSI driver's remove() time, much later than the DRM MM shutdown. To solve this issue, move the TX buffer destruction to dsi_unbind(), so that the buffer is destructed at the correct time. Note, we also have to store a reference to the address space, because priv->kms->aspace is cleared before components are unbound. Reported-by:
Bjorn Andersson <andersson@kernel.org> Fixes: 8f59ee9a ("drm/msm/dsi: Adjust probe order") Signed-off-by:
-
Dmitry Baryshkov authored
Use exiting function to free the allocated GEM object instead of open-coding it. This has a bonus of internally calling msm_gem_put_vaddr() to compensate for msm_gem_get_vaddr() in msm_get_kernel_new(). Fixes: 1e29dff0 ("drm/msm: Add a common function to free kernel buffer objects") Signed-off-by:
-
- 11 Oct, 2023 3 commits
-
-
Dmitry Baryshkov authored
The lifetime of the created drm_bridge is attached to the drm_device rather than the DP's platform_device. Use correct lifetime for devm_drm_bridge_add() call. Fixes: 61a72d5e ("drm/msm/dp: switch to devm_drm_bridge_add()") Signed-off-by:
-
Dmitry Baryshkov authored
The lifetime of the created drm_bridge is attached to the drm_device rather than the HDMI's platform_device. Use correct lifetime for devm_drm_bridge_add() call. Fixes: 719093a6 ("drm/msm/hdmi: switch to devm_drm_bridge_add()") Signed-off-by:
-
Dmitry Baryshkov authored
The lifetime of the created drm_bridge is attached to the drm_device rather than the DSI's platform_device. Use correct lifetime for devm_drm_bridge_add() call. Fixes: 5f403fd7 ("drm/msm/dsi: switch to devm_drm_bridge_add()") Signed-off-by:
-
- 10 Oct, 2023 1 commit
-
-
Dmitry Baryshkov authored
Readd the header that was erroneously dropped during KMS code refactoring. Fixes: 506efcba ("drm/msm: carve out KMS code from msm_drv.c") Reported-by:
kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202310100836.6E6zjEcE-lkp@intel.com/Signed-off-by:
-
- 09 Oct, 2023 22 commits
-
-
Dmitry Baryshkov authored
The msm_drv.c contains generic code intermixed with KMS handling code. Move all KMS-related code to a separate msm_kms.c file, cleaning up init code while doing this move. This also prevents msm driver from registering modesetting / atomic interfaces in the headless case. Reviewed-by:
Rob Clark <robdclark@gmail.com> Signed-off-by:
-
Dmitry Baryshkov authored
Don't register the 'fb' debugfs file, if there is no KMS (and so no framebuffers). Reviewed-by:
-
Dmitry Baryshkov authored
There is little point in having the empty debugfs file which always returns -ENODEV. Change this file to be created only if KMS is actually used. Reviewed-by:
-
Dmitry Baryshkov authored
Switch to drmm_mode_config_init() instead of drm_mode_config_init(). Drop drm_mode_config_cleanup() calls. Reviewed-by:
-
Dmitry Baryshkov authored
The msm_drv_shutdown function should only be used in the KMS case. Rename it accordingly. Reviewed-by:
-
Dmitry Baryshkov authored
The msm_drv_shutdown only makes sense for the KMS-enabled devices, while msm_platform_driver is only used in the headless case. Remove the shutdown callback from the driver structure. Reviewed-by:
-
Dmitry Baryshkov authored
Rename the msm_pm_prepare() and msm_pm_complete() to msm_kms_pm_prepare() and msm_kms_pm_complete() consequently. Reviewed-by:
-
Dmitry Baryshkov authored
The msm_pm_prepare()/msm_pm_complete() only make sense for the KMS-enabled devices, they have priv->kms guards inside. Drop global msm_pm_ops, which were used only by the headless msm device. Reviewed-by:
-
Dmitry Baryshkov authored
As all output devices have switched to devm_drm_bridge_add(), we can drop the bridges array from struct msm_drm_private. Reviewed-by:
-
Dmitry Baryshkov authored
Make MSM DP driver use devm_drm_bridge_add() instead of plain drm_bridge_add(). As the driver doesn't require any additional cleanup, stop adding created bridge to the priv->bridges array. Reviewed-by:
-
Dmitry Baryshkov authored
The dp_drm needs accessing the DP's platform device. Move pdev to the public structure. Reviewed-by:
-
Dmitry Baryshkov authored
Make MSM HDMI driver use devm_drm_bridge_add() instead of plain drm_bridge_add(). As the driver doesn't require any additional cleanup, stop adding created bridge to the priv->bridges array. Reviewed-by:
-
Dmitry Baryshkov authored
Make MSM DSI driver use devm_drm_bridge_add() instead of plain drm_bridge_add(). As the driver doesn't require any additional cleanup, stop adding created bridge to the priv->bridges array. Reviewed-by:
-
Dmitry Baryshkov authored
To let the probe function bail early if any of the resources is unavailable, move resource allocattion from kms_init directly to the probe callback. Reviewed-by:
-
Dmitry Baryshkov authored
To let the probe function bail early if any of the resources is unavailable, move resource allocattion from kms_init directly to the probe callback. While we are at it, replace irq_of_parse_and_map() with platform_get_irq(). Reviewed-by:
-
Dmitry Baryshkov authored
To let the probe function bail early if any of the resources is unavailable, move resource allocattion from kms_init directly to the probe callback. While we are at it, replace irq_of_parse_and_map() with platform_get_irq(). This also drops devm_iounmap() calls. It is too early to have them _dpu_kms_hw_destroy() (or it will break if for some reason DPU device is rebound into the composite device) and it doesn't make sense to have them in dpu_dev_remove (as everything will be torn down by the devres anyway after the device is unbound from the driver). Reviewed-by:
-
Dmitry Baryshkov authored
In preparation of moving resource allocation to the probe time, allow MSM KMS drivers to pass struct msm_kms pointer via msm_drv_probe(). Reviewed-by:
-
Konrad Dybcio authored
Downstream calls this the "speedbin 1", but that number is already occupied. Use index two. Signed-off-by:
-
Konrad Dybcio authored
Some (many?) devices with A635 expect a ZAP shader to be loaded. Set the file name to allow for that. Signed-off-by:
-
Konrad Dybcio authored
When opp-supported-hw is present under an OPP node, but no form of opp_set_supported_hw() has been called, that OPP is ignored by the API and marked as unsupported. Before Commit c928a05e ("drm/msm/adreno: Move speedbin mapping to device table"), an unknown speedbin would result in marking all OPPs as available, but it's better to avoid potentially overclocking the silicon - the GMU will simply refuse to power up the chip. Currently, the Adreno speedbin code does just that (AND returns an invalid error, (int)UINT_MAX). Fix that by defaulting to speedbin 0 (which is conveniently always bound to fuseval == 0). Fixes: c928a05e ("drm/msm/adreno: Move speedbin mapping to device table") Signed-off-by:
-
Konrad Dybcio authored
SM6375 comes with a patchlevel=1. Fix the chipid up to reflect that. Fixes: 90b593ce ("drm/msm/adreno: Switch to chip-id for identifying GPU") Signed-off-by:
-
Konrad Dybcio authored
Some GPUs - particularly A7xx ones - are really really stubborn and sometimes take a longer-than-expected time to finish unhalting GBIF. Note that this is not caused by the request a few lines above. Poll for the unhalt ack to make sure we're not trying to write bits to an essentially dead GPU that can't receive data on its end of the bus. Failing to do this will result in inexplicable GMU timeouts or worse. This is a rather ugly hack which introduces a whole lot of latency. Tested-by: Neil Armstrong <neil.armstrong@linaro.org> # on SM8550-QRD Tested-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> # sm8450 Signed-off-by:
-
