- 13 May, 2022 38 commits
-
-
Randy Dunlap authored
Fix build errors when RADIO_TEA575X=y, VIDEO_BT848=m, and VIDEO_DEV=m. The build errors occur due to [in drivers/media/Makefile]: obj-$(CONFIG_VIDEO_DEV) += radio/ so the (would be) builtin tea575x.o is not being built. This is also due to drivers/media/radio/Kconfig declaring a bool Kconfig symbol (RADIO_ADAPTERS) that depends on a tristate (VIDEO_DEV), so when VIDEO_DEV=m, RADIO_ADAPTERS becomes =y, and then the drivers that depend on RADIO_ADPATERS can be configured as builtin (=y) or as loadable modules (=m). Fix this by converting RADIO_ADAPTERS to a tristate symbol instead of a bool symbol. Fixes these build errors: ERROR: modpost: "snd_tea575x_hw_init" [drivers/media/pci/bt8xx/bttv.ko] undefined! ERROR: modpost: "snd_tea575x_set_freq" [drivers/media/pci/bt8xx/bttv.ko] undefined! ERROR: modpost: "snd_tea575x_s_hw_freq_seek" [drivers/media/pci/bt8xx/bttv.ko] undefined! ERROR: modpost: "snd_tea575x_enum_freq_bands" [drivers/media/pci/bt8xx/bttv.ko] undefined! ERROR: modpost: "snd_tea575x_g_tuner" [drivers/media/pci/bt8xx/bttv.ko] undefined! Link: lore.kernel.org/r/202204191711.IKJJFjgU-lkp@intel.com Fixes: 9958d30f ("media: Kconfig: cleanup VIDEO_DEV dependencies") Signed-off-by:
Randy Dunlap <rdunlap@infradead.org> Reported-by:
kernel test robot <lkp@intel.com> Signed-off-by:
Hans Verkuil <hverkuil-cisco@xs4all.nl> Signed-off-by:
Mauro Carvalho Chehab <mchehab@kernel.org>
-
Pavel Skripkin authored
Syzbot reported that -1 is used as array index. The problem was in missing validation check. hdw->unit_number is initialized with -1 and then if init table walk fails this value remains unchanged. Since code blindly uses this member for array indexing adding sanity check is the easiest fix for that. hdw->workpoll initialization moved upper to prevent warning in __flush_work. Reported-and-tested-by: syzbot+1a247e36149ffd709a9b@syzkaller.appspotmail.com Fixes: d855497e ("V4L/DVB (4228a): pvrusb2 to kernel 2.6.18") Signed-off-by:
Pavel Skripkin <paskripkin@gmail.com> Signed-off-by:
-
Niklas Söderlund authored
Remove a stray blank line between function definition and body. Signed-off-by:
Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> Reviewed-by:
Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> Signed-off-by:
-
Sebastian Fricke authored
Describe the coding tree unit as replacement for the macroblock in the HEVC codec. Highlight a key difference of the HEVC codec to predecessors like AVC(H.264) to give a better overview of the differences between the coding standards. [hverkuil: replaced the 'corresponds to' symbol with the full text for clarity] Signed-off-by:
Sebastian Fricke <sebastian.fricke@collabora.com> Acked-by:
Jernej Skrabec <jernej.skrabec@gmail.com> Signed-off-by:
-
Sebastian Fricke authored
VP9 support has been added to the driver by commit f25709c4 ("media: rkvdec: Add the VP9 backend"). And the VP9 uABI was merged with commit b88dbe38 ("media: uapi: Add VP9 stateless decoder controls"). The remaining codec that keeps this driver in staging is HEVC. Update the TODO list accordingly. Signed-off-by:
Nicolas Dufresne <nicolas.dufresne@collabora.com> Signed-off-by:
-
Sebastian Fricke authored
VP8 has been added to the uABI by commit 363240ce ("media: uapi: move VP8 stateless controls out of staging") VP9 has been added to the uABI by commit b88dbe38 ("media: uapi: Add VP9 stateless decoder controls") H264 has been added to the uABI by commit 46a309d2 ("media: uapi: move H264 stateless controls out of staging") The last remaining codec to be added to the uABI is HEVC. Highlight these changes in the TODO list. Signed-off-by:
-
Sebastian Fricke authored
Fix typos in comments within the Hantro driver. Signed-off-by:
-
Hangyu Hua authored
rga->m2m_dev needs to be freed when rga_probe fails. Signed-off-by:
Hangyu Hua <hbh25y@gmail.com> Signed-off-by:
-
Ming Qian authored
To support dynamic resolution change, driver should meet the following conditions: 1. the previous pictures are all decoded before source change event. 2. prevent decoding new resolution pictures with incorrect capture buffer, until user handle source change event and setup capture. 3. report correct fmt and resolution during source change. Signed-off-by:
Ming Qian <ming.qian@nxp.com> Reviewed-by:
Mirela Rabulea <mirela.rabulea@nxp.com> Signed-off-by:
-
Ming Qian authored
Refine code to support dynamic resolution change Signed-off-by:
-
Ming Qian authored
The GStreamer v4l2videodec only ever calls S_FMT on the output side and then expects G_FMT on the capture side to return a valid format. Signed-off-by:
-
Ming Qian authored
The decoder will save the precision that was detected from jpeg header and use it later, when choosing the pixel format and also calculate bytesperline according to precision. The 12bit jpeg is not supported yet, but driver shouldn't led to serious problem if user enqueue a 12 bit jpeg. And the 12bit jpeg is supported by hardware, driver may support it later. [hverkuil: document the new precision field] Signed-off-by:
-
Ming Qian authored
Refine code to support dynamic resolution change Signed-off-by:
-
Husni Faiz authored
This patch fixes "space prohibited before that ':'" checkpatch error in the switch statements. Suggested-by:
Husni Faiz <ahamedhusni73@gmail.com> Signed-off-by:
-
Husni Faiz authored
This patch fixes "switch and case should be at the same indent" checkpatch error. Signed-off-by:
-
Tom Rix authored
Clang static analysis reports this issue ispcsiphy.c:63:14: warning: The left operand of '<<' is a garbage value reg |= mode << shift; ~~~~ ^ The iface switch-statement default case falls through to ISP_INTERFACE_CCP2B_PHY1. Which is later checked to set the mode. Since the default case is left out of this check mode is never set. Instead of falling through and assuming a ISP_INTERFACE_CCP2B_PHY1 iface, return. Signed-off-by:Tom Rix <trix@redhat.com> Reviewed-by:
Nick Desaulniers <ndesaulniers@google.com> Signed-off-by:
-
Miaoqian Lin authored
The corresponding API for clk_prepare_enable is clk_disable_unprepare, other than clk_disable. Fix this by changing clk_disable to clk_disable_unprepare. Fixes: b4155d7d ("[media] exynos4-is: Ensure fimc-is clocks are not enabled until properly configured") Signed-off-by:
Miaoqian Lin <linmq006@gmail.com> Signed-off-by:
-
Laurent Pinchart authored
The ceu_data_rz variable is unused when CONFIG_OF isn't set. This generates a compiler warning. Fix it. Signed-off-by:
Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by:
Jacopo Mondi <jacopo@jmondi.org> Reviewed-by:
Geert Uytterhoeven <geert+renesas@glider.be> Reported-by:
-
Dan Carpenter authored
We verified that "vpif_obj.sd[i]" is non-NULL on the previous line so no need to check here. Signed-off-by:
Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by:
-
Dan Carpenter authored
The "bdisp->clock" variable cannot be an error pointer here. No need to check. Signed-off-by:
-
Jiapeng Chong authored
Eliminate the follow versioncheck warning: ./drivers/media/platform/stm/sti/c8sectpfe/c8sectpfe-common.h: 16 linux/version.h not needed. Reported-by:
Abaci Robot <abaci@linux.alibaba.com> Signed-off-by:
Jiapeng Chong <jiapeng.chong@linux.alibaba.com> Signed-off-by:
-
Jacopo Mondi authored
The RDACM20 camera supports a single image format which is currently listed as MEDIA_BUS_FMT_UYVY8_2X8. As the video stream is transmitted on the GMSL serial bus, the 2X8 variant does not apply. Fix the format by using MEDIA_BUS_FMT_UYVY8_1X16. This fixes a runtime error which is now triggered as the MAX9286 deserializer implements .link_validate(). Signed-off-by:
Jacopo Mondi <jacopo+renesas@jmondi.org> Reviewed-by:
-
Niklas Söderlund authored
Add a check to make sure the input interface (CSI-2 or parallel) allow for the requested input bus format. If not inform the user and error out rather then try to continue with incorrect settings. While at it add the missing define for RGB666 that is not yet supported in the driver but we can preemptively check for it in this context already. Signed-off-by:
-
Lukas Bulwahn authored
Commit 46fb9995 ("media: platform: place NXP drivers on a separate dir") moves various files in media/platform into a nxp subdirectory. It adjusts the section MEDIA DRIVER FOR FREESCALE IMX PXP in MAINTAINERS, but misses some references in NXP i.MX 8QXP/8QM JPEG V4L2 DRIVER and MEDIA DRIVERS FOR FREESCALE IMX7. Hence, ./scripts/get_maintainer.pl --self-test=patterns complains about a broken reference. Adjust the file references in the NXP i.MX 8QXP/8QM JPEG V4L2 DRIVER and MEDIA DRIVERS FOR FREESCALE IMX7 sections. Signed-off-by:
Lukas Bulwahn <lukas.bulwahn@gmail.com> Signed-off-by:
-
Laurent Pinchart authored
The v4l2_m2m_dev structure documentation incorrectly references the v4l2_m2m_unregister_media_controller() function when it actually means v4l2_m2m_register_media_controller(). Fix it. Signed-off-by:
-
Tom Rix authored
smb_word_op() has a parameter data_format that determines if the data is either a byte or word. From inspection, smb_word_op() is only used by the macros smb_wr16() and smb_rd16() both pass in CMD_WORD_DATA. There is no use of smb_word_op() that passes in CMD_BYTE_DATA. So remove the byte handling. Signed-off-by:
-
Laurentiu Palcu authored
The subdevice entity function was left unset, which produces a warning when probing the device: mxc-md bus@58000000:camera: Entity type for entity rdacm20 19-0051 was not initialized! This patch will set entity function to MEDIA_ENT_F_CAM_SENSOR and leave flags unset. Fixes: 34009bff ("media: i2c: Add RDACM20 driver") Fixes: a59f853b ("media: i2c: Add driver for RDACM21 camera module") Signed-off-by:
Laurentiu Palcu <laurentiu.palcu@oss.nxp.com> Reviewed-by:
-
Mirela Rabulea authored
Fix smatch warning in mxc_jpeg_queue_setup, check *nplanes against current format: drivers/media/platform/imx-jpeg/mxc-jpeg.c:1070 mxc_jpeg_queue_setup() warn: potential user controlled iterator 'i' (array size 2 vs 7) Signed-off-by:Mirela Rabulea <mirela.rabulea@oss.nxp.com> Signed-off-by:
-
Lukas Bulwahn authored
After sending a patch to Rick Chang, the mediatek mail server responded: ** Message not delivered ** Your message couldn't be delivered to rick.chang@mediatek.com because the remote server is misconfigured. See technical details below for more information. The response from the remote server was: 550 Relaying mail to rick.chang@mediatek.com is not allowed So, drop Rick Chang from the MEDIATEK JPEG DRIVER section. Signed-off-by:
Miles Chen <miles.chen@mediatek.com> Signed-off-by:
-
Lukas Bulwahn authored
Commit 9cdd70ce ("media: dt-bindings: media: mtk-vcodec: Separate video encoder and decoder dt-bindings") converts and splits mediatek-vcodec.txt to mediatek,vcodec-{de,en}coder.yaml, but missed to adjust its reference in MAINTAINERS. Hence, ./scripts/get_maintainer.pl --self-test=patterns complains about a broken reference. Repair this file reference in MEDIATEK MEDIA DRIVER. Signed-off-by:
-
Lukas Bulwahn authored
Commit a16ce2f3 ("media: dt-bindings: mediatek: convert mtk jpeg decoder/encoder to yaml") converts mediatek-jpeg-decoder.txt to yaml, but missed to adjust its reference in MAINTAINERS. Hence, ./scripts/get_maintainer.pl --self-test=patterns complains about a broken reference. While touching this section, generalize the file entry to also cover the encoder yaml devicetree, as the driver directory also includes the encoder. Signed-off-by:
-
Colin Ian King authored
Don't populate the read-only array table on the stack but instead make it static const. Also makes the object code a little smaller. Signed-off-by:
Colin Ian King <colin.i.king@gmail.com> Signed-off-by:
-
Lukas Bulwahn authored
Commit ccc30162 ("media: dt: bindings: tegra-vde: Convert to schema") converts nvidia,tegra-vde.txt to nvidia,tegra-vde.yaml, but missed to adjust its reference in MAINTAINERS. Hence, ./scripts/get_maintainer.pl --self-test=patterns complains about a broken reference. Repair this file reference in MEDIA DRIVERS FOR NVIDIA TEGRA - VDE. Signed-off-by:
Dmitry Osipenko <digetx@gmail.com> Signed-off-by:
-
Miaoqian Lin authored
The pm_runtime_enable will decrease power disable depth. If the probe fails, we should use pm_runtime_disable() to balance pm_runtime_enable(). Fixes: 0a0e2655 ("media: atmel: atmel-isc: split driver into driver base and isc") Signed-off-by:
-
Miaoqian Lin authored
The pm_runtime_enable will decrease power disable depth. If the probe fails, we should use pm_runtime_disable() to balance pm_runtime_enable(). Fixes: f386509e ("[media] st-delta: STiH4xx multi-format video decoder v4l2 driver") Signed-off-by:
Hugues Fruchet <hugues.fruchet@foss.st.com> Signed-off-by:
-
Miaoqian Lin authored
If probe fails then we need to call pm_runtime_disable() to balance out the previous pm_runtime_enable() call. Fixes: 9a761e43 ("[media] exynos4-is: Add Exynos4x12 FIMC-IS driver") Signed-off-by:
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> Reviewed-by:
Alim Akhtar <alim.akhtar@samsung.com> Signed-off-by:
-
Christophe JAILLET authored
A dma_free_coherent() call is missing in the error handling path of the probe, as already done in the remove function. In fact, this call is included in aspeed_video_free_buf(). So use the latter both in the error handling path of the probe and in the remove function. It is easier to see the relation with aspeed_video_alloc_buf() this way. Fixes: d2b4387f ("media: platform: Add Aspeed Video Engine driver") Signed-off-by:
Christophe JAILLET <christophe.jaillet@wanadoo.fr> Signed-off-by:
-
Nícolas F. R. A. Prado authored
The encoder node may be dependent on a power-domain. Add a property for it. Signed-off-by:
Nícolas F. R. A. Prado <nfraprado@collabora.com> Acked-by:
Rob Herring <robh@kernel.org> Signed-off-by:
-
- 08 May, 2022 2 commits
-
-
James_Lin authored
This patch aims to add UVC_GUID_FORMAT_H265 High Efficiency Video Coding (HEVC), also known as H.265 and MPEG-H Part 2. They describe the same video encoding method. So for handling their behavior is the same. However, when external camera device describes this encoding method, some use hevc, some use h265. There is no uniform specification to describe this encoding method. So if an external camera device use h265 to describe this encoding method, driver will not recognize it. Therefore, this patch is to enable driver to read HEVC/H265 and convert it to V4L2_PIX_FMT_HEVC. Signed-off-by:
James_Lin <Ping-lei.Lin@mediatek.com> Reviewed-by:
Ricardo Ribalda <ribalda@chromium.org> Signed-off-by:
-
Ricardo Ribalda authored
Replace manual decoding of psize in uvc_parse_streaming(), with the code from uvc_endpoint_max_bpi(). It also handles usb3 devices. Signed-off-by:
-
