- 28 Jul, 2010 36 commits
-
-
Vasu Dev authored
This is per FC-BB-5 Annex-D recommendation and per that if address checking fails then drop the frame. FIP code paths are already doing this so only needed for fcoe frames. The src address checking is limited to only fip mode since this might break non-fip mode used in p2p due to used OUI based addressing in some p2p code paths, going forward FIP will be the only mode, therefore limited this to only FIP mode so that it won't break non-fip p2p mode for now. -v2 Removes FCOE packet type checking since fcoe_rcv is registered to receive only FCoE type packets from netdev and it is already checked by netdev. Signed-off-by:
Vasu Dev <vasu.dev@intel.com> Signed-off-by:
Robert Love <robert.w.love@intel.com> Signed-off-by:
James Bottomley <James.Bottomley@suse.de>
-
Vasu Dev authored
The fc_fabric_logoff and fc_fabric_login are redundant here after recently added fcoe_ctlr_link_down/up to these functions, therefore this patch removes logoff and login to only use link down and up here. This works best for their current usages with fcoe DCB link down or up. This also works well to avoid EIO errors when fcoe DCB link goes down as lport state moves out of ready quickly from fcoe_ctlr_link_down and that allows re-queuing timed out IOs for this case also. Signed-off-by:
-
Vasu Dev authored
In this case, sync IO fails with EIO(5) errors as:- "Thread:1 System call error:5 - Input/output error (::pwrite() failed)". This is due to IO time out while libfc doing link down processing to block all rports and if timed out IO was at last retry attempt then it fails to user with EIO error followed by these log messages. [77848.612169] host2: rport bf0015: Delete port [77848.612221] host2: rport e10aef: work delete [77848.612232] host2: rport e10002: work event 3 [77848.612422] sd 2:0:1:1: [sdi] Unhandled error code [77848.612426] sd 2:0:1:1: [sdi] Result: hostbyte=DID_ERROR driverbyte=DRIVER_OK [77848.612431] sd 2:0:1:1: [sdi] CDB: Write(10): 2a 00 00 00 11 20 00 00 20 00 [77848.612445] end_request: I/O error, dev sdi, sector 4384 [77848.612553] sd 2:0:1:2: [sdj] Unhandled error code To fix these EIO errors, such timed out incomplete IOs needs to be re-queued without counting retry attempt and this patch does that using DID_REQUEUE scsi code. Signed-off-by:
-
Bart Van Assche authored
Analyzing fcoe with sparse currently fails. This is because struct fcoe_rcv_info contains two enum members that have been declared with __attribute__((packed)). Apparently gcc honors this attribute while sparse ignores it. The result is that sizeof(struct fcoe_rcv_info) == sizeof(struct sk_buff::cb) == 48 on a 64-bit system according to gcc, but not according to sparse. The patch below modifies the definition of struct fcoe_rcv_info such that gcc and sparse interpret this structure definition in the same way. The current sparse output is as follows: $ cd linux-2.6.34 $ make C=2 M=drivers/scsi/fcoe modules CHECK drivers/scsi/fcoe/fcoe.c include/scsi/fc_frame.h:81:9: error: invalid bitfield width, -1. CC [M] drivers/scsi/fcoe/fcoe.o CHECK drivers/scsi/fcoe/libfcoe.c include/scsi/fc_frame.h:81:9: error: invalid bitfield width, -1. drivers/scsi/fcoe/libfcoe.c:56:37: error: invalid initializer Signed-off-by:
Bart Van Assche <bart.vanassche@gmail.com> Cc: jeykholt@cisco.com Signed-off-by:
-
Yi Zou authored
This is exposed by a mpio test using EMC CLARiiON targets when LUN tresspassing happens, the burst length from the XFER_READY for the MODE SELECT(10) is 19 bytes, much smaller than FC_MIN_MAX_PAYLOAD as 256 bytes. This patch removes the related two WARN_ON()s. Signed-off-by:
Yi Zou <yi.zou@intel.com> Signed-off-by:
-
Yanqing_Liu@Dell.com authored
This patch is to add next generation of Dell iSCSI PowerVault controller MD36xxi into RDAC device list. Signed-off-by:
Yanqing Liu <Yanqing_Liu@Dell.com> Signed-off-by:
-
Dan Carpenter authored
The check to test that "bus_no" was valid came after we had already used it as an array offset. This patch moves it forward. Signed-off-by:
Dan Carpenter <error27@gmail.com> Signed-off-by:
-
James Smart authored
Signed-off-by:
Alex Iannicelli <alex.iannicelli@emulex.com> Signed-off-by:
James Smart <james.smart@emulex.com> Signed-off-by:
-
James Smart authored
Signed-off-by:
-
James Smart authored
FCoE Related Fixes - Correct find-next-FCF routine so that it searches at next FCF rather than current one. - Enhanced round-robin FCF failover algorithm to re-start on "New FCF" async event - Update the manner in which we look at FCFs while they may be in their discovery state. - Use LPFC_FCOE_NULL_VID macro when checkinf for valid vlan_id for FCF Signed-off-by:
-
James Smart authored
- BSG interface related: - Fix node reference count if node is active - Warn if we're overwriting an active CT context - Discovery related: - Clear "Ignore Reg Login" flag when purging mailbox queue - Pay attention to return code for fc_block_scsi_eh() - Stall device loss code if we're almost done when it fires (we're logged in, but PRLI is outstanding) - Bugs - Correct DIF code for endianness issues - Correct where we had missed points to check txq on i/o completion/cleanup Signed-off-by: -
Wayne Boyer authored
Setting the resource type in the ipr_update_res_entry function was incorrect in that the top 4 bits were masked off. The assignment has been updated to no longer mask those bits. Then, two new attributes were added to allow the user space utilities to more easily get information. The resource_type sdev attribute is set for all devices in the adapter's configuration table and indicates the type of device. The fw_type shost attribute indicates the firmware type supported by the adapter. Finally, the resource_path attribute was changed to be mode S_IRUGO. Signed-off-by:
Wayne Boyer <wayneb@linux.vnet.ibm.com> Acked-by:
Brian King <brking@linux.vnet.ibm.com> Signed-off-by:
-
Wayne Boyer authored
The method of transitioning to operational for new adapters includes using initialization stages. The current stage is indicated via a register read. The final good stage in the sequence is "operational" but does not necessarily indicate that the driver can proceed. There is another bit that gets set in the adapter->host interrupt register when the adapter has completed enough of its bringup such that it can accept commands. The driver was not checking that bit before proceeding which led to intermittent errors and adapter resets. The fix is to check the "transition to operational" bit in the interrupt register after detecting that the initialization stage is "operational" and only proceed if both are set. Signed-off-by:
-
Randy Dunlap authored
be2iscsi driver should #include linux/if_ether.h since it uses sysfs_format_mac(). It should also depend on NET since it selects SCSI_ISCSI_ATTRS, which depends on NET. These changes fix a build error when CONFIG_NET is not enabled: ERROR: "sysfs_format_mac" [drivers/scsi/be2iscsi/be2iscsi.ko] undefined! Signed-off-by:
Randy Dunlap <randy.dunlap@oracle.com> Acked-by:
Jayamohan Kallickal <jayamohank@serverengines.com> Signed-off-by:
-
Jayamohan Kallickal authored
Signed-off-by:
Mike Christie <michaelc@cs.wisc.edu> Signed-off-by:
-
Jayamohan Kallickal authored
This patch fixes a bug where the buffer was being freed as soon as submission to HW is done. Signed-off-by:
-
Jayamohan Kallickal authored
This patch removes a Debug Print in the IO path Signed-off-by:
-
Jayamohan Kallickal authored
This patch limits max_xmit_length to 64K incase older utilities are used Signed-off-by:
-
Jayamohan Kallickal authored
This patch ensures that the same ITT is maintained across all login pdu's Signed-off-by:
-
Jayamohan Kallickal authored
These changes allow the driver to support crashdump. We need to reset the chip incase of a crashdump Signed-off-by:
-
Jayamohan Kallickal authored
This patch frees tags that are already allocated in case of failure Signed-off-by:
-
Jayamohan Kallickal authored
This patch handles request_irq failures by properly cleaning up Signed-off-by:
-
Jayamohan Kallickal authored
hwi_enable_intr need not return any value. This patch fixes the that and removes code designed to handle a failure return value Signed-off-by:
-
Jayamohan Kallickal authored
This patch frees up the allocated cid and returns error if allocation of tag fails. Signed-off-by:
-
Jayamohan Kallickal authored
This patch passes on the value returned by beiscsi_open_conn Signed-off-by:
-
Jayamohan Kallickal authored
Fixing some functions return values that did not match with the possible return values Signed-off-by:
-
Jayamohan Kallickal authored
This patch fixes the return values as per comment from Mike Christie Signed-off-by:
-
Jayamohan Kallickal authored
The latest checkpatch.pl throws some new warnings. Fixing it to get rid of a bunch of warnings Signed-off-by:
-
James Bottomley authored
Commit commit 2c3c8bea Author: Chris Wright <chrisw@sous-sol.org> Date: Wed May 12 18:28:57 2010 -0700 sysfs: add struct file* to bin_attr callbacks Added an extra struct file * parameter at the beginning, which the arcmsr binary attribute additions didn't have. Fix this to prevent nasty crashes. Cc: Nick Cheng <nick.cheng@areca.com.tw> Signed-off-by:
-
Pekka Enberg authored
This patch removes malloc(), free(), and printf() wrappers from the aic7xxx SCSI driver. I didn't use pr_debug for printf because of some 'clever' uses of printf don't compile with the pr_debug. I didn't fix the overeager uses of GFP_ATOMIC either because I wanted to keep this patch as simple as possible. [jejb:fixed up checkpatch errors and fixed up missed conversion] Signed-off-by:
Pekka Enberg <penberg@cs.helsinki.fi> Acked-by:
Hannes Reinecke <hare@suse.de> Signed-off-by:
-
Cyril Jayaprakash authored
Signed-off-by:
Cyril Jayaprakash <cyril.jayaprakash@gmail.com> Acked-by:
Anil Ravindranath <anil_ravindranath@pmc-sierra.com> Signed-off-by:
-
Vikas Chaudhary authored
Signed-off-by:
Vikas Chaudhary <vikas.chaudhary@qlogic.com> Signed-off-by:
Ravi Anand <ravi.anand@qlogic.com> Signed-off-by:
-
Vikas Chaudhary authored
Signed-off-by:
-
Karen Higgins authored
Signed-off-by:
Karen Higgins <karen.higgins@qlogic.com> Signed-off-by:
-
Vikas Chaudhary authored
Signed-off-by:
-
Vikas Chaudhary authored
Signed-off-by: Vikas Chaudhary <Vikas Chaudhary@qlogic.com> Signed-off-by:
-
- 27 Jul, 2010 4 commits
-
-
Ravi Anand authored
Handle one H/W Interrupt at a time to prevent holding off H/W lock for longer period of time. Signed-off-by:
-
Prasanna Mumbai authored
Fixed the DMA allocated memory freeing which wasn't taken care in many cases. Signed-off-by:
Prasanna Mumbai <prasanna.mumbai@qlogic.com> Signed-off-by:
-
Vikas Chaudhary authored
Handle fw_state "auto discovery in progress" correctly to avoid marking adapter as offline. Signed-off-by:
-
Vikas Chaudhary authored
Once the device goes *missing*, driver blocks the session ie iscsi_block_session() to stall the I/O. So after device comes back *online*, driver needs to unblock the session ie iscsi_unblock_session(), else I/Os will fail even if ddb_state is ONLINE. Signed-off-by:
-
