- 02 Jan, 2009 40 commits
-
-
Denis Joseph Barrow authored
Fixed incorrect check for the modem port, this prevents crashes caused by issueing a tiocmget_submit_urb on endpoints which don't exist for non modem devices. Signed-off-by:
Denis Joseph Barrow <D.Barow@option.com> Signed-off-by:
Alan Cox <alan@redhat.com> Signed-off-by:
Linus Torvalds <torvalds@linux-foundation.org>
-
Alan Cox authored
Roel Kluin noted that line is unsigned so one test is unneccessary. Also add a warning for another flaw I noticed while making this change. Signed-off-by:
-
Andrew Morton authored
We forgot to release resources in one case. Addresses http://bugzilla.kernel.org/show_bug.cgi?id=12137Reported-by:
Florian Lohoff <flo@rfc822.org> Signed-off-by:
Andrew Morton <akpm@linux-foundation.org> Signed-off-by:
-
David Daney authored
Cavium UART implementation is not covered by existing uart_configS. Define a new uart_config (PORT_OCTEON) which is specified by OCTEON platform device registration code. Signed-off-by:
Tomaso Paoletti <tpaoletti@caviumnetworks.com> Signed-off-by:
David Daney <ddaney@caviumnetworks.com> Signed-off-by:
-
David Daney authored
Add flag value UPF_FIXED_TYPE which specifies that the UART type is known and should not be probed. For this case the UARTs properties are just copied out of the uart_config entry. This allows us to keep SOC specific 8250 probe code out of 8250.c. In this case we know the serial hardware will not be changing as it is on the same silicon as the CPU, and we can specify it with certainty in the board/cpu setup code. The alternative is to load up 8250.c with a bunch of OCTEON specific special cases in the probing code. Signed-off-by:
-
David Daney authored
In order to use Cavium OCTEON specific serial i/o drivers, we first patch the 8250 driver to use replaceable I/O functions. Compatible I/O functions are added for existing iotypeS. An added benefit of this change is that it makes it easy to factor some of the existing special cases out to board/SOC specific support code. The alternative is to load up 8250.c with a bunch of OCTEON specific iotype code and bug work-arounds. Signed-off-by:
-
David Daney authored
In serial8250_isa_init_ports(), the port's lock is initialized. We should not overwrite it. In early_serial_setup(), only copy in the fields we need. Since the early console code only uses a subset of the fields, these are sufficient. Signed-off-by:
-
Alexander Beregalov authored
Hi Alan next-20081204 crashes with the following message: BUG: unable to handle kernel paging request at ffff88007d320248 IP: [<ffffffff803de934>] uart_remove_one_port+0xef/0x111 kfree(info); 393: 49 8d 7d 10 lea 0x10(%r13),%rdi 397: e8 00 00 00 00 callq 39c <uart_remove_one_port+0xef> Signed-off-by:Alexander Beregalov <a.beregalov@gmail.com> Signed-off-by:
-
Alan Cox authored
Move the tty_port and uart_info bits around a little. By embedding the uart_info into the uart_port we get rid of lots of corner case testing and also get the ability to go port<->state<->info which is a bit more elegant than the current data structures. Downsides - we allocate a tiny bit more memory for unused ports, upside we've removed as much code as it saved for most users.. Signed-off-by:
-
Harvey Harrison authored
Signed-off-by:
Harvey Harrison <harvey.harrison@gmail.com> Signed-off-by:
-
Andy Whitcroft authored
In the commit below a new struct serial_rs485 was introduced for a new ioctl: commit c26c56c0 Author: Alan Cox <alan@redhat.com> Date: Mon Oct 13 10:37:48 2008 +0100 tty: Cris has a nice RS485 ioctl so we should steal it This structure uses the __u32 types for some of its members, which leads to the following compile error: $ cc -I.../include -c X.c In file included from X.c:2: .../include/linux/serial.h:185: error: expected specifier-qualifier-list before ‘__u32’ $ It seems that these types are appropriate for this structure as it is to be exposed to userspace. These types are available via linux/types.h so move the include of that outside the __KERNEL__ section. Signed-off-by:Andy Whitcroft <apw@canonical.com> Signed-off-by:
-
Alan Cox authored
We don't need the BKL here any more so it can go. In a couple of spots the driver requirements are not clear so push the lock down into the driver. Signed-off-by:
-
Alan Cox authored
Use the tty port operations, add refcounting, and refactor a bit to make the refcounting work cleanly. Signed-off-by:
-
Alan Cox authored
Now we have our ducks in order we can begin switching to the port operations Signed-off-by:
-
Alan Cox authored
We will need this kref fitted to make full use of the port operations. Signed-off-by:
-
Alan Cox authored
We need to this ready for using the standard helpers Signed-off-by:
-
Alan Cox authored
Bring this driver into the port locking model Signed-off-by:
-
Alan Cox authored
Now the locking is straight and the port kref usage is straight we can replace lots of chunks of code with the standard port helpers Signed-off-by:
-
Alan Cox authored
Signed-off-by:
-
Alan Cox authored
Bring epca into line with the port locking. Signed-off-by:
-
Denis Joseph Barrow authored
Makes TIOCM ioctls for Data Carrier Detect & related functions work like /drivers/serial/serial-core.c potentially needed for pppd & similar user programs. Signed-off-by:
-
Alan Cox authored
Init the tty structure once Don't set ->low_latency twice in a row Don't force bits we should be leaving to the user Don't allocate termios arrays as these are in fact allocated by the tty layer for you and just overwrite the ones allocated in the driver Signed-off-by:
-
Alan Cox authored
Checking tty == NULL doesn't help us unless we have a clear semantic for the locking of the tty object in the driver. Use the tty kref objects so that we can take references to the tty in the USB event handling paths. Signed-off-by:
-
Alan Cox authored
Update the nozomi driver to use krefs Signed-off-by: -
Alan Cox authored
disc_data and driver_data are void * Signed-off-by:
-
Alan Cox authored
The write wakeup is done anyway for the poll while DO_WRITE_WAKUP is cleared, set and managed by the ldisc layer and is no business of the pty code. Signed-off-by:
-
Thomas Pfaff authored
The N_TTY ldisc layer does not send SIGIO POLL_OUTs correctly when output is possible due to flawed handling of the TTY_DO_WRITE_WAKEUP bit. It will either send no SIGIOs at all or on every tty wakeup. The fix is to set the bit when the tty driver write would block and test and clear it on write wakeup. [Merged with existing N_TTY patches and a small buglet fixed -- Alan] Signed-off-by:
Thomas Pfaff <tpfaff@pcs.com> Signed-off-by:
-
Alan Cox authored
The underlying problem is that the device methods don't all correctly handle disconnected status and some keep reporting bytes pending which causes tcdrain to stall. When the cable is unplugged they are definitely gone, and as this is true for all USB cables we can fix it in the core usb serial code. Signed-off-by:
-
Niels de Vos authored
The PCI-card identified as "Oxford Semiconductor Ltd EXSYS EX-41092 Dual 16950 Serial adapter" is only usable with other devices (i.e. not the same card) after doing a "setserial /dev/ttyS<n> baud_base 115200". This baud_base should be default for this card. Signed-off-by:
Niels de Vos <niels.devos@wincor-nixdorf.com> Signed-off-by:
-
Alan Cox authored
Again this is a lot of common code we can unify Signed-off-by:
-
Alan Cox authored
If we have no speed set at some point then we should not raise DTR/RTS at that point when opening as the tty is not ready Signed-off-by:
-
Alan Cox authored
Mark it broken Signed-off-by:
-
Alan Cox authored
Signed-off-by:
-
Alan Cox authored
Signed-off-by:
-
Alan Cox authored
Start sucking more commonality out of the drivers into a single piece of core code. Signed-off-by:
-
Alan Cox authored
Signed-off-by:
-
Alan Cox authored
Signed-off-by:
-
Alan Cox authored
Normalise them so we can use the common helpers later on Signed-off-by:
-
Alan Cox authored
Switch generic_serial to do port count locking via the tty_port structure ready for moving to a common port wait routine. Keep the old driver lock for internal calling so we don't risk messing up the drivers below until we are ready. Still needs kref conversions Signed-off-by:
-
Alan Cox authored
This helps set the basis for moving block_til_ready into common code. We also introduce a tty_port_hangup helper as this will also be generally needed. Signed-off-by:
-
