1. 15 Jul, 2009 1 commit
    • Andreas Mohr's avatar
      ALSA: azt3328: fix previous breakage, improve suspend, cleanups · 78df617a
      Andreas Mohr authored
      - fix my previous codec activity breakage (_non-warned_ variable assignment
        issue)
      - convert suspend/resume to 32bit I/O access (I/O is painful; to improve
        suspend/resume performance)
      - change DEBUG_PLAY_REC to DEBUG_CODEC for consistency
      - printk cleanup
      - some logging improvements
      - minor cleanup/improvements
      
      The variable assignment issue above was a conditional assignment to the
      call_function variable (this ended with the non-preinitialized variable
      not getting assigned in some cases, thus a dangling stack value, yet gcc 4.3.3
      unbelievably did _NOT_ warn about it in this case!!),
      needed to change this into _always_ assigning the check result.
      Practical result of this bug was that when shutting down
      _either_ playback or capture, _both_ streams dropped dead :P
      
      Tested, working (plus resume) and checkpatch.pl:ed on 2.6.30-rc5,
      applies cleanly to 2.6.30 proper with my previous (committed)
      patches applied.
      Signed-off-by: default avatarAndreas Mohr <andi@lisas.de>
      Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
      78df617a
  2. 06 Jul, 2009 2 commits
    • Andreas Mohr's avatar
      ALSA: azt3328: large codec cleanup, add I2S port etc. · dfbf9511
      Andreas Mohr authored
      - fully separate codec I/O port handling, enabling the use of a single
        function each for all codecs (playback, capture, I2S out)
      - add a new separate pcm for I2S out port (UNTESTED, no I2S DAC
        available yet)
      - switch gameport to low frequency while idle, to try to reduce noise/power
      - improve snd_azf3328_codec_setdmaa() calculation
      - minor variable type cleanup (u16, bool etc.)
      - add some doc updates (help those lost Windows users, debug help, ...)
      
      Note that due to the large cleanup aspect of the codec I/O change,
      I was able to fit everything including all improvements into the
      same binary size!! (a measly 10 bytes more or so)
      
      This should now be the almost last patch to this driver
      (minus some possible kernel clocksource patch and x86_64 fixes or so).
      I just felt like taking a break from the usual stuff and wanted to
      get this driver's structure finished, and it's rather clean now...
      
      Tested, working and checkpatch.pl:ed on 2.6.30-rc5,
      applies cleanly to 2.6.30 proper.
      Signed-off-by: default avatarAndreas Mohr <andi@lisas.de>
      Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
      dfbf9511
    • Andreas Mohr's avatar
      ALSA: azt3328: fix Kconfig entry · 3eff8958
      Andreas Mohr authored
      This driver is about as far from being experimental as it can ever get
      for an undocumented card, thus create this patch (interestingly it was the only
      EXPERIMENTAL remaining in the entire Kconfig file).
      Signed-off-by: default avatarAndreas Mohr <andi@lisas.de>
      Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
      3eff8958
  3. 04 Jul, 2009 9 commits
  4. 03 Jul, 2009 28 commits