1. 27 Oct, 2022 6 commits
    • Linus Torvalds's avatar
      Merge tag 'execve-v6.1-rc3' of git://git.kernel.org/pub/scm/linux/kernel/git/kees/linux · 7dd257d0
      Linus Torvalds authored
      Pull execve fixes from Kees Cook:
      
       - Fix an ancient signal action copy race (Bernd Edlinger)
      
       - Fix a memory leak in ELF loader, when under memory pressure (Li
         Zetao)
      
      * tag 'execve-v6.1-rc3' of git://git.kernel.org/pub/scm/linux/kernel/git/kees/linux:
        fs/binfmt_elf: Fix memory leak in load_elf_binary()
        exec: Copy oldsighand->action under spin-lock
      7dd257d0
    • Linus Torvalds's avatar
      Merge tag 'hardening-v6.1-rc3' of git://git.kernel.org/pub/scm/linux/kernel/git/kees/linux · 2eb72d85
      Linus Torvalds authored
      Pull hardening fixes from Kees Cook:
      
       - Fix older Clang vs recent overflow KUnit test additions (Nick
         Desaulniers, Kees Cook)
      
       - Fix kern-doc visibility for overflow helpers (Kees Cook)
      
      * tag 'hardening-v6.1-rc3' of git://git.kernel.org/pub/scm/linux/kernel/git/kees/linux:
        overflow: Refactor test skips for Clang-specific issues
        overflow: disable failing tests for older clang versions
        overflow: Fix kern-doc markup for functions
      2eb72d85
    • Linus Torvalds's avatar
      Merge tag 'media/v6.1-3' of git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-media · 7f9a7cd6
      Linus Torvalds authored
      Pull media fixes from Mauro Carvalho Chehab:
       "A bunch of patches addressing issues in the vivid driver and adding
        new checks in V4L2 to validate the input parameters from some ioctls"
      
      * tag 'media/v6.1-3' of git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-media:
        media: vivid.rst: loop_video is set on the capture devnode
        media: vivid: set num_in/outputs to 0 if not supported
        media: vivid: drop GFP_DMA32
        media: vivid: fix control handler mutex deadlock
        media: videodev2.h: V4L2_DV_BT_BLANKING_HEIGHT should check 'interlaced'
        media: v4l2-dv-timings: add sanity checks for blanking values
        media: vivid: dev->bitmap_cap wasn't freed in all cases
        media: vivid: s_fbuf: add more sanity checks
      7f9a7cd6
    • Linus Torvalds's avatar
      Merge tag 'fscrypt-for-linus' of git://git.kernel.org/pub/scm/fs/fscrypt/fscrypt · 200204f5
      Linus Torvalds authored
      Pull fscrypt fix from Eric Biggers:
       "Fix a memory leak that was introduced by a change that went into -rc1"
      
      * tag 'fscrypt-for-linus' of git://git.kernel.org/pub/scm/fs/fscrypt/fscrypt:
        fscrypt: fix keyring memory leak on mount failure
      200204f5
    • Linus Torvalds's avatar
      Merge tag 'perf-tools-fixes-for-v6.1-2022-10-26' of... · b229b6ca
      Linus Torvalds authored
      Merge tag 'perf-tools-fixes-for-v6.1-2022-10-26' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux
      
      Pull perf tool fixes from Arnaldo Carvalho de Melo:
      
       - Fix some aspects of building with an older (than the one in the
         kernel sources) libbpf present in a distro, when building with
         LIBBPF_DYNAMIC=1.
      
       - Fix errno setting races with event_fd and the signal handler in 'perf
         record'.
      
       - Fix Power10 hv-24x7 metric events when some events may have a zero
         count based on system configuration.
      
       - Do not fail Intel-PT misc test w/o libpython, just skip it.
      
       - Fix incorrect arm64 Hisi hip08 L3 metrics (IF_BP_MISP_BR_RET,
         IF_BP_MISP_BR_RET, IF_BP_MISP_BR_BL) due to mistakes in the
         documentation used to generate the JSON files for these metrics.
      
       - Fix auxtrace (Intel PT, ARM Coresight) address filter symbol name
         match for modules, we need to skip the module name.
      
       - Sync copies of files with the kernel sources, including ppc syscall
         tables and assorted headers, some resulting in tools being able to
         decode new network protocols (IPPROTO_L2TP) and statx masks
         (STATX_DIOALIGN).
      
       - Fix PMU name pai_crypto in the vendor events file (JSON) for s390.
      
       - Fix man page build wrt perf-arm-coresight.txt as the build process
         assumes files starting with 'perf-' are man pages, and this file
         isn't one.
      
      * tag 'perf-tools-fixes-for-v6.1-2022-10-26' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux:
        perf vendor events arm64: Fix incorrect Hisi hip08 L3 metrics
        perf auxtrace: Fix address filter symbol name match for modules
        tools headers UAPI: Sync linux/perf_event.h with the kernel sources
        tools headers cpufeatures: Sync with the kernel sources
        tools headers uapi: Sync linux/stat.h with the kernel sources
        tools include UAPI: Sync sound/asound.h copy with the kernel sources
        tools headers uapi: Update linux/in.h copy
        tools headers: Update the copy of x86's memcpy_64.S used in 'perf bench'
        tools headers arm64: Sync arm64's cputype.h with the kernel sources
        perf test: Do not fail Intel-PT misc test w/o libpython
        perf list: Fix PMU name pai_crypto in perf list on s390
        perf record: Fix event fd races
        perf bpf: Fix build with libbpf 0.7.0 by checking if bpf_program__set_insns() is available
        perf bpf: Fix build with libbpf 0.7.0 by adding prototype for bpf_load_program()
        perf vendor events power10: Fix hv-24x7 metric events
        perf docs: Fix man page build wrt perf-arm-coresight.txt
        tools headers UAPI: Sync powerpc syscall tables with the kernel sources
      b229b6ca
    • Linus Torvalds's avatar
      Merge tag 'spi-fix-v6.1-rc2' of git://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi · a2718383
      Linus Torvalds authored
      Pull spi fixes from Mark Brown:
       "A collection of mostly unremarkable fixes for SPI that have built up
        since the merge window, all driver specific.
      
        The change to the qup adding support for GPIO chip selects is fixing a
        regression due to the removal of legacy GPIO handling, the driver had
        previously been silently relying on the legacy GPIO support in a
        slightly broken way which worked well enough on some systems. Fixing
        it is simply a case of setting a couple of bits of information in the
        driver description"
      
      * tag 'spi-fix-v6.1-rc2' of git://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi:
        spi: aspeed: Fix window offset of CE1
        spi: qup: support using GPIO as chip select line
        spi: intel: Fix the offset to get the 64K erase opcode
        spi: aspeed: Fix typo in mode_bits field for AST2600 platform
        spi: mpc52xx: Replace NO_IRQ by 0
        spi: spi-mem: Fix typo (of -> or)
        spi: spi-gxp: fix typo in SPDX identifier line
        spi: tegra210-quad: Fix combined sequence
      a2718383
  2. 26 Oct, 2022 4 commits
  3. 25 Oct, 2022 30 commits
    • Li Zetao's avatar
      fs/binfmt_elf: Fix memory leak in load_elf_binary() · 594d2a14
      Li Zetao authored
      There is a memory leak reported by kmemleak:
      
        unreferenced object 0xffff88817104ef80 (size 224):
          comm "xfs_admin", pid 47165, jiffies 4298708825 (age 1333.476s)
          hex dump (first 32 bytes):
            00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
            60 a8 b3 00 81 88 ff ff a8 10 5a 00 81 88 ff ff  `.........Z.....
          backtrace:
            [<ffffffff819171e1>] __alloc_file+0x21/0x250
            [<ffffffff81918061>] alloc_empty_file+0x41/0xf0
            [<ffffffff81948cda>] path_openat+0xea/0x3d30
            [<ffffffff8194ec89>] do_filp_open+0x1b9/0x290
            [<ffffffff8192660e>] do_open_execat+0xce/0x5b0
            [<ffffffff81926b17>] open_exec+0x27/0x50
            [<ffffffff81a69250>] load_elf_binary+0x510/0x3ed0
            [<ffffffff81927759>] bprm_execve+0x599/0x1240
            [<ffffffff8192a997>] do_execveat_common.isra.0+0x4c7/0x680
            [<ffffffff8192b078>] __x64_sys_execve+0x88/0xb0
            [<ffffffff83bbf0a5>] do_syscall_64+0x35/0x80
      
      If "interp_elf_ex" fails to allocate memory in load_elf_binary(),
      the program will take the "out_free_ph" error handing path,
      resulting in "interpreter" file resource is not released.
      
      Fix it by adding an error handing path "out_free_file", which will
      release the file resource when "interp_elf_ex" failed to allocate
      memory.
      
      Fixes: 0693ffeb ("fs/binfmt_elf.c: allocate less for static executable")
      Signed-off-by: default avatarLi Zetao <lizetao1@huawei.com>
      Reviewed-by: default avatarAlexey Dobriyan <adobriyan@gmail.com>
      Signed-off-by: default avatarKees Cook <keescook@chromium.org>
      Cc: stable@vger.kernel.org
      Link: https://lore.kernel.org/r/20221024154421.982230-1-lizetao1@huawei.com
      594d2a14
    • Bernd Edlinger's avatar
      exec: Copy oldsighand->action under spin-lock · 5bf2fedc
      Bernd Edlinger authored
      unshare_sighand should only access oldsighand->action
      while holding oldsighand->siglock, to make sure that
      newsighand->action is in a consistent state.
      Signed-off-by: default avatarBernd Edlinger <bernd.edlinger@hotmail.de>
      Cc: stable@vger.kernel.org
      Fixes: 1da177e4 ("Linux-2.6.12-rc2")
      Signed-off-by: default avatarKees Cook <keescook@chromium.org>
      Link: https://lore.kernel.org/r/AM8PR10MB470871DEBD1DED081F9CC391E4389@AM8PR10MB4708.EURPRD10.PROD.OUTLOOK.COM
      5bf2fedc
    • Kees Cook's avatar
      overflow: Refactor test skips for Clang-specific issues · 72c3ebea
      Kees Cook authored
      Convert test exclusion into test skipping. This brings the logic for
      why a test is being skipped into the test itself, instead of having to
      spread ifdefs around the code. This will make cleanup easier as minimum
      tests get raised. Drop __maybe_unused so missed tests will be noticed
      again and clean up whitespace.
      
      For example, clang-11 on i386:
      
      [15:52:32] ================== overflow (18 subtests) ==================
      [15:52:32] [PASSED] u8_u8__u8_overflow_test
      [15:52:32] [PASSED] s8_s8__s8_overflow_test
      [15:52:32] [PASSED] u16_u16__u16_overflow_test
      [15:52:32] [PASSED] s16_s16__s16_overflow_test
      [15:52:32] [PASSED] u32_u32__u32_overflow_test
      [15:52:32] [PASSED] s32_s32__s32_overflow_test
      [15:52:32] [SKIPPED] u64_u64__u64_overflow_test
      [15:52:32] [SKIPPED] s64_s64__s64_overflow_test
      [15:52:32] [SKIPPED] u32_u32__int_overflow_test
      [15:52:32] [PASSED] u32_u32__u8_overflow_test
      [15:52:32] [PASSED] u8_u8__int_overflow_test
      [15:52:32] [PASSED] int_int__u8_overflow_test
      [15:52:32] [PASSED] shift_sane_test
      [15:52:32] [PASSED] shift_overflow_test
      [15:52:32] [PASSED] shift_truncate_test
      [15:52:32] [PASSED] shift_nonsense_test
      [15:52:32] [PASSED] overflow_allocation_test
      [15:52:32] [PASSED] overflow_size_helpers_test
      [15:52:32] ==================== [PASSED] overflow =====================
      [15:52:32] ============================================================
      [15:52:32] Testing complete. Ran 18 tests: passed: 15, skipped: 3
      
      Cc: Nick Desaulniers <ndesaulniers@google.com>
      Cc: Nathan Chancellor <nathan@kernel.org>
      Cc: Tom Rix <trix@redhat.com>
      Cc: Daniel Latypov <dlatypov@google.com>
      Cc: "Gustavo A. R. Silva" <gustavoars@kernel.org>
      Cc: Gwan-gyeong Mun <gwan-gyeong.mun@intel.com>
      Cc: llvm@lists.linux.dev
      Signed-off-by: default avatarKees Cook <keescook@chromium.org>
      Reviewed-by: default avatarNick Desaulniers <ndesaulniers@google.com>
      Tested-by: default avatarNick Desaulniers <ndesaulniers@google.com>
      Link: https://lore.kernel.org/r/20221006230017.1833458-1-keescook@chromium.org
      72c3ebea
    • Nick Desaulniers's avatar
      overflow: disable failing tests for older clang versions · 0e5b9f25
      Nick Desaulniers authored
      Building the overflow kunit tests with clang-11 fails with:
      
      $ ./tools/testing/kunit/kunit.py run --arch=arm --make_options LLVM=1 \
      overflow
      ...
      ld.lld: error: undefined symbol: __mulodi4
      ...
      
      Clang 11 and earlier generate unwanted libcalls for signed output,
      unsigned input.
      
      Disable these tests for now, but should these become used in the kernel
      we might consider that as justification for dropping clang-11 support.
      Keep the clang-11 build alive a little bit longer.
      
      Avoid -Wunused-function warnings via __maybe_unused. To test W=1:
      
      $ make LLVM=1 -j128 defconfig
      $ ./scripts/config -e KUNIT -e KUNIT_ALL
      $ make LLVM=1 -j128 olddefconfig lib/overflow_kunit.o W=1
      
      Link: https://github.com/ClangBuiltLinux/linux/issues/1711
      Link: https://github.com/llvm/llvm-project/commit/3203143f1356a4e4e3ada231156fc6da6e1a9f9dReported-by: default avatarNathan Chancellor <nathan@kernel.org>
      Signed-off-by: default avatarNick Desaulniers <ndesaulniers@google.com>
      Signed-off-by: default avatarKees Cook <keescook@chromium.org>
      Link: https://lore.kernel.org/r/20221006171751.3444575-1-ndesaulniers@google.com
      0e5b9f25
    • Kees Cook's avatar
      overflow: Fix kern-doc markup for functions · 31970608
      Kees Cook authored
      Fix the kern-doc markings for several of the overflow helpers and move
      their location into the core kernel API documentation, where it belongs
      (it's not driver-specific).
      
      Cc: Jonathan Corbet <corbet@lwn.net>
      Cc: linux-doc@vger.kernel.org
      Cc: linux-hardening@vger.kernel.org
      Reviewed-by: default avatarAkira Yokosawa <akiyks@gmail.com>
      Signed-off-by: default avatarKees Cook <keescook@chromium.org>
      31970608
    • Arnaldo Carvalho de Melo's avatar
      tools headers cpufeatures: Sync with the kernel sources · 74455fd7
      Arnaldo Carvalho de Melo authored
      To pick the changes from:
      
        257449c6 ("x86/cpufeatures: Add LbrExtV2 feature bit")
      
      This only causes these perf files to be rebuilt:
      
        CC       /tmp/build/perf/bench/mem-memcpy-x86-64-asm.o
        CC       /tmp/build/perf/bench/mem-memset-x86-64-asm.o
      
      And addresses this perf build warning:
      
        Warning: Kernel ABI header at 'tools/arch/x86/include/asm/cpufeatures.h' differs from latest version at 'arch/x86/include/asm/cpufeatures.h'
        diff -u tools/arch/x86/include/asm/cpufeatures.h arch/x86/include/asm/cpufeatures.h
      
      Cc: Adrian Hunter <adrian.hunter@intel.com>
      Cc: Ian Rogers <irogers@google.com>
      Cc: Jiri Olsa <jolsa@kernel.org>
      Cc: Namhyung Kim <namhyung@kernel.org>
      Cc: Peter Zijlstra <peterz@infradead.org>
      Cc: Sandipan Das <sandipan.das@amd.com>
      Link: https://lore.kernel.org/lkml/Y1g6vGPqPhOrXoaN@kernel.orgSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      74455fd7
    • Arnaldo Carvalho de Melo's avatar
      tools headers uapi: Sync linux/stat.h with the kernel sources · 49c75d30
      Arnaldo Carvalho de Melo authored
      To pick the changes from:
      
        825cf206 ("statx: add direct I/O alignment information")
      
      That add a constant that was manually added to tools/perf/trace/beauty/statx.c,
      at some point this should move to the shell based automated way.
      
      This silences this perf build warning:
      
        Warning: Kernel ABI header at 'tools/include/uapi/linux/stat.h' differs from latest version at 'include/uapi/linux/stat.h'
        diff -u tools/include/uapi/linux/stat.h include/uapi/linux/stat.h
      
      Cc: Eric Biggers <ebiggers@google.com>
      Cc: Adrian Hunter <adrian.hunter@intel.com>
      Cc: Ian Rogers <irogers@google.com>
      Cc: Jiri Olsa <jolsa@kernel.org>
      Cc: Namhyung Kim <namhyung@kernel.org>
      Link: https://lore.kernel.org/lkml/Y1gGQL5LonnuzeYd@kernel.orgSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      49c75d30
    • Arnaldo Carvalho de Melo's avatar
      tools include UAPI: Sync sound/asound.h copy with the kernel sources · 82c50d89
      Arnaldo Carvalho de Melo authored
      Picking the changes from:
      
        69ab6f5b ("ALSA: Remove some left-over license text in include/uapi/sound/")
      
      Which entails no changes in the tooling side as it doesn't introduce new
      SNDRV_PCM_IOCTL_ ioctls.
      
      To silence this perf tools build warning:
      
        Warning: Kernel ABI header at 'tools/include/uapi/sound/asound.h' differs from latest version at 'include/uapi/sound/asound.h'
        diff -u tools/include/uapi/sound/asound.h include/uapi/sound/asound.h
      Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      82c50d89
    • Arnaldo Carvalho de Melo's avatar
      tools headers uapi: Update linux/in.h copy · 036b8f5b
      Arnaldo Carvalho de Melo authored
      To get the changes in:
      
        65b32f80 ("uapi: move IPPROTO_L2TP to in.h")
        5854a09b ("net/ipv4: Use __DECLARE_FLEX_ARRAY() helper")
      
      That ends up automatically adding the new IPPROTO_L2TP to the socket
      args beautifiers:
      
        $ tools/perf/trace/beauty/socket.sh > before
        $ cp include/uapi/linux/in.h tools/include/uapi/linux/in.h
        $ tools/perf/trace/beauty/socket.sh > after
        $ diff -u before after
        --- before	2022-10-25 12:17:02.577892416 -0300
        +++ after	2022-10-25 12:17:10.806113033 -0300
        @@ -20,6 +20,7 @@
         	[98] = "ENCAP",
         	[103] = "PIM",
         	[108] = "COMP",
        +	[115] = "L2TP",
         	[132] = "SCTP",
         	[136] = "UDPLITE",
         	[137] = "MPLS",
        $
      
      Now 'perf trace' will decode that 115 into "L2TP" and it will also be
      possible to use it in tracepoint filter expressions.
      
      Addresses this tools/perf build warning:
      
        Warning: Kernel ABI header at 'tools/include/uapi/linux/in.h' differs from latest version at 'include/uapi/linux/in.h'
        diff -u tools/include/uapi/linux/in.h include/uapi/linux/in.h
      
      Cc: Adrian Hunter <adrian.hunter@intel.com>
      Cc: Ian Rogers <irogers@google.com>
      Cc: Jiri Olsa <jolsa@kernel.org>
      Cc: Namhyung Kim <namhyung@kernel.org>
      Cc: Paolo Abeni <pabeni@redhat.com>
      Cc: Wojciech Drewek <wojciech.drewek@intel.com>
      Cc: David S. Miller <davem@davemloft.net>
      Cc: Gustavo A. R. Silva <gustavoars@kernel.org>
      Link: https://lore.kernel.org/lkml/Y1f%2FGe6vjQrGjYiK@kernel.org/Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      036b8f5b
    • Arnaldo Carvalho de Melo's avatar
      tools headers: Update the copy of x86's memcpy_64.S used in 'perf bench' · 4402e360
      Arnaldo Carvalho de Melo authored
      We also need to add SYM_TYPED_FUNC_START() to util/include/linux/linkage.h
      and update tools/perf/check_headers.sh to ignore the include cfi_types.h
      line when checking if the kernel original files drifted from the copies
      we carry.
      
      This is to get the changes from:
      
        ccace936 ("x86: Add types to indirectly called assembly functions")
      
      Addressing these tools/perf build warnings:
      
        Warning: Kernel ABI header at 'tools/arch/x86/lib/memcpy_64.S' differs from latest version at 'arch/x86/lib/memcpy_64.S'
        diff -u tools/arch/x86/lib/memcpy_64.S arch/x86/lib/memcpy_64.S
      
      Cc: Adrian Hunter <adrian.hunter@intel.com>
      Cc: Ian Rogers <irogers@google.com>
      Cc: Jiri Olsa <jolsa@kernel.org>
      Cc: Namhyung Kim <namhyung@kernel.org>
      Cc: Kees Cook <keescook@chromium.org>
      Cc: Sami Tolvanen <samitolvanen@google.com>
      Link: https://lore.kernel.org/lkml/Y1f3VRIec9EBgX6F@kernel.org/Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      4402e360
    • Arnaldo Carvalho de Melo's avatar
      tools headers arm64: Sync arm64's cputype.h with the kernel sources · ffc1df3d
      Arnaldo Carvalho de Melo authored
      To get the changes in:
      
        0e5d5ae8 ("arm64: Add AMPERE1 to the Spectre-BHB affected list")
      
      That addresses this perf build warning:
      
        Warning: Kernel ABI header at 'tools/arch/arm64/include/asm/cputype.h' differs from latest version at 'arch/arm64/include/asm/cputype.h'
        diff -u tools/arch/arm64/include/asm/cputype.h arch/arm64/include/asm/cputype.h
      
      Cc: Catalin Marinas <catalin.marinas@arm.com>
      Cc: D Scott Phillips <scott@os.amperecomputing.com>
      https://lore.kernel.org/lkml/Y1fy5GD7ZYvkeufv@kernel.orgSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      ffc1df3d
    • Namhyung Kim's avatar
      perf test: Do not fail Intel-PT misc test w/o libpython · 246122a8
      Namhyung Kim authored
      The virtual LBR test uses a python script to check the max size of
      branch stack in the Intel-PT generated LBR.  But it didn't check whether
      python scripting is available (as it's optional).
      
      Let's skip the test if the python support is not available.
      
      Fixes: f77811a0 ("perf test: test_intel_pt.sh: Add 9 tests")
      Reviewed-by: default avatarAdrian Hunter <adrian.hunter@intel.com>
      Signed-off-by: default avatarNamhyung Kim <namhyung@kernel.org>
      Acked-by: default avatarIan Rogers <irogers@google.com>
      Cc: Ammy Yi <ammy.yi@intel.com>
      Cc: Ingo Molnar <mingo@kernel.org>
      Cc: Jiri Olsa <jolsa@kernel.org>
      Cc: Peter Zijlstra <peterz@infradead.org>
      Link: https://lore.kernel.org/r/20221021181055.60183-1-namhyung@kernel.orgSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      246122a8
    • Thomas Richter's avatar
      perf list: Fix PMU name pai_crypto in perf list on s390 · 5a6c184a
      Thomas Richter authored
      Commit e0b23af8 ("perf list: Add PMU pai_crypto event
      description for IBM z16") introduced the "Processor Activity
      Instrumentation" for cryptographic counters for z16. The PMU device
      driver exports the counters via sysfs files listed in directory
      /sys/devices/pai_crypto.
      
      To specify an event from that PMU, use 'perf stat -e pai_crypto/XXX/'.
      
      However the JSON file mentioned in above commit exports the counter
      decriptions in file pmu-events/arch/s390/cf_z16/pai.json.  Rename this
      file to pmu-events/arch/s390/cf_z16/pai_crypto.json to make the naming
      consistent.
      
      Now 'perf list' shows the counter names under pai_crypto section:
      
        pai_crypto:
      
          CRYPTO_ALL
               [CRYPTO ALL. Unit: pai_crypto]
          ...
      
      Output before was
      
        pai:
          CRYPTO_ALL
               [CRYPTO ALL. Unit: pai_crypto]
          ...
      
      Fixes: e0b23af8 ("perf list: Add PMU pai_crypto event description for IBM z16")
      Signed-off-by: default avatarThomas Richter <tmricht@linux.ibm.com>
      Acked-by: default avatarSumanth Korikkar <sumanthk@linux.ibm.com>
      Cc: Heiko Carstens <hca@linux.ibm.com>
      Cc: Sven Schnelle <svens@linux.ibm.com>
      Cc: Thomas Richter <tmricht@linux.ibm.com>
      Cc: Vasily Gorbik <gor@linux.ibm.com>
      Link: https://lore.kernel.org/r/20221021082557.2695382-1-tmricht@linux.ibm.comSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      5a6c184a
    • Ian Rogers's avatar
      perf record: Fix event fd races · 304f0a2f
      Ian Rogers authored
      The write call may set errno which is problematic if occurring in a
      function also setting errno. Save and restore errno around the write
      call.
      
      done_fd may be used after close, clear it as part of the close and check
      its validity in the signal handler.
      
      Suggested-by: <gthelen@google.com>
      Reviewed-by: default avatarLeo Yan <leo.yan@linaro.org>
      Signed-off-by: default avatarIan Rogers <irogers@google.com>
      Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
      Cc: Anand K Mistry <amistry@google.com>
      Cc: Ingo Molnar <mingo@redhat.com>
      Cc: Jiri Olsa <jolsa@kernel.org>
      Cc: Mark Rutland <mark.rutland@arm.com>
      Cc: Namhyung Kim <namhyung@kernel.org>
      Cc: Peter Zijlstra <peterz@infradead.org>
      Cc: Stephane Eranian <eranian@google.com>
      Link: https://lore.kernel.org/r/20221024011024.462518-1-irogers@google.comSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      304f0a2f
    • Arnaldo Carvalho de Melo's avatar
      perf bpf: Fix build with libbpf 0.7.0 by checking if bpf_program__set_insns() is available · f1bdebbb
      Arnaldo Carvalho de Melo authored
      During the transition to libbpf 1.0 some functions that perf used were
      deprecated and finally removed from libbpf, so bpf_program__set_insns()
      was introduced for perf to continue to use its bpf loader.
      
      But when build with LIBBPF_DYNAMIC=1 we now need to check if that
      function is available so that perf can build with older libbpf versions,
      even if the end result is emitting a warning to the user that the use
      of the perf BPF loader requires a newer libbpf, since bpf_program__set_insns()
      touches libbpf objects internal state.
      
      This affects only 'perf trace' when using bpf C code or pre-compiled
      bytecode as an event.
      
      Noticed on RHEL9, that has libbpf 0.7.0, where bpf_program__set_insns()
      isn't available.
      Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      f1bdebbb
    • Arnaldo Carvalho de Melo's avatar
      perf bpf: Fix build with libbpf 0.7.0 by adding prototype for bpf_load_program() · 409fb6bd
      Arnaldo Carvalho de Melo authored
      The bpf_load_program() prototype appeared in tools/lib/bpf/bpf.h as
      deprecated, but nowadays its completely removed, so add it back for
      building with the system libbpf when using 'make LIBBPF_DYNAMIC=1'.
      
      This is a stop gap hack till we do like tools/bpf does with bpftool,
      i.e. bootstrap the libbpf build and install it in the perf build
      directory when not using 'make LIBBPF_DYNAMIC=1'.
      
      That has to be done to all libraries in tools/lib/, so tha we can
      remove -Itools/lib/ from the tools/perf CFLAGS.
      
      Noticed when building with LIBBPF_DYNAMIC=1 and libbpf 0.7.0 on RHEL9.
      Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      409fb6bd
    • Kajol Jain's avatar
      perf vendor events power10: Fix hv-24x7 metric events · b92dd117
      Kajol Jain authored
      Testcase stat_all_metrics.sh fails in powerpc:
      
        90: perf all metrics test : FAILED!
      
      The testcase "stat_all_metrics.sh" verifies perf stat result for all the
      metric events present in perf list.  It runs perf metric events with
      various commands and expects non-empty metric result.
      
      Incase of powerpc:hv-24x7 events, some of the event count can be 0 based
      on system configuration. And if that event used as denominator in divide
      equation, it can cause divide by 0 error. The current nest_metric.json
      file creating divide by 0 issue for some of the metric events, which
      results in failure of the "stat_all_metrics.sh" test case.
      
      Most of the metrics events have cycles or an event which expect to have
      a larger value as denominator, so adding 1 to the denominator of the
      metric expression as a fix.
      
      Result in powerpc box after this patch changes:
      
        90: perf all metrics test : Ok
      
      Fixes: a3cbcadf ("perf vendor events power10: Adds 24x7 nest metric events for power10 platform")
      Signed-off-by: default avatarKajol Jain <kjain@linux.ibm.com>
      Reviewed-by: default avatarMadhavan Srinivasan <maddy@linux.vnet.ibm.com>
      Cc: Athira Jajeev <atrajeev@linux.vnet.ibm.com>
      Cc: Disha Goel <disgoel@linux.vnet.ibm.com>
      Cc: Jiri Olsa <jolsa@kernel.org>
      Cc: Kajol Jain <kjain@linux.ibm.com>
      Cc: linuxppc-dev@lists.ozlabs.org
      Cc: Michael Ellerman <mpe@ellerman.id.au>
      Cc: Nageswara R Sastry <rnsastry@linux.ibm.com>
      Link: https://lore.kernel.org/r/20221014140220.122251-1-kjain@linux.ibm.comSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      b92dd117
    • Adrian Hunter's avatar
      perf docs: Fix man page build wrt perf-arm-coresight.txt · 231e61bc
      Adrian Hunter authored
      perf build assumes documentation files starting with "perf-" are man
      pages but perf-arm-coresight.txt is not a man page:
      
        asciidoc: ERROR: perf-arm-coresight.txt: line 2: malformed manpage title
        asciidoc: ERROR: perf-arm-coresight.txt: line 3: name section expected
        asciidoc: FAILED: perf-arm-coresight.txt: line 3: section title expected
        make[3]: *** [Makefile:266: perf-arm-coresight.xml] Error 1
        make[3]: *** Waiting for unfinished jobs....
        make[2]: *** [Makefile.perf:895: man] Error 2
      
      Fix by renaming it.
      
      Fixes: dc2e0fb0 ("perf test coresight: Add relevant documentation about ARM64 CoreSight testing")
      Reported-by: default avatarChristian Borntraeger <borntraeger@linux.ibm.com>
      Reported-by: default avatarSven Schnelle <svens@linux.ibm.com>
      Reviewed-by: default avatarLeo Yan <leo.yan@linaro.org>
      Signed-off-by: default avatarAdrian Hunter <adrian.hunter@intel.com>
      Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
      Cc: Carsten Haitzler <carsten.haitzler@arm.com>
      Cc: coresight@lists.linaro.org
      Cc: Ingo Molnar <mingo@redhat.com>
      Cc: James Clark <james.clark@arm.com>
      Cc: Jiri Olsa <jolsa@kernel.org>
      Cc: Mark Rutland <mark.rutland@arm.com>
      Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
      Cc: Mike Leach <mike.leach@linaro.org>
      Cc: Namhyung Kim <namhyung@kernel.org>
      Cc: Peter Zijlstra <peterz@infradead.org>
      Cc: Suzuki Poulouse <suzuki.poulose@arm.com>
      Link: https://lore.kernel.org/r/a176a3e1-6ddc-bb63-e41c-15cda8c2d5d2@intel.comSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      231e61bc
    • Arnaldo Carvalho de Melo's avatar
      tools headers UAPI: Sync powerpc syscall tables with the kernel sources · 88864611
      Arnaldo Carvalho de Melo authored
      To pick the changes in these csets:
      
        e2375062 ("powerpc/32: fix syscall wrappers with 64-bit arguments of unaligned register-pairs")
      
      That doesn't cause any changes in the perf tools.
      
      As a reminder, this table is used in tools perf to allow features such as:
      
        [root@five ~]# perf trace -e set_mempolicy_home_node
        ^C[root@five ~]#
        [root@five ~]# perf trace -v -e set_mempolicy_home_node
        Using CPUID AuthenticAMD-25-21-0
        event qualifier tracepoint filter: (common_pid != 253729 && common_pid != 3585) && (id == 450)
        mmap size 528384B
        ^C[root@five ~]
        [root@five ~]# perf trace -v -e set*  --max-events 5
        Using CPUID AuthenticAMD-25-21-0
        event qualifier tracepoint filter: (common_pid != 253734 && common_pid != 3585) && (id == 38 || id == 54 || id == 105 || id == 106 || id == 109 || id == 112 || id == 113 || id == 114 || id == 116 || id == 117 || id == 119 || id == 122 || id == 123 || id == 141 || id == 160 || id == 164 || id == 170 || id == 171 || id == 188 || id == 205 || id == 218 || id == 238 || id == 273 || id == 308 || id == 450)
        mmap size 528384B
             0.000 ( 0.008 ms): bash/253735 setpgid(pid: 253735 (bash), pgid: 253735 (bash))      = 0
          6849.011 ( 0.008 ms): bash/16046 setpgid(pid: 253736 (bash), pgid: 253736 (bash))       = 0
          6849.080 ( 0.005 ms): bash/253736 setpgid(pid: 253736 (bash), pgid: 253736 (bash))      = 0
          7437.718 ( 0.009 ms): gnome-shell/253737 set_robust_list(head: 0x7f34b527e920, len: 24) = 0
         13445.986 ( 0.010 ms): bash/16046 setpgid(pid: 253738 (bash), pgid: 253738 (bash))       = 0
        [root@five ~]#
      
      That is the filter expression attached to the raw_syscalls:sys_{enter,exit}
      tracepoints.
      
        $ find tools/perf/arch/ -name "syscall*tbl" | xargs grep -w set_mempolicy_home_node
        tools/perf/arch/mips/entry/syscalls/syscall_n64.tbl:450	common	set_mempolicy_home_node		sys_set_mempolicy_home_node
        tools/perf/arch/powerpc/entry/syscalls/syscall.tbl:450 	nospu	set_mempolicy_home_node		sys_set_mempolicy_home_node
        tools/perf/arch/s390/entry/syscalls/syscall.tbl:450  common	set_mempolicy_home_node	sys_set_mempolicy_home_node	sys_set_mempolicy_home_node
        tools/perf/arch/x86/entry/syscalls/syscall_64.tbl:450	common	set_mempolicy_home_node	sys_set_mempolicy_home_node
        $
      
        $ grep -w set_mempolicy_home_node /tmp/build/perf/arch/x86/include/generated/asm/syscalls_64.c
      	[450] = "set_mempolicy_home_node",
        $
      
      This addresses these perf build warnings:
      
        Warning: Kernel ABI header at 'tools/include/uapi/asm-generic/unistd.h' differs from latest version at 'include/uapi/asm-generic/unistd.h'
        diff -u tools/include/uapi/asm-generic/unistd.h include/uapi/asm-generic/unistd.h
        Warning: Kernel ABI header at 'tools/perf/arch/x86/entry/syscalls/syscall_64.tbl' differs from latest version at 'arch/x86/entry/syscalls/syscall_64.tbl'
        diff -u tools/perf/arch/x86/entry/syscalls/syscall_64.tbl arch/x86/entry/syscalls/syscall_64.tbl
        Warning: Kernel ABI header at 'tools/perf/arch/powerpc/entry/syscalls/syscall.tbl' differs from latest version at 'arch/powerpc/kernel/syscalls/syscall.tbl'
        diff -u tools/perf/arch/powerpc/entry/syscalls/syscall.tbl arch/powerpc/kernel/syscalls/syscall.tbl
        Warning: Kernel ABI header at 'tools/perf/arch/s390/entry/syscalls/syscall.tbl' differs from latest version at 'arch/s390/kernel/syscalls/syscall.tbl'
        diff -u tools/perf/arch/s390/entry/syscalls/syscall.tbl arch/s390/kernel/syscalls/syscall.tbl
        Warning: Kernel ABI header at 'tools/perf/arch/mips/entry/syscalls/syscall_n64.tbl' differs from latest version at 'arch/mips/kernel/syscalls/syscall_n64.tbl'
        diff -u tools/perf/arch/mips/entry/syscalls/syscall_n64.tbl arch/mips/kernel/syscalls/syscall_n64.tbl
      
      Cc: Adrian Hunter <adrian.hunter@intel.com>
      Cc: Ian Rogers <irogers@google.com>
      Cc: Jiri Olsa <jolsa@kernel.org>
      Cc: Namhyung Kim <namhyung@kernel.org>
      Cc: Michael Ellerman <mpe@ellerman.id.au>
      Cc: Nicholas Piggin <npiggin@gmail.com>
      Link: https://lore.kernel.org/lkml/Y01HN2DGkWz8tC%2FJ@kernel.org/Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
      88864611
    • Linus Torvalds's avatar
      Merge tag 'platform-drivers-x86-v6.1-2' of... · 4dc12f37
      Linus Torvalds authored
      Merge tag 'platform-drivers-x86-v6.1-2' of git://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86
      
      Pull x86 platform driver fixes from Hans de Goede:
       "The only thing which stands out is a fix for a backlight regression on
        Chromebooks (under drivers/acpi, with ack from Rafael).
      
        Other then that nothing special to report just various small fixes and
        hardware-id additions"
      
      * tag 'platform-drivers-x86-v6.1-2' of git://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86:
        ACPI: video: Fix missing native backlight on Chromebooks
        platform/x86/intel: pmc/core: Add Raptor Lake support to pmc core driver
        leds: simatic-ipc-leds-gpio: fix incorrect LED to GPIO mapping
        platform/x86/amd: pmc: Read SMU version during suspend on Cezanne systems
        platform/x86: thinkpad_acpi: Fix reporting a non present second fan on some models
        platform/x86: asus-wmi: Add support for ROG X16 tablet mode
      4dc12f37
    • Hans Verkuil's avatar
      media: vivid.rst: loop_video is set on the capture devnode · de547896
      Hans Verkuil authored
      The example on how to use and test Capture Overlay specified
      the wrong video device node. Back in 2015 the loop_video control
      moved from the output device to the capture device, but this
      example code is still referring to the output video device.
      Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@kernel.org>
      de547896
    • Hans Verkuil's avatar
      media: vivid: set num_in/outputs to 0 if not supported · 69d78a80
      Hans Verkuil authored
      If node_types does not have video/vbi/meta inputs or outputs,
      then set num_inputs/num_outputs to 0 instead of 1.
      Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
      Fixes: 0c90f649 (media: vivid: add vivid_create_queue() helper)
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@kernel.org>
      69d78a80
    • Hans Verkuil's avatar
      media: vivid: drop GFP_DMA32 · 957148e2
      Hans Verkuil authored
      >From what I can see, this is not needed. And since using it issues a 'deprecated'
      warning, just drop it.
      Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@kernel.org>
      957148e2
    • Hans Verkuil's avatar
      media: vivid: fix control handler mutex deadlock · eb1d9692
      Hans Verkuil authored
      vivid_update_format_cap() can be called from an s_ctrl callback.
      In that case (keep_controls == true) no control framework functions
      can be called that take the control handler mutex.
      
      The new call to v4l2_ctrl_modify_dimensions() did exactly that.
      Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
      Fixes: 6bc7643d (media: vivid: add pixel_array test control)
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@kernel.org>
      eb1d9692
    • Hans Verkuil's avatar
      media: videodev2.h: V4L2_DV_BT_BLANKING_HEIGHT should check 'interlaced' · 8da7f097
      Hans Verkuil authored
      If it is a progressive (non-interlaced) format, then ignore the
      interlaced timing values.
      Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
      Fixes: 7f68127f ([media] videodev2.h: defines to calculate blanking and frame sizes)
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@kernel.org>
      8da7f097
    • Hans Verkuil's avatar
      media: v4l2-dv-timings: add sanity checks for blanking values · 4b6d66a4
      Hans Verkuil authored
      Add sanity checks to v4l2_valid_dv_timings() to ensure that the provided
      blanking values are reasonable.
      Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
      Fixes: b18787ed ([media] v4l2-dv-timings: add new helper module)
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@kernel.org>
      4b6d66a4
    • Hans Verkuil's avatar
      media: vivid: dev->bitmap_cap wasn't freed in all cases · 1f65ea41
      Hans Verkuil authored
      Whenever the compose width/height values change, the dev->bitmap_cap
      vmalloc'ed array must be freed and dev->bitmap_cap set to NULL.
      
      This was done in some places, but not all. This is only an issue if
      overlay support is enabled and the bitmap clipping is used.
      Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
      Fixes: ef834f78 ([media] vivid: add the video capture and output parts)
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@kernel.org>
      1f65ea41
    • Hans Verkuil's avatar
      media: vivid: s_fbuf: add more sanity checks · f8bcaf71
      Hans Verkuil authored
      VIDIOC_S_FBUF is by definition a scary ioctl, which is why only root
      can use it. But at least check if the framebuffer parameters match that
      of one of the framebuffer created by vivid, and reject anything else.
      Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
      Fixes: ef834f78 ([media] vivid: add the video capture and output parts)
      Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@kernel.org>
      f8bcaf71
    • Sreekanth Reddy's avatar
      scsi: mpt3sas: re-do lost mpt3sas DMA mask fix · 1a2dcbdd
      Sreekanth Reddy authored
      This is a re-do of commit e0e0747d ("scsi: mpt3sas: Fix return value
      check of dma_get_required_mask()"), which I ended up undoing in a
      mis-merge in commit 62e6e594 ("Merge tag 'scsi-misc' of
      git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi").
      
      The original commit message was
      
        scsi: mpt3sas: Fix return value check of dma_get_required_mask()
      
        Fix the incorrect return value check of dma_get_required_mask().  Due to
        this incorrect check, the driver was always setting the DMA mask to 63 bit.
      
        Link: https://lore.kernel.org/r/20220913120538.18759-2-sreekanth.reddy@broadcom.com
        Fixes: ba27c5cf ("scsi: mpt3sas: Don't change the DMA coherent mask after allocations")
      Signed-off-by: default avatarSreekanth Reddy <sreekanth.reddy@broadcom.com>
      Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
      
      and this fix was lost when I mis-merged the conflict with commit
      9df65096 ("scsi: mpt3sas: Don't change DMA mask while reallocating
      pools").
      Reported-by: default avatarJuergen Gross <jgross@suse.com>
      Fixes: 62e6e594 ("Merge tag 'scsi-misc' of git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi")
      Link: https://lore.kernel.org/all/CAHk-=wjaK-TxrNaGtFDpL9qNHL1MVkWXO1TT6vObD5tXMSC4Zg@mail.gmail.comSigned-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      1a2dcbdd
    • Steven Rostedt (Google)'s avatar
      x86/mm: Do not verify W^X at boot up · a970174d
      Steven Rostedt (Google) authored
      Adding on the kernel command line "ftrace=function" triggered:
      
        CPA detected W^X violation: 8000000000000063 -> 0000000000000063 range: 0xffffffffc0013000 - 0xffffffffc0013fff PFN 10031b
        WARNING: CPU: 0 PID: 0 at arch/x86/mm/pat/set_memory.c:609
        verify_rwx+0x61/0x6d
        Call Trace:
           __change_page_attr_set_clr+0x146/0x8a6
           change_page_attr_set_clr+0x135/0x268
           change_page_attr_clear.constprop.0+0x16/0x1c
           set_memory_x+0x2c/0x32
           arch_ftrace_update_trampoline+0x218/0x2db
           ftrace_update_trampoline+0x16/0xa1
           __register_ftrace_function+0x93/0xb2
           ftrace_startup+0x21/0xf0
           register_ftrace_function_nolock+0x26/0x40
           register_ftrace_function+0x4e/0x143
           function_trace_init+0x7d/0xc3
           tracer_init+0x23/0x2c
           tracing_set_tracer+0x1d5/0x206
           register_tracer+0x1c0/0x1e4
           init_function_trace+0x90/0x96
           early_trace_init+0x25c/0x352
           start_kernel+0x424/0x6e4
           x86_64_start_reservations+0x24/0x2a
           x86_64_start_kernel+0x8c/0x95
           secondary_startup_64_no_verify+0xe0/0xeb
      
      This is because at boot up, kernel text is writable, and there's no
      reason to do tricks to updated it.  But the verifier does not
      distinguish updates at boot up and at run time, and causes a warning at
      time of boot.
      
      Add a check for system_state == SYSTEM_BOOTING and allow it if that is
      the case.
      
      [ These SYSTEM_BOOTING special cases are all pretty horrid, but the x86
        text_poke() code does some odd things at bootup, forcing this for now
          - Linus ]
      
      Link: https://lore.kernel.org/r/20221024112730.180916b3@gandalf.local.home
      Fixes: 652c5bf3 ("x86/mm: Refuse W^X violations")
      Signed-off-by: default avatarSteven Rostedt (Google) <rostedt@goodmis.org>
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      a970174d