- 09 Jan, 2023 40 commits
-
-
Sven Schnelle authored
When activating the view fails (in this case because the 3270 is disconnected) return from the notifer callback. Otherwise the system will deadlock. Signed-off-by:
Sven Schnelle <svens@linux.ibm.com> Acked-by:
Heiko Carstens <hca@linux.ibm.com> Signed-off-by:
-
Sven Schnelle authored
Use __packed __aligned instead of __attribute__((packed, aligned(X))); to match the rest of the file. Signed-off-by:
-
Sven Schnelle authored
In order to use the fs3270 one would need at least the ioctl definitions in uapi. Add two new include files in uapi, which contain: fs3270: ioctl number declarations + returned struct for TUBGETMOD. raw3270: all the orders, attributes and similar stuff used with 3270 terminals. Signed-off-by:
-
Sven Schnelle authored
fs3270 uses EWRITEA to clear the screen when a user opens /dev/3270/tub. However it misses the attribute byte after the EWRITEA, so (at least) x3270 complains about 'Record too short, missing write flags'. Add the missing flag byte to fix this. Signed-off-by:
-
Sven Schnelle authored
fix function prototypes split over two lines like: static void foobar(void) Signed-off-by:
-
Sven Schnelle authored
Signed-off-by:
-
Sven Schnelle authored
remove a duplicate assignment reported by checkpatch. Signed-off-by:
-
Sven Schnelle authored
Fix a few missing braces and wrong placement of braces reported by checkpatch. Signed-off-by:
-
Sven Schnelle authored
Fix a few whitespace errors reported by checkpatch, namely superfluous whitespace, missing spaces and empty lines. Signed-off-by:
-
Sven Schnelle authored
Fix the following checkpatch warning: CHECK: Comparison to NULL could be written "!rp" + if (rp == NULL) Signed-off-by:
-
Sven Schnelle authored
move the core processing to __raw3270_activate_view() to reduce the required if/else blocks and indentiion levels. Signed-off-by:
-
Sven Schnelle authored
WARN_ON_ONCE if list is not empty, and return an error code instead. Signed-off-by:
-
Sven Schnelle authored
Signed-off-by:
-
Sven Schnelle authored
Add a small comment to the lock member of struct raw3270_view to make checkpatch happy. Signed-off-by:
-
Sven Schnelle authored
checkpatch complains about missing argument names in function declarations. Fix it. Signed-off-by:
-
Sven Schnelle authored
Signed-off-by:
-
Sven Schnelle authored
Fixes a few checkpatch warning about EXPORT_SYMBOL being at the end of the file instead of being next to the functions. Signed-off-by:
-
Sven Schnelle authored
Fix remaining checkpatch issues, like misplaced brackets, whitespace and similar things. No functional change. Signed-off-by:
-
Sven Schnelle authored
Use msecs_to_jiffies() instead of HZ/10. Signed-off-by:
-
Sven Schnelle authored
fix the following and similar checkpatch warnings: CHECK: multiple assignments should be avoided + tp->cx = tp->saved_cx = 0; Signed-off-by:
-
Sven Schnelle authored
fix the following and similar checkpatch warnings: CHECK: Avoid CamelCase: <ESnormal> + enum { ESnormal, ESesc, ESsquare, ESparen, ESgetpars }; Signed-off-by: -
Sven Schnelle authored
To let the user know about function key bindings, print them next to the Running/History field at the lower right of the screen. Also print the scrollback position. Signed-off-by:
Niklas Schnelle <schnelle@linux.ibm.com> Signed-off-by:
-
Sven Schnelle authored
With the previous change this reduces the size of struct tty3270_attribute from four to two bytes. As we have this struct allocated for each character cell, this saves quite some memory. Signed-off-by:
-
Sven Schnelle authored
As we're only supportign 8 colors, we don't need 8 bits. Reduce the size to 4 bits to save memory. Signed-off-by:
-
Sven Schnelle authored
Command line recalling is the last user of the 3270 custom malloc() like allocator. Remove this dependency by using a statically allocated buffer for the saved command lines, and also remove the allocator. Signed-off-by:
-
Sven Schnelle authored
Preparation patch to allow removing the custom 3270 memory allocator. Signed-off-by:
-
Sven Schnelle authored
The length of the screen line is variable with the 3270 protocol. For each attribute (foreground, background color, highlighting etc) we need 3 bytes: the set attribute order, the attribute number, and the value of the attribute. This means that depending on screen content, we might end up 3*3 bytes addtional data for a single character. Allocating the maximum possible amount of memory is quite a lot, and we cannot easily extend the lines by allocating memory because we might get called from atomic context. Failing to extend the memory would also be bad as that would mean that we could miss kernel messages in oom conditions. Therefore move the conversion to a 3270 datastream to tty3270_update(), and use only single line buffer. Signed-off-by:
-
Sven Schnelle authored
Updating the status line is almost the same as generating it when redrawing the screen. However, the code is much easier to read when doing so. Signed-off-by:
-
Sven Schnelle authored
There are lots of places adding attributes or orders to the datastream. Add a few helpers to make that code shorter and easier to read. Signed-off-by:
-
Sven Schnelle authored
Instead of always converting the character set, only convert them when the line is really displayed. Signed-off-by:
-
Sven Schnelle authored
To make the upcoming patches easier to read, move tty3270_convert_line() before changing code. No functional change. Signed-off-by:
-
Sven Schnelle authored
All callers of raw3270_buffer_address() are calculating the offset from some x/y coordinates. Move that calculation inside of the function, so user can pass the x/y values directly. Note that negative values are relative to the end-of-line or end-of-screen. Signed-off-by:
-
Sven Schnelle authored
No functional change (except more memory consumption), in preparation for the line buffer rework. Signed-off-by:
-
Sven Schnelle authored
There a quite a few places using 'tp->view.rows - 2'. Add a helper function for this. This will also be used when a function key help line will be added. Signed-off-by:
-
Sven Schnelle authored
To make the code easier to read, split up tty3270_convertline() into several subfunctions: - tty3270_resize_line() to realloc the line if it doesn't have enough space left - tty3270_required_length() to calculate how much space we need - tty3270_add_attributes() to add the color and highlight attributes - tty3270_add_reset_attributes() to reset the attributes at the end of the line Signed-off-by:
-
Sven Schnelle authored
There's no easy way to figure out whether the user has re-connected to the z/VM session. When the user re-connected with a different geometry to z/VM, the screen layout is broken. Allow the user to force a resizing by pressing the Clear Key. Signed-off-by:
-
Sven Schnelle authored
This change was initially made to reduce code duplication when the con3270 and tty3270 shared the same resize code. It still makes sense to move the resize workqueue to raw3270 in case we add some other view later. Signed-off-by:
-
Sven Schnelle authored
There are a few places (and there would be more with the following commits) like this: raw3270_request_reset(cp->kreset); raw3270_request_set_cmd(cp->kreset, TC_WRITE); raw3270_request_add_data(cp->kreset, &kreset_data, 1); raw3270_start(&cp->view, cp->kreset); i.e reset a request, setting the command, adding payload, and starting the request. Add a helper raw3270_start_request() which takes a command and the payload as argument and calls the approppriate functions. Signed-off-by:
-
Sven Schnelle authored
Use AID_* instead of hex numbers to make the code a bit easier to read. also convert the if/else blocks to a switch statement in tty3270_read_tasklet(). Signed-off-by:
-
Sven Schnelle authored
With 'TERM=vt220' zsh is sending several NUL characters with the prompt to the tty. Both xterm and the linux drm console seem to ignore them. Ignore them in tty3270 as well. Signed-off-by:
-
