- 28 May, 2014 40 commits
-
-
H Hartley Sweeten authored
This member of the private data is just a copy of the channels from the cmd->chanlist. Remove the member and just use the cmd->chanlist directly. Remove the unneeded 'len' local variable in usbduxsigma_ao_urb_complete(). This is just the cmd->chanlist_len. Signed-off-by:
H Hartley Sweeten <hsweeten@visionengravers.com> Reviewed-by:
Ian Abbott <abbotti@mev.co.uk> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
H Hartley Sweeten authored
Use the 'cmd' pointer to access the chanlist instead of getting to it using the comedi_subdevice pointer. Remove the unneeded 'n' local variable, this is just the cmd->chanlist_len. Signed-off-by:
-
H Hartley Sweeten authored
This member of the private data is just a copy of the channels from the cmd->chanlist. Remove the member and just use the cmd->chanlist directly. Remove the unneeded 'len' local variable in usbdux_ao_isoc_irq(). This is just the cmd->chanlist_len. Signed-off-by:
-
H Hartley Sweeten authored
This member of the private data can be determined from the cmd->stop_src. Do that instead. Signed-off-by:
-
H Hartley Sweeten authored
This member of the private data can be determined from the cmd->stop_src. Do that instead. Signed-off-by:
-
H Hartley Sweeten authored
This member of the private data can be determined from the cmd->stop_src. Do that instead. Signed-off-by:
-
H Hartley Sweeten authored
This member of the private data can be determined from the cmd->stop_src. Do that instead. Signed-off-by:
-
H Hartley Sweeten authored
This member of the private data can be determined from the cmd->stop_src. Do that instead. Signed-off-by:
-
H Hartley Sweeten authored
Use the comedi_fc helper cfc_check_trigger_arg_is() to validate the trigger argument when the source is TRIG_TIMER. For aesthetics, rename the local variable 'tmp' to 'arg'. Signed-off-by:
-
H Hartley Sweeten authored
Use the comedi_fc helper cfc_check_trigger_arg_is() to validate the trigger arguments when the source is TRIG_TIMER. Use cfc_check_trigger_arg_min() to vaidate the scan_begin_arg when the scan_begin_src and convert_src are both TRIG_TIMER. All the arguments are unsigned int, change the local variable to an unsigned int and rename it for aesthetic reasons. Signed-off-by:
-
H Hartley Sweeten authored
Use the comedi_fc helper cfc_check_trigger_arg_is() to validate the trigger arguments when the source is TRIG_TIMER. Use cfc_check_trigger_arg_min() to vaidate the scan_begin_arg when the scan_begin_src and convert_src are both TRIG_TIMER. All the arguments are unsigned int, change the local variable to an unsigned int and rename it for aesthetic reasons. Change the type of the first parameter to s626_ns_to_timer() to remove the need for the casts. Signed-off-by:
-
H Hartley Sweeten authored
Use the comedi_fc helper cfc_check_trigger_arg_is() to validate the trigger arguments when the source is TRIG_TIMER. Use cfc_check_trigger_arg_min() to vaidate the scan_begin_arg when the scan_begin_src and convert_src are both TRIG_TIMER. All the arguments are unsigned int, change the local variable to an unsigned int and rename it for aesthetic reasons. Signed-off-by:
-
H Hartley Sweeten authored
Use the comedi_fc helper cfc_check_trigger_arg_is() to validate the trigger arguments when the source is TRIG_TIMER. All the arguments are unsigned int, change the local variable to an unsigned int and rename it for aesthetic reasons. Signed-off-by:
-
H Hartley Sweeten authored
Use the comedi_fc helper cfc_check_trigger_arg_is() to validate the trigger argument when the source is TRIG_TIMER. The minimum test is not needed, this was already validated in Step 3. All the arguments are unsigned int, change the local variable to an unsigned int and rename it for aesthetic reasons. Signed-off-by:
-
H Hartley Sweeten authored
Use the comedi_fc helper cfc_check_trigger_arg_is() to validate the trigger argument when the source is TRIG_TIMER. The minimum test is not needed, this was already validated in Step 3. All the arguments are unsigned int, change the local variable to an unsigned int and rename it for aesthetic reasons. Signed-off-by:
-
H Hartley Sweeten authored
Use the comedi_fc helper cfc_check_trigger_arg_is() to validate the trigger argument when the source is TRIG_TIMER. The minimum test is not needed, this was already validated in Step 3. All the arguments are unsigned int, change the local variable to an unsigned int and rename it for aesthetic reasons. Signed-off-by:
-
H Hartley Sweeten authored
Use the comedi_fc helper cfc_check_trigger_arg_is() to validate the trigger argument when the source is TRIG_TIMER. All the arguments are unsigned int, change the local variable to an unsigned int and rename it for aesthetic reasons. Signed-off-by:
-
H Hartley Sweeten authored
Use the comedi_fc helper cfc_check_trigger_arg_is() to validate the trigger argument when the source is TRIG_TIMER. All the arguments are unsigned int, change the local variable to an unsigned int and rename it for aesthetic reasons. Signed-off-by:
-
H Hartley Sweeten authored
Use the comedi_fc helper cfc_check_trigger_arg_is() to validate the trigger argument when the source is TRIG_TIMER. All the arguments are unsigned int, change the local variable to an unsigned int and rename it for aesthetic reasons. Signed-off-by:
-
H Hartley Sweeten authored
Use the comedi_fc helper cfc_check_trigger_arg_is() to validate the trigger arguments when the source is TRIG_TIMER. All the arguments are unsigned int, change the local variable to an unsigned int and rename it for aesthetic reasons. Signed-off-by:
-
H Hartley Sweeten authored
Use the comedi_fc helper cfc_check_trigger_arg_is() to validate the trigger argument when the source is TRIG_TIMER. All the arguments are unsigned int, change the local variable to an unsigned int and rename it for aesthetic reasons. Signed-off-by:
-
H Hartley Sweeten authored
Use the comedi_fc helper cfc_check_trigger_arg_is() to validate the trigger arguments when the source is TRIG_TIMER. Use cfc_check_trigger_arg_min() to vaidate the scan_begin_arg when the scan_begin_src and convert_src are both TRIG_TIMER. All the arguments are unsigned int, change the local variable to an unsigned int and rename it for aesthetic reasons. Signed-off-by:
-
H Hartley Sweeten authored
Use the comedi_fc helper cfc_check_trigger_arg_is() to validate the trigger arguments when the source is TRIG_TIMER. All the arguments are unsigned int, change the local variable to an unsigned int and rename it for aesthetic reasons. Signed-off-by:
-
H Hartley Sweeten authored
Use the comedi_fc helper cfc_check_trigger_arg_is() to validate the trigger arguments when the source is TRIG_TIMER. For aesthetics, rename the local variable 'tmp' to 'arg'. Also, change the 'err' variable to the correct type. Signed-off-by:
-
H Hartley Sweeten authored
Use the comedi_fc helper cfc_check_trigger_arg_is() to validate the trigger arguments when the source is TRIG_TIMER. Tidy up the local varaibles in the function. Signed-off-by:
-
H Hartley Sweeten authored
Use the comedi_fc helper cfc_check_trigger_arg_is() to validate the trigger arguments when the source is TRIG_TIMER. All the arguments are unsigned int, change the local variable to an unsigned int and rename it for aesthetic reasons. Signed-off-by:
-
H Hartley Sweeten authored
Use the comedi_fc helper cfc_check_trigger_arg_is() to validate the trigger arguments when the source is TRIG_TIMER. All the arguments are unsigned int, change the local variable to an unsigned int and rename it for aesthetic reasons. Signed-off-by:
-
H Hartley Sweeten authored
Use the comedi_fc helper, cfc_check_trigger_arg_is(), to validate the arguments for the TRIG_TIMER command sources. Pass the local variable to i8253_cascade_ns_to_timer() instead of the cmd argument. This value is modified by that function to return the actual time (in nanoseconds) that the timer will be programmed with based on the calculated divisors. The cfc_check_trigger_arg_is() helper will then validate that the argument is that value and modify it if not. Use cfc_check_trigger_arg_min() to do validate the cmd->scan_begin_arg when the scan_begin_src is TRIG_TIMER and the convert_src is TRIG_NOW. All the arguments are unsigned int, change the local variable to an unsigned int and rename it for aesthetic reasons. Signed-off-by:
-
H Hartley Sweeten authored
Use the comedi_fc helper, cfc_check_trigger_arg_is(), to validate the cmd->scan_begin_arg for the scan_begin_src TRIG_TIMER. Pass the local variable to dt2k_ns_to_timer() instead of the cmd argument. This value is modified by that function to return the actual time (in nanoseconds) that the timer will be programmed with based on the calculated divisor. The cfc_check_trigger_arg_is() helper will then validate that the cmd->cscan_begin_arg is that value and modify it if not. Also use cfc_check_trigger_arg_is() to validate the cmd->convert_arg using the same logic. Use cfc_check_trigger_arg_min() to do validate the cmd->scan_begin_arg when the convert_src and scan_begin_src are both TRIG_TIMER. All the arguments are unsigned int, change the local variable to an unsigned int and rename it for aesthetic reasons. Signed-off-by:
-
H Hartley Sweeten authored
Use the comedi_fc helper, cfc_check_trigger_arg_is(), to validate the cmd->convert_arg for the convert_src TRIG_TIMER. Pass the local variable to i8253_cascade_ns_to_timer() instead of the cmd argument. This value is modified by that function to return the actual time (in nanoseconds) that the timer will be programmed with based on the calculated divisors. The cfc_check_trigger_arg_is() helper will then validate that the cmd->convert_arg is that value and modify it if not. The minimum validation is not needed. That was already handled in Step 3. All the arguments are unsigned int, change the local variable to an unsigned int and rename it for aesthetic reasons.. Signed-off-by:
-
H Hartley Sweeten authored
Use the comedi_fc helper, cfc_check_trigger_arg_is(), to validate the cmd->convert_arg for the convert_src TRIG_TIMER. Pass the local variable to i8253_cascade_ns_to_timer() instead of the cmd argument. This value is modified by that function to return the actual time (in nanoseconds) that the timer will be programmed with based on the calculated divisors. The cfc_check_trigger_arg_is() helper will then validate that the cmd->convert_arg is that value and modify it if not. Also use cfc_check_trigger_arg_is() to validate that the cmd->scan_begin_arg is the calculate value and modify it if not. Signed-off-by:
-
H Hartley Sweeten authored
The major number for comedi has been listed in Documentation/devices.txt since kernel 2.1.88. Signed-off-by:
-
Marcin Kostrzewa authored
Signed-off-by:
Marcin Kostrzewa <marckostrzewa@gmail.com> Reviewed-by:
-
Greg Kroah-Hartman authored
This reverts commit f8cc81f8. It breaks the build in linux-next. Reported-by:
Stephen Rothwell <sfr@canb.auug.org.au> Cc: Paul Bolle <pebolle@tiscali.nl> Signed-off-by:
-
Konrad Zapalowicz authored
This commit refactors the iwctl_giwaplist() function so that the sparse warning "the frame size of 1292 bytes is larger than 1024 bytes [-Wframe-larger-than=]" is no more. The root cause of this warning were two arrays allocated on the stack and this commit changes this - these arrays are now kmalloc'ed. As a result the function is refactored and hopefully stil working the same. I were not able to test these changes so at least the carefull review is more than welcomed. Note that my changes has broadened the set of error codes that this function can return. The new error code is ENOMEM. Luckily, this is no issue. Signed-off-by:
Konrad Zapalowicz <bergo.torino@gmail.com> Reviewed-by:
Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by:
-
Malcolm Priestley authored
replace with dev_dbg Signed-off-by:
Malcolm Priestley <tvboxspy@gmail.com> Signed-off-by:
-
Malcolm Priestley authored
In commit 78a650dc there was a typo error abyVT3226_InitTable -> at3226_init_table abyVT3226D0_InitTable -> at3226d0_init_table Shoud be vt3226_init_table and vt3226d0_init_table Signed-off-by:
-
Malcolm Priestley authored
Signed-off-by:
-
Malcolm Priestley authored
Signed-off-by:
-
Malcolm Priestley authored
Remove raw and use txpower. Signed-off-by:
-
