Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
M
mariadb
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Kirill Smelkov
mariadb
Commits
b77c0add
Commit
b77c0add
authored
Feb 21, 2014
by
Rich Prohaska
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
#190 zero out new null bytes to force valgrind to quit complaining about uninitialized bytes
parent
3fbd54a9
Changes
1
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
2 additions
and
1 deletion
+2
-1
storage/tokudb/tokudb_update_fun.cc
storage/tokudb/tokudb_update_fun.cc
+2
-1
No files found.
storage/tokudb/tokudb_update_fun.cc
View file @
b77c0add
...
@@ -512,7 +512,6 @@ static int tokudb_hcad_update_fun(
...
@@ -512,7 +512,6 @@ static int tokudb_hcad_update_fun(
old_null_bytes
=
(
uchar
*
)
old_val
->
data
;
old_null_bytes
=
(
uchar
*
)
old_val
->
data
;
new_null_bytes
=
new_val_data
;
new_null_bytes
=
new_val_data
;
memcpy
(
&
curr_old_null_pos
,
extra_pos
,
sizeof
(
uint32_t
));
memcpy
(
&
curr_old_null_pos
,
extra_pos
,
sizeof
(
uint32_t
));
extra_pos
+=
sizeof
(
uint32_t
);
extra_pos
+=
sizeof
(
uint32_t
);
memcpy
(
&
curr_new_null_pos
,
extra_pos
,
sizeof
(
uint32_t
));
memcpy
(
&
curr_new_null_pos
,
extra_pos
,
sizeof
(
uint32_t
));
...
@@ -521,6 +520,8 @@ static int tokudb_hcad_update_fun(
...
@@ -521,6 +520,8 @@ static int tokudb_hcad_update_fun(
memcpy
(
&
num_columns
,
extra_pos
,
sizeof
(
num_columns
));
memcpy
(
&
num_columns
,
extra_pos
,
sizeof
(
num_columns
));
extra_pos
+=
sizeof
(
num_columns
);
extra_pos
+=
sizeof
(
num_columns
);
memset
(
new_null_bytes
,
0
,
new_num_null_bytes
);
// shut valgrind up
//
//
// now go through and apply the change into new_val_data
// now go through and apply the change into new_val_data
//
//
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment