Commit f9c2f7cd authored by Vasil Dimov's avatar Vasil Dimov

Remove unused parameter has_dict_mutex of dict_update_statistics_low()

Also delete dict_update_statistics() and rename dict_update_statistics_low()
to dict_update_statistics() because the only thing that distinguished those
two functions was the removed parameter.
parent db054043
...@@ -4213,16 +4213,13 @@ Calculates new estimates for table and index statistics. The statistics ...@@ -4213,16 +4213,13 @@ Calculates new estimates for table and index statistics. The statistics
are used in query optimization. */ are used in query optimization. */
UNIV_INTERN UNIV_INTERN
void void
dict_update_statistics_low( dict_update_statistics(
/*=======================*/ /*===================*/
dict_table_t* table, /*!< in/out: table */ dict_table_t* table, /*!< in/out: table */
ibool only_calc_if_missing_stats,/*!< in: only ibool only_calc_if_missing_stats)/*!< in: only
update/recalc the stats if they have update/recalc the stats if they have
not been initialized yet, otherwise not been initialized yet, otherwise
do nothing */ do nothing */
ibool has_dict_mutex __attribute__((unused)))
/*!< in: TRUE if the caller has the
dictionary mutex */
{ {
dict_index_t* index; dict_index_t* index;
ulint sum_of_index_sizes = 0; ulint sum_of_index_sizes = 0;
...@@ -4316,22 +4313,6 @@ dict_update_statistics_low( ...@@ -4316,22 +4313,6 @@ dict_update_statistics_low(
dict_table_stats_unlock(table, RW_X_LATCH); dict_table_stats_unlock(table, RW_X_LATCH);
} }
/*********************************************************************//**
Calculates new estimates for table and index statistics. The statistics
are used in query optimization. */
UNIV_INTERN
void
dict_update_statistics(
/*===================*/
dict_table_t* table, /*!< in/out: table */
ibool only_calc_if_missing_stats)/*!< in: only
update/recalc the stats if they have
not been initialized yet, otherwise
do nothing */
{
dict_update_statistics_low(table, only_calc_if_missing_stats, FALSE);
}
/**********************************************************************//** /**********************************************************************//**
Prints info of a foreign key constraint. */ Prints info of a foreign key constraint. */
static static
...@@ -4409,9 +4390,7 @@ dict_table_print_low( ...@@ -4409,9 +4390,7 @@ dict_table_print_low(
ut_ad(mutex_own(&(dict_sys->mutex))); ut_ad(mutex_own(&(dict_sys->mutex)));
dict_update_statistics_low(table, dict_update_statistics(table, FALSE /* update even if initialized */);
FALSE /* update even if initialized */,
TRUE /* we have the dict mutex */);
dict_table_stats_lock(table, RW_S_LATCH); dict_table_stats_lock(table, RW_S_LATCH);
......
...@@ -222,10 +222,8 @@ loop: ...@@ -222,10 +222,8 @@ loop:
is no index */ is no index */
if (dict_table_get_first_index(table)) { if (dict_table_get_first_index(table)) {
dict_update_statistics_low( dict_update_statistics(table, FALSE /* update
table, even if initialized */);
FALSE /* update even if initialized */,
TRUE /* we have the dict mutex */);
} }
dict_table_print_low(table); dict_table_print_low(table);
......
...@@ -1054,20 +1054,6 @@ Calculates new estimates for table and index statistics. The statistics ...@@ -1054,20 +1054,6 @@ Calculates new estimates for table and index statistics. The statistics
are used in query optimization. */ are used in query optimization. */
UNIV_INTERN UNIV_INTERN
void void
dict_update_statistics_low(
/*=======================*/
dict_table_t* table, /*!< in/out: table */
ibool only_calc_if_missing_stats,/*!< in: only
update/recalc the stats if they have
not been initialized yet, otherwise
do nothing */
ibool has_dict_mutex);/*!< in: TRUE if the caller has the
dictionary mutex */
/*********************************************************************//**
Calculates new estimates for table and index statistics. The statistics
are used in query optimization. */
UNIV_INTERN
void
dict_update_statistics( dict_update_statistics(
/*===================*/ /*===================*/
dict_table_t* table, /*!< in/out: table */ dict_table_t* table, /*!< in/out: table */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment