Commit d93fdacb authored by Kirill Smelkov's avatar Kirill Smelkov

.

parent a7314b16
......@@ -228,7 +228,7 @@ class Application(ThreadedApplication):
"Too many connection failures to the primary master")
logging.info('Connected to %s', self.primary_master_node)
try:
# Request identification and required informations to be NOTE
# Request identification and required informations to be
# operational. Might raise ConnectionClosed so that the new
# primary can be looked-up again.
logging.info('Initializing from master')
......@@ -369,7 +369,7 @@ class Application(ThreadedApplication):
elif self._loading_invalidated:
# oid has just been invalidated.
if not next_tid:
next_tid = self._loading_invalidated # NOTE stores up to head
next_tid = self._loading_invalidated
self._cache.store(oid, data, tid, next_tid)
# Else, we just reconnected to the master.
finally:
......
......@@ -141,7 +141,7 @@ class EpollEventManager(object):
# to wake up (which may not even happen, and lead to EMFILE).
connector.shutdown()()
def isIdle(self): # NOTE
def isIdle(self):
return not (self._pending_processing or self.writer_set)
def _addPendingConnection(self, conn):
......
......@@ -684,8 +684,8 @@ class RequestIdentification(Packet):
_answer = PStruct('accept_identification',
PFNodeType,
PUUID('my_uuid'),
PNumber('num_partitions'), # XXX why here, not in pt updates ?
PNumber('num_replicas'), # XXX -> because current neo/py cannot change Npt at runtime
PNumber('num_partitions'),
PNumber('num_replicas'),
PUUID('your_uuid'),
)
......@@ -738,7 +738,6 @@ class PartitionTable(Packet):
PFRowList,
)
# XXX dup wrt PartitionChanges ? -> no: here it is "send all rows" of PT
class NotifyPartitionTable(Packet):
"""
Send rows in a partition table to update other nodes. PM -> S, C.
......@@ -748,7 +747,6 @@ class NotifyPartitionTable(Packet):
PFRowList,
)
# XXX dup wrt NotifyPartitionTable ? -> no: here it s "send changes" of PT
class PartitionChanges(Packet):
"""
Notify a subset of a partition table. This is used to notify changes.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment