Stop enabling PropertyTypeValidity implicitly, because this is extremly slow

and useless in production.
A PropertyTypeValidityConstraint property shee now exists, if you want this
constraint enabled, associate this property sheet with portal types (or
classes)


git-svn-id: https://svn.erp5.org/repos/public/erp5/trunk@36396 20353a03-c40f-0410-a6d1-a30d3c3de9de

product/ERP5Type/PropertySheet/PropertyTypeValidityConstraint.py

+##############################################################################
+#
+# Copyright (c) 2010 Nexedi SA and Contributors. All Rights Reserved.
+#
+# WARNING: This program as such is intended to be used by professional
+# programmers who take the whole responsability of assessing all potential
+# consequences resulting from its eventual inadequacies and bugs
+# End users who are looking for a ready-to-use solution with commercial
+# garantees and support are strongly adviced to contract a Free Software
+# Service Company
+#
+# This program is Free Software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License
+# as published by the Free Software Foundation; either version 2
+# of the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA  02111-1307, USA.
+#
+##############################################################################
+
+class PropertyTypeValidityConstraint:
+  """Property sheet to enable Property Type Validity Constraint
+  """
+
+  _constraints = (
+    { 'type': 'PropertyTypeValidity',
+      'id': 'type_check',
+      'description': "Type Validity Check Error",
+    },
+  )

product/ERP5Type/Utils.py

@@ -1549,12 +1549,8 @@ def setDefaultProperties(property_holder, object=None, portal=None):
         createRelatedValueAccessors(property_holder, cat, read_permission=read_permission)
       # Unnecessary to create these accessors more than once.
       base_category_dict.clear()
-    from Products.ERP5Type.Constraint import PropertyTypeValidity
-    # Create the constraint method list - always check type
-    property_holder.constraints = [
-                  PropertyTypeValidity(id='type_check',
-                    description="Type Validity Check Error") ]
 
+    property_holder.constraints = []
     for const in constraint_list:
       createConstraintList(property_holder, constraint_definition=const)
     # ERP5 _properties and Zope _properties are somehow different

product/ERP5Type/tests/testConstraint.py

@@ -1440,6 +1440,11 @@ class TestConstraint(PropertySheetTestCase):
             'acquisition_portal_type':('Category'),
             'acquisition_accessor_id':'getTitle',
             'mode':''},)
+          _constraints = (
+            { 'type': 'PropertyTypeValidity',
+              'id': 'type_check',
+              'description': "Type Validity Check Error",
+            }, )
       ''')
     self.assertEquals([], person.checkConsistency())
     group3 = self.category_tool.restrictedTraverse(