notes/reorg.

builder/amazon/chroot/communicator.go

@@ -52,22 +52,6 @@ func (c *Communicator) Start(cmd *packer.RemoteCmd) error {
 	return nil
 }
 
-func (c *Communicator) Upload(dst string, r io.Reader) error {
-	dst = filepath.Join(c.Chroot, dst)
-	log.Printf("Uploading to chroot dir: %s", dst)
-	f, err := os.Create(dst)
-	if err != nil {
-		return err
-	}
-	defer f.Close()
-
-	if _, err := io.Copy(f, r); err != nil {
-		return err
-	}
-
-	return nil
-}
-
 func (c *Communicator) UploadDir(dst string, src string, exclude []string) error {
 	walkFn := func(fullPath string, info os.FileInfo, err error) error {
 		if err != nil {
@@ -100,6 +84,22 @@ func (c *Communicator) UploadDir(dst string, src string, exclude []string) error
 	return filepath.Walk(src, walkFn)
 }
 
+func (c *Communicator) Upload(dst string, r io.Reader) error {
+	dst = filepath.Join(c.Chroot, dst)
+	log.Printf("Uploading to chroot dir: %s", dst)
+	f, err := os.Create(dst)
+	if err != nil {
+		return err
+	}
+	defer f.Close()
+
+	if _, err := io.Copy(f, r); err != nil {
+		return err
+	}
+
+	return nil
+}
+
 func (c *Communicator) Download(src string, w io.Writer) error {
 	src = filepath.Join(c.Chroot, src)
 	log.Printf("Downloading from chroot dir: %s", src)

builder/amazon/chroot/step_copy_files.go

@@ -68,6 +68,12 @@ func (s *StepCopyFiles) CleanupFunc(multistep.StateBag) error {
 	return nil
 }
 
+/* TODO: move to util file.
+ * change prototype to
+      func copySingle(dst string, src string, copyCommand string) error
+ * I think we should switch to cp for copying files, then allow specifying a copy_files_command or something.
+Maybe we should just do a execute_wrapper that allows you to wrap every command...
+*/
 func (s *StepCopyFiles) copySingle(dst, src string) error {
 	// Stat the src file so we can copy the mode later
 	srcInfo, err := os.Stat(src)