X client: Cleanup a bit around decompressing

go/neo/client.go

@@ -464,13 +464,10 @@ func (c *Client) _Load(ctx context.Context, xid zodb.Xid) (*mem.Buf, zodb.Tid, e
 	}
 
 	if resp.Compression {
-		// XXX cleanup mess vvv
-		buf2 := mem.BufAlloc(len(buf.Data))
-		buf2.Data = buf2.Data[:0]
-		udata, err := xzlib.Decompress(buf.Data, buf2.Data)
+		buf2 := &mem.Buf{Data: nil}
+		udata, err := xzlib.Decompress(buf.Data)
 		buf.Release()
 		if err != nil {
-			buf2.Release()
 			return nil, 0, fmt.Errorf("data corrupt: %v", err)
 		}
 		buf2.Data = udata

go/neo/internal/xzlib/xzlib.go

@@ -65,12 +65,9 @@ func Compress(data []byte) (zdata []byte) {
 
 // Decompress decompresses data according to zlib encoding.
 //
-// out buffer, if there is enough capacity, is used for decompression destination.
-// if out has not enough capacity a new buffer is allocated and used.
-//
 // return: destination buffer with full decompressed data or error.
-func Decompress(in []byte, out []byte) (data []byte, err error) {
-	return czlib.Decompress(in)
+func Decompress(zdata []byte) (data []byte, err error) {
+	return czlib.Decompress(zdata)
 }
 
 /*

go/neo/internal/xzlib/xzlib_test.go

@@ -38,7 +38,7 @@ var ztestv = []struct{in, out string}{
 
 func TestDecompress(t *testing.T) {
 	for _, tt := range ztestv {
-		got, err := Decompress([]byte(tt.in), nil)
+		got, err := Decompress([]byte(tt.in))
 		if err != nil {
 			t.Errorf("decompress err: %q", tt.in)
 			continue

go/neo/storage.go

@@ -471,6 +471,8 @@ func (stor *Storage) serveLink(ctx context.Context, req *neonet.Request, idReq *
 			return err
 		}
 
+		// XXX this go + link.Recv1() in serveClient arrange for N(goroutine) ↑
+		// with O(1/nreq) rate (i.e. N(goroutine, nreq) ~ ln(nreq)).
 		wg.Add(1)
 		go func() {
 			defer wg.Done()

go/neo/t/tcpu.go

@@ -109,7 +109,7 @@ func BenchmarkUnzlib(b *testing.B, zfile string) {
 	b.ResetTimer()
 
 	for i := 0; i < b.N; i++ {
-		_, err := xzlib.Decompress(zdata, nil)
+		_, err := xzlib.Decompress(zdata)
 		if err != nil {
 			b.Fatal(err)
 		}