From 4abed91a5fe0f56f655b34afd750dd1b1679cb35 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=A9rome=20Perrin?= <jerome@nexedi.com> Date: Wed, 9 Dec 2020 05:32:47 +0100 Subject: [PATCH] CodingStyle: allow more prefixes Probably we should be using interfaces instead, let's do this simple way first and we'll improve later. --- product/ERP5Type/CodingStyle.py | 40 +++++++++++++-------------------- 1 file changed, 16 insertions(+), 24 deletions(-) diff --git a/product/ERP5Type/CodingStyle.py b/product/ERP5Type/CodingStyle.py index bdaeff9fdf..b91cadd081 100644 --- a/product/ERP5Type/CodingStyle.py +++ b/product/ERP5Type/CodingStyle.py @@ -63,19 +63,32 @@ def getSkinPrefixList(self): # Add other prefix skin_prefix_list.extend(( 'ERP5Type', + + # Modules (maybe should be interfaces) 'Module', - + 'InventoryModule', + 'OrderModule', + 'DeliveryModule', + 'PackingListModule', + 'SupplyModule', + 'ResourceModule', + + # Base classes (maybe should be interfaces) + 'Entity', # A base class for Person / Organisation + 'PackingListLine', + 'IndividualVariation', + 'ExternalLogin', + # Catalog brains 'Brain', 'InventoryListBrain', 'TrackingListBrain', 'MovementHistoryListBrain', + # Zope classes 'DCWorkflow', # some workflow script use this, not sure it's correct. 'SkinsTool', 'MailHost', - - 'Entity', # A base class for Person / Organisation 'Zuite', # Products.Zelenium test suites # ERP5Form @@ -123,26 +136,7 @@ ignored_skin_id_set = { 'resolveUid', 'IndividualVariation_init', 'QuantityUnitConversion_getQuantityUnitList', - 'ResourceModule_getSelection', - 'DeliveryModule_getDeliveryLineList', - 'DeliveryModule_getDeliveryLineReportSectionList', - 'DeliveryModule_getMovementPortalTypeItemList', - 'DeliveryModule_getShipmentDeliveryList', - 'DeliveryModule_getShipmentLineData', - 'DeliveryModule_getShipmentLineList', - 'DeliveryModule_getShipmentReportSectionList', - 'OrderModule_activateGetOrderStatList', - 'OrderModule_deleteAutoPlannedOrderList', - 'OrderModule_filterOrderStatResul', - 'OrderModule_getOrderReport', - 'OrderModule_getOrderReportParameterDict', - 'OrderModule_getOrderReportSectionList', - 'OrderModule_getOrderStatList', - 'OrderModule_launchOrderReport', - 'OrderModule_processOrderStat', - 'OrderModule_statOrderStatList', 'PackingListContent_updateAfterEdit', - 'PackingListModule_getPackingListReport', 'Builder_selectAutoPlannedOrderList', 'Builder_updateManufacturingOrderAfterBuild', 'ManufacturingOrderBuilder_selectSimulationMovement', @@ -169,8 +163,6 @@ ignored_skin_id_set = { 'SaleInvoiceTransaction_selectTaskReportMovement', 'TaskListOverviewGadget_setPreferences', 'TaskListsGadgetListbox_getLineCss', - 'InventoryModule_reindexMovementList', - 'DeliveryModule_mergeDeliveryList', 'ERP5VCS_doCreateJavaScriptDiff.js', 'ERP5VCS_doCreateJavaScriptStatus.js', 'PdmZuite_CommonTemplate', -- 2.30.9