branches_spec.rb 6.54 KB
Newer Older
1 2 3
require 'spec_helper'
require 'mime/types'

Jeroen van Baarsen's avatar
Jeroen van Baarsen committed
4
describe API::API, api: true  do
5 6 7 8 9
  include ApiHelpers

  let(:user) { create(:user) }
  let(:user2) { create(:user) }
  let!(:project) { create(:project, creator_id: user.id) }
10 11
  let!(:master) { create(:project_member, user: user, project: project, access_level: ProjectMember::MASTER) }
  let!(:guest) { create(:project_member, user: user2, project: project, access_level: ProjectMember::GUEST) }
Dmitriy Zaporozhets's avatar
Dmitriy Zaporozhets committed
12 13
  let!(:branch_name) { 'feature' }
  let!(:branch_sha) { '0b4bc9a49b562e85de7cc9e834518ea6828729b9' }
14 15 16

  describe "GET /projects/:id/repository/branches" do
    it "should return an array of project branches" do
17 18
      project.repository.expire_cache

19
      get api("/projects/#{project.id}/repository/branches", user)
20 21
      expect(response.status).to eq(200)
      expect(json_response).to be_an Array
22 23
      branch_names = json_response.map { |x| x['name'] }
      expect(branch_names).to match_array(project.repository.branch_names)
24 25 26 27 28
    end
  end

  describe "GET /projects/:id/repository/branches/:branch" do
    it "should return the branch information for a single branch" do
Dmitriy Zaporozhets's avatar
Dmitriy Zaporozhets committed
29
      get api("/projects/#{project.id}/repository/branches/#{branch_name}", user)
30
      expect(response.status).to eq(200)
31

32 33 34
      expect(json_response['name']).to eq(branch_name)
      expect(json_response['commit']['id']).to eq(branch_sha)
      expect(json_response['protected']).to eq(false)
35 36 37 38
    end

    it "should return a 403 error if guest" do
      get api("/projects/#{project.id}/repository/branches", user2)
39
      expect(response.status).to eq(403)
40 41 42 43
    end

    it "should return a 404 error if branch is not available" do
      get api("/projects/#{project.id}/repository/branches/unknown", user)
44
      expect(response.status).to eq(404)
45 46 47 48 49
    end
  end

  describe "PUT /projects/:id/repository/branches/:branch/protect" do
    it "should protect a single branch" do
Dmitriy Zaporozhets's avatar
Dmitriy Zaporozhets committed
50
      put api("/projects/#{project.id}/repository/branches/#{branch_name}/protect", user)
51
      expect(response.status).to eq(200)
52

53 54 55
      expect(json_response['name']).to eq(branch_name)
      expect(json_response['commit']['id']).to eq(branch_sha)
      expect(json_response['protected']).to eq(true)
56 57 58 59
    end

    it "should return a 404 error if branch not found" do
      put api("/projects/#{project.id}/repository/branches/unknown/protect", user)
60
      expect(response.status).to eq(404)
61 62 63
    end

    it "should return a 403 error if guest" do
Dmitriy Zaporozhets's avatar
Dmitriy Zaporozhets committed
64
      put api("/projects/#{project.id}/repository/branches/#{branch_name}/protect", user2)
65
      expect(response.status).to eq(403)
66 67 68
    end

    it "should return success when protect branch again" do
Dmitriy Zaporozhets's avatar
Dmitriy Zaporozhets committed
69 70
      put api("/projects/#{project.id}/repository/branches/#{branch_name}/protect", user)
      put api("/projects/#{project.id}/repository/branches/#{branch_name}/protect", user)
71
      expect(response.status).to eq(200)
72 73 74 75 76
    end
  end

  describe "PUT /projects/:id/repository/branches/:branch/unprotect" do
    it "should unprotect a single branch" do
Dmitriy Zaporozhets's avatar
Dmitriy Zaporozhets committed
77
      put api("/projects/#{project.id}/repository/branches/#{branch_name}/unprotect", user)
78
      expect(response.status).to eq(200)
79

80 81 82
      expect(json_response['name']).to eq(branch_name)
      expect(json_response['commit']['id']).to eq(branch_sha)
      expect(json_response['protected']).to eq(false)
83 84 85 86
    end

    it "should return success when unprotect branch" do
      put api("/projects/#{project.id}/repository/branches/unknown/unprotect", user)
87
      expect(response.status).to eq(404)
88 89 90
    end

    it "should return success when unprotect branch again" do
Dmitriy Zaporozhets's avatar
Dmitriy Zaporozhets committed
91 92
      put api("/projects/#{project.id}/repository/branches/#{branch_name}/unprotect", user)
      put api("/projects/#{project.id}/repository/branches/#{branch_name}/unprotect", user)
93
      expect(response.status).to eq(200)
94 95 96
    end
  end

Dmitriy Zaporozhets's avatar
Dmitriy Zaporozhets committed
97 98 99
  describe "POST /projects/:id/repository/branches" do
    it "should create a new branch" do
      post api("/projects/#{project.id}/repository/branches", user),
100 101
           branch_name: 'feature1',
           ref: branch_sha
Dmitriy Zaporozhets's avatar
Dmitriy Zaporozhets committed
102

103
      expect(response.status).to eq(201)
Dmitriy Zaporozhets's avatar
Dmitriy Zaporozhets committed
104

105 106
      expect(json_response['name']).to eq('feature1')
      expect(json_response['commit']['id']).to eq(branch_sha)
Dmitriy Zaporozhets's avatar
Dmitriy Zaporozhets committed
107 108 109 110
    end

    it "should deny for user without push access" do
      post api("/projects/#{project.id}/repository/branches", user2),
111 112
           branch_name: branch_name,
           ref: branch_sha
113
      expect(response.status).to eq(403)
Dmitriy Zaporozhets's avatar
Dmitriy Zaporozhets committed
114
    end
115 116 117 118 119

    it 'should return 400 if branch name is invalid' do
      post api("/projects/#{project.id}/repository/branches", user),
           branch_name: 'new design',
           ref: branch_sha
120
      expect(response.status).to eq(400)
Douglas Barbosa Alexandre's avatar
Douglas Barbosa Alexandre committed
121
      expect(json_response['message']).to eq('Branch name is invalid')
122 123 124 125 126 127
    end

    it 'should return 400 if branch already exists' do
      post api("/projects/#{project.id}/repository/branches", user),
           branch_name: 'new_design1',
           ref: branch_sha
128
      expect(response.status).to eq(201)
129 130 131 132

      post api("/projects/#{project.id}/repository/branches", user),
           branch_name: 'new_design1',
           ref: branch_sha
133 134
      expect(response.status).to eq(400)
      expect(json_response['message']).to eq('Branch already exists')
135 136 137 138 139 140
    end

    it 'should return 400 if ref name is invalid' do
      post api("/projects/#{project.id}/repository/branches", user),
           branch_name: 'new_design3',
           ref: 'foo'
141 142
      expect(response.status).to eq(400)
      expect(json_response['message']).to eq('Invalid reference name')
143
    end
Dmitriy Zaporozhets's avatar
Dmitriy Zaporozhets committed
144
  end
145 146

  describe "DELETE /projects/:id/repository/branches/:branch" do
147 148 149
    before do
      allow_any_instance_of(Repository).to receive(:rm_branch).and_return(true)
    end
150 151

    it "should remove branch" do
Dmitriy Zaporozhets's avatar
Dmitriy Zaporozhets committed
152
      delete api("/projects/#{project.id}/repository/branches/#{branch_name}", user)
153 154
      expect(response.status).to eq(200)
      expect(json_response['branch_name']).to eq(branch_name)
155 156
    end

157 158
    it 'should return 404 if branch not exists' do
      delete api("/projects/#{project.id}/repository/branches/foobar", user)
159
      expect(response.status).to eq(404)
160 161
    end

162
    it "should remove protected branch" do
Dmitriy Zaporozhets's avatar
Dmitriy Zaporozhets committed
163 164
      project.protected_branches.create(name: branch_name)
      delete api("/projects/#{project.id}/repository/branches/#{branch_name}", user)
165 166
      expect(response.status).to eq(405)
      expect(json_response['message']).to eq('Protected branch cant be removed')
167 168 169 170
    end

    it "should not remove HEAD branch" do
      delete api("/projects/#{project.id}/repository/branches/master", user)
171 172
      expect(response.status).to eq(405)
      expect(json_response['message']).to eq('Cannot remove HEAD branch')
173 174
    end
  end
175
end