Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Léo-Paul Géneau
gitlab-ce
Commits
0c6923e2
Commit
0c6923e2
authored
Apr 10, 2016
by
Robert Speicher
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Re-add a note about sarcasm to the Code Review guide
[ci skip]
parent
c7ec5929
Changes
1
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
3 additions
and
0 deletions
+3
-0
doc/development/code_review.md
doc/development/code_review.md
+3
-0
No files found.
doc/development/code_review.md
View file @
0c6923e2
...
@@ -25,6 +25,9 @@ request is up to one of our merge request "endbosses", denoted on the
...
@@ -25,6 +25,9 @@ request is up to one of our merge request "endbosses", denoted on the
-
Be explicit. Remember people don't always understand your intentions online.
-
Be explicit. Remember people don't always understand your intentions online.
-
Be humble. ("I'm not sure - let's look it up.")
-
Be humble. ("I'm not sure - let's look it up.")
-
Don't use hyperbole. ("always", "never", "endlessly", "nothing")
-
Don't use hyperbole. ("always", "never", "endlessly", "nothing")
-
Be careful about the use of sarcasm. Everything we do is public; what seems
like good-natured ribbing to you and a long-time colleague might come off as
mean and unwelcoming to a person new to the project.
-
Consider one-on-one chats or video calls if there are too many "I didn't
-
Consider one-on-one chats or video calls if there are too many "I didn't
understand" or "Alternative solution:" comments. Post a follow-up comment
understand" or "Alternative solution:" comments. Post a follow-up comment
summarizing one-on-one discussion.
summarizing one-on-one discussion.
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment