Fixed test turbolink condition

app/assets/javascripts/gl_dropdown.js.coffee

@@ -307,7 +307,7 @@ class GitLabDropdown
 
   shouldPropagate: (e) =>
     $target = $(e.target) if @options.multiSelect
-    unless $target.hasClass('dropdown-menu-close') and $target.hasClass('dropdown-menu-close-icon') and $target.data('is-link')
+    if $target and not $target.hasClass('dropdown-menu-close') and not $target.hasClass('dropdown-menu-close-icon') and not $target.data('is-link')
       e.stopPropagation()
       false
     else
@@ -380,10 +380,10 @@ class GitLabDropdown
     html = ''
 
     # Divider
-    return '<li class='divider'></li>' if data is 'divider'
+    return '<li class="divider"></li>' if data is 'divider'
 
     # Separator is a full-width divider
-    return '<li class='separator'></li>' if data is 'separator'
+    return '<li class="separator"></li>' if data is 'separator'
 
     # Header
     return _.template('<li class="dropdown-header"><%- header %></li>')({ header: data.header }) if data.header?

spec/javascripts/gl_dropdown_spec.js.coffee

@@ -81,11 +81,12 @@ describe 'Dropdown', ->
       navigateWithKeys 'down', randomIndex, =>
         spyOn(Turbolinks, 'visit').and.stub()
         navigateWithKeys 'enter', null, =>
+          expect(@dropdownContainerElement).not.toHaveClass 'open'
           link = $("#{ITEM_SELECTOR}:eq(#{randomIndex}) a", @dropdownMenuElement)
           expect(link).toHaveClass 'is-active'
-          if link.attr 'href'
-            expect(Turbolinks.visit).toHaveBeenCalledWith link.attr 'href'
-            expect(@dropdownContainerElement).not.toHaveClass 'open'
+          linkedLocation = link.attr 'href'
+          if linkedLocation and linkedLocation isnt '#'
+            expect(Turbolinks.visit).toHaveBeenCalledWith linkedLocation
 
     it 'should close on ESC keypress', ->
       expect(@dropdownContainerElement).toHaveClass 'open'