Commit 1bf6697c authored by Grzegorz Bizon's avatar Grzegorz Bizon

Merge branch '51225-fix-artifact-tests-in-jobs_controller_spec' into 'master'

Check if key is present with string not symbol

Closes #51225

See merge request gitlab-org/gitlab-ce!21589
parents 44cb8a74 8ffc7070
...@@ -166,8 +166,8 @@ describe Projects::JobsController, :clean_gitlab_redis_shared_state do ...@@ -166,8 +166,8 @@ describe Projects::JobsController, :clean_gitlab_redis_shared_state do
expect(response).to match_response_schema('job/job_details') expect(response).to match_response_schema('job/job_details')
expect(json_response['artifact']['download_path']).to match(%r{artifacts/download}) expect(json_response['artifact']['download_path']).to match(%r{artifacts/download})
expect(json_response['artifact']['browse_path']).to match(%r{artifacts/browse}) expect(json_response['artifact']['browse_path']).to match(%r{artifacts/browse})
expect(json_response['artifact']).not_to have_key(:expired) expect(json_response['artifact']).not_to have_key('expired')
expect(json_response['artifact']).not_to have_key(:expired_at) expect(json_response['artifact']).not_to have_key('expired_at')
end end
end end
...@@ -177,8 +177,8 @@ describe Projects::JobsController, :clean_gitlab_redis_shared_state do ...@@ -177,8 +177,8 @@ describe Projects::JobsController, :clean_gitlab_redis_shared_state do
it 'exposes needed information' do it 'exposes needed information' do
expect(response).to have_gitlab_http_status(:ok) expect(response).to have_gitlab_http_status(:ok)
expect(response).to match_response_schema('job/job_details') expect(response).to match_response_schema('job/job_details')
expect(json_response['artifact']).not_to have_key(:download_path) expect(json_response['artifact']).not_to have_key('download_path')
expect(json_response['artifact']).not_to have_key(:browse_path) expect(json_response['artifact']).not_to have_key('browse_path')
expect(json_response['artifact']['expired']).to eq(true) expect(json_response['artifact']['expired']).to eq(true)
expect(json_response['artifact']['expire_at']).not_to be_empty expect(json_response['artifact']['expire_at']).not_to be_empty
end end
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment