Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Léo-Paul Géneau
gitlab-ce
Commits
25283e71
Commit
25283e71
authored
Feb 28, 2018
by
Connor Shea
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Update inline_javascript.rb to lint uses of the javascript filter as well as script tags.
parent
83b3e9fa
Changes
1
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
7 additions
and
1 deletion
+7
-1
lib/haml_lint/inline_javascript.rb
lib/haml_lint/inline_javascript.rb
+7
-1
No files found.
lib/haml_lint/inline_javascript.rb
View file @
25283e71
...
@@ -7,6 +7,12 @@ unless Rails.env.production?
...
@@ -7,6 +7,12 @@ unless Rails.env.production?
class
Linter::InlineJavaScript
<
Linter
class
Linter::InlineJavaScript
<
Linter
include
LinterRegistry
include
LinterRegistry
def
visit_filter
(
node
)
return
unless
node
.
filter_type
==
'javascript'
record_lint
(
node
,
'Inline JavaScript is discouraged (https://docs.gitlab.com/ee/development/gotchas.html#do-not-use-inline-javascript-in-views)'
)
end
def
visit_tag
(
node
)
def
visit_tag
(
node
)
return
unless
node
.
tag_name
==
'script'
return
unless
node
.
tag_name
==
'script'
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment