Just don't expand if it's already expanded

253c2a36 · Lin Jen-Shin · ae7b176a · 253c2a36
Commit 253c2a36 authored Jan 26, 2018 by Lin Jen-Shin
Show whitespace changes
Inline Side-by-side

Showing with 2 additions and 4 deletions

qa/qa/page/project/settings/common.rb qa/qa/page/project/settings/common.rb +2 -4

No files found.
--- a/qa/qa/page/project/settings/common.rb
+++ b/qa/qa/page/project/settings/common.rb
@@ -14,11 +14,9 @@ module QA
          def expand_section(name)
            page.within('#content-body') do
              page.within('section', text: name) do
-                click_button 'Expand'
+                click_button 'Expand' unless first('button', text: 'Collapse')
-                yield.tap do
+                yield
-                  click_button 'Collapse' if first('button', text: 'Collapse')
-                end
              end
            end
          end