Improve pipeline expressions specs and freeze constants

lib/gitlab/ci/pipeline/expression/lexer.rb

@@ -7,7 +7,7 @@ module Gitlab
             Expression::Variable,
             Expression::String,
             Expression::Equals
-          ]
+          ].freeze
 
           MAX_CYCLES = 5
           SyntaxError = Class.new(StandardError)

lib/gitlab/ci/pipeline/expression/statement.rb

@@ -12,7 +12,7 @@ module Gitlab
             %w[string equals variable],
             %w[null equals variable],
             %w[variable]
-          ]
+          ].freeze
 
           def initialize(statement, pipeline)
             @pipeline = pipeline

spec/lib/gitlab/ci/pipeline/expression/statement_spec.rb

@@ -29,12 +29,23 @@ describe Gitlab::Ci::Pipeline::Expression::Statement do
     end
 
     context 'when expression grammar is correct' do
+      context 'when using an operator' do
         let(:text) { '$VAR == "value"' }
 
-      it 'returns a reverse descent parse tree when using operator' do
+        it 'returns a reverse descent parse tree' do
           expect(subject.parse_tree)
             .to be_a Gitlab::Ci::Pipeline::Expression::Equals
         end
       end
+
+      context 'when using a single token' do
+        let(:text) { '$VARIABLE' }
+
+        it 'returns a single token instance' do
+          expect(subject.parse_tree)
+            .to be_a Gitlab::Ci::Pipeline::Expression::Variable
+        end
+      end
+    end
   end
 end