Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Léo-Paul Géneau
gitlab-ce
Commits
365cdd8f
Commit
365cdd8f
authored
Dec 22, 2016
by
Lin Jen-Shin
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Make successful pipeline emails off for watchers
Closes #24845
parent
91e56012
Changes
3
Show whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
10 additions
and
2 deletions
+10
-2
app/services/notification_service.rb
app/services/notification_service.rb
+5
-1
changelogs/unreleased/remove-successful-pipeline-emails-for-now.yml
.../unreleased/remove-successful-pipeline-emails-for-now.yml
+4
-0
doc/workflow/notifications.md
doc/workflow/notifications.md
+1
-1
No files found.
app/services/notification_service.rb
View file @
365cdd8f
...
@@ -591,7 +591,11 @@ class NotificationService
...
@@ -591,7 +591,11 @@ class NotificationService
custom_action
=
build_custom_key
(
action
,
target
)
custom_action
=
build_custom_key
(
action
,
target
)
recipients
=
target
.
participants
(
current_user
)
recipients
=
target
.
participants
(
current_user
)
# TODO: CLEAN ME UP!
unless
custom_action
==
:success_pipeline
recipients
=
add_project_watchers
(
recipients
,
project
)
recipients
=
add_project_watchers
(
recipients
,
project
)
end
recipients
=
add_custom_notifications
(
recipients
,
project
,
custom_action
)
recipients
=
add_custom_notifications
(
recipients
,
project
,
custom_action
)
recipients
=
reject_mention_users
(
recipients
,
project
)
recipients
=
reject_mention_users
(
recipients
,
project
)
...
...
changelogs/unreleased/remove-successful-pipeline-emails-for-now.yml
0 → 100644
View file @
365cdd8f
---
title
:
Make successful pipeline emails off for watchers
merge_request
:
8176
author
:
doc/workflow/notifications.md
View file @
365cdd8f
...
@@ -73,7 +73,7 @@ In all of the below cases, the notification will be sent to:
...
@@ -73,7 +73,7 @@ In all of the below cases, the notification will be sent to:
...with notification level "Participating" or higher
...with notification level "Participating" or higher
-
Watchers: users with notification level "Watch"
-
Watchers: users with notification level "Watch"
(however successful pipeline would be off for watchers)
-
Subscribers: anyone who manually subscribed to the issue/merge request
-
Subscribers: anyone who manually subscribed to the issue/merge request
-
Custom: Users with notification level "custom" who turned on notifications for any of the events present in the table below
-
Custom: Users with notification level "custom" who turned on notifications for any of the events present in the table below
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment