Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Léo-Paul Géneau
gitlab-ce
Commits
67b06e7a
Commit
67b06e7a
authored
Sep 29, 2014
by
Ciro Santilli
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Change always passing visible true tests to false.
parent
ac158424
Changes
4
Show whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
3 additions
and
14 deletions
+3
-14
features/project/commits/comments.feature
features/project/commits/comments.feature
+0
-5
features/project/commits/diff_comments.feature
features/project/commits/diff_comments.feature
+0
-6
features/steps/shared/diff_note.rb
features/steps/shared/diff_note.rb
+2
-2
features/steps/shared/note.rb
features/steps/shared/note.rb
+1
-1
No files found.
features/project/commits/comments.feature
View file @
67b06e7a
...
@@ -13,11 +13,6 @@ Feature: Project Commits Comments
...
@@ -13,11 +13,6 @@ Feature: Project Commits Comments
Scenario
:
I
can't cancel the main form
Scenario
:
I
can't cancel the main form
Then
I should not see the cancel comment button
Then
I should not see the cancel comment button
@javascript
Scenario
:
I
can't preview without text
Given
I haven't written any comment text
Then
The comment preview tab should say there is nothing to do
@javascript
@javascript
Scenario
:
I
can preview with text
Scenario
:
I
can preview with text
Given I write a comment like "
:
+1
:
Nice"
Given I write a comment like "
:
+1
:
Nice"
...
...
features/project/commits/diff_comments.feature
View file @
67b06e7a
...
@@ -54,12 +54,6 @@ Feature: Project Commits Diff Comments
...
@@ -54,12 +54,6 @@ Feature: Project Commits Diff Comments
Given
I leave a diff comment like
"Typo, please fix"
Given
I leave a diff comment like
"Typo, please fix"
Then
I should see a discussion reply button
Then
I should see a discussion reply button
@javascript
Scenario
:
I
can't preview without text
Given
I open a diff comment form
And
I haven't written any diff comment text
Then
The diff comment preview tab should say there is nothing to do
@javascript
@javascript
Scenario
:
I
can preview with text
Scenario
:
I
can preview with text
Given
I open a diff comment form
Given
I open a diff comment form
...
...
features/steps/shared/diff_note.rb
View file @
67b06e7a
...
@@ -80,7 +80,7 @@ module SharedDiffNote
...
@@ -80,7 +80,7 @@ module SharedDiffNote
step
'I should not see the diff comment text field'
do
step
'I should not see the diff comment text field'
do
within
(
diff_file_selector
)
do
within
(
diff_file_selector
)
do
page
.
should
have_css
(
".js-note-text"
,
visible:
false
)
expect
(
find
(
'.js-note-text'
)).
not_to
be_visible
end
end
end
end
...
@@ -115,7 +115,7 @@ module SharedDiffNote
...
@@ -115,7 +115,7 @@ module SharedDiffNote
end
end
step
'I should see add a diff comment button'
do
step
'I should see add a diff comment button'
do
page
.
should
have_css
(
".js-add-diff-note-button"
,
visible:
fals
e
)
page
.
should
have_css
(
'.js-add-diff-note-button'
,
visible:
tru
e
)
end
end
step
'I should see an empty diff comment form'
do
step
'I should see an empty diff comment form'
do
...
...
features/steps/shared/note.rb
View file @
67b06e7a
...
@@ -64,7 +64,7 @@ module SharedNote
...
@@ -64,7 +64,7 @@ module SharedNote
step
'I should not see the comment text field'
do
step
'I should not see the comment text field'
do
within
(
".js-main-target-form"
)
do
within
(
".js-main-target-form"
)
do
page
.
should
have_css
(
".js-note-text"
,
visible:
false
)
expect
(
find
(
'.js-note-text'
)).
not_to
be_visible
end
end
end
end
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment