Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Léo-Paul Géneau
gitlab-ce
Commits
aebee118
Commit
aebee118
authored
Dec 12, 2016
by
Clement Ho
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix bug where labels with spaces weren't being escaped when selected
parent
5589ab1e
Changes
1
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
2 additions
and
2 deletions
+2
-2
app/assets/javascripts/filtered_search/dropdown_non_user.js.es6
...sets/javascripts/filtered_search/dropdown_non_user.js.es6
+2
-2
No files found.
app/assets/javascripts/filtered_search/dropdown_non_user.js.es6
View file @
aebee118
...
@@ -29,7 +29,6 @@
...
@@ -29,7 +29,6 @@
let escapedText = text;
let escapedText = text;
const hasSpace = text.indexOf(' ') !== -1;
const hasSpace = text.indexOf(' ') !== -1;
const hasDoubleQuote = text.indexOf('"') !== -1;
const hasDoubleQuote = text.indexOf('"') !== -1;
const hasSingleQuote = text.indexOf('\'') !== -1;
// Encapsulate value with quotes if it has spaces
// Encapsulate value with quotes if it has spaces
// Known side effect: values's with both single and double quotes
// Known side effect: values's with both single and double quotes
...
@@ -37,7 +36,8 @@
...
@@ -37,7 +36,8 @@
if (hasSpace) {
if (hasSpace) {
if (hasDoubleQuote) {
if (hasDoubleQuote) {
escapedText = `'${text}'`;
escapedText = `'${text}'`;
} else if (hasSingleQuote) {
} else {
// Encapsulate singleQuotes or if it hasSpace
escapedText = `"${text}"`;
escapedText = `"${text}"`;
}
}
}
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment