Only trigger loadCheck on open toggle, not close. Update specs and add...

Only trigger loadCheck on open toggle, not close. Update specs and add right_sidebar_spec test for additions

app/assets/javascripts/issuable_context.js

@@ -67,13 +67,13 @@ const PARTICIPANTS_ROW_COUNT = 7;
       originalText = $(this).data("original-text");
       if (currentText === originalText) {
         $(this).text(lessText);
+
+        if (gl.lazyLoader) gl.lazyLoader.loadCheck();
       } else {
         $(this).text(originalText);
       }
 
       $(".js-participants-hidden").toggle();
-
-      if (gl.lazyLoader) gl.lazyLoader.loadCheck();
     };
 
     return IssuableContext;

app/assets/javascripts/right_sidebar.js

@@ -29,7 +29,11 @@ import Cookies from 'js-cookie';
       $('.dropdown').on('loading.gl.dropdown', this.sidebarDropdownLoading);
       $('.dropdown').on('loaded.gl.dropdown', this.sidebarDropdownLoaded);
 
-      $document.on('click', '.js-sidebar-toggle', function(e, triggered) {
+      $document.on('click', '.js-sidebar-toggle', this.sidebarToggleClicked);
+      return $(document).off('click', '.js-issuable-todo').on('click', '.js-issuable-todo', this.toggleTodo);
+    };
+
+    Sidebar.prototype.sidebarToggleClicked = function (e, triggered) {
       var $allGutterToggleIcons, $this, $thisIcon;
       e.preventDefault();
       $this = $(this);
@@ -43,13 +47,12 @@ import Cookies from 'js-cookie';
         $allGutterToggleIcons.removeClass('fa-angle-double-left').addClass('fa-angle-double-right');
         $('aside.right-sidebar').removeClass('right-sidebar-collapsed').addClass('right-sidebar-expanded');
         $('.page-with-sidebar').removeClass('right-sidebar-collapsed').addClass('right-sidebar-expanded');
+
+        if (gl.lazyLoader) gl.lazyLoader.loadCheck();
       }
       if (!triggered) {
         Cookies.set("collapsed_gutter", $('.right-sidebar').hasClass('right-sidebar-collapsed'));
       }
-        if (gl.lazyLoader) gl.lazyLoader.loadCheck();
-      });
-      return $(document).off('click', '.js-issuable-todo').on('click', '.js-issuable-todo', this.toggleTodo);
     };
 
     Sidebar.prototype.toggleTodo = function(e) {

spec/javascripts/issuable_context_spec.js

 /* global IssuableContext */
 import '~/issuable_context';
+import $ from 'jquery';
 
 describe('IssuableContext', () => {
   describe('toggleHiddenParticipants', () => {
     const event = jasmine.createSpyObj('event', ['preventDefault']);
 
+    beforeEach(() => {
+      spyOn($.fn, 'data').and.returnValue('data');
+      spyOn($.fn, 'text').and.returnValue('data');
+    });
+
     afterEach(() => {
       gl.lazyLoader = undefined;
     });

spec/javascripts/right_sidebar_spec.js

@@ -32,6 +32,7 @@ import '~/right_sidebar';
   };
 
   describe('RightSidebar', function() {
+    describe('fixture tests', () => {
       var fixtureName = 'issues/open-issue.html.raw';
       preloadFixtures(fixtureName);
       loadJSONFixtures('todos/todos.json');
@@ -85,4 +86,33 @@ import '~/right_sidebar';
         });
       });
     });
+
+    describe('sidebarToggleClicked', () => {
+      const event = jasmine.createSpyObj('event', ['preventDefault']);
+
+      beforeEach(() => {
+        spyOn($.fn, 'hasClass').and.returnValue(false);
+      });
+
+      afterEach(() => {
+        gl.lazyLoader = undefined;
+      });
+
+      it('calls loadCheck if lazyLoader is set', () => {
+        gl.lazyLoader = jasmine.createSpyObj('lazyLoader', ['loadCheck']);
+
+        Sidebar.prototype.sidebarToggleClicked(event);
+
+        expect(gl.lazyLoader.loadCheck).toHaveBeenCalled();
+      });
+
+      it('does not throw if lazyLoader is not defined', () => {
+        gl.lazyLoader = undefined;
+
+        const toggle = Sidebar.prototype.sidebarToggleClicked.bind(null, event);
+
+        expect(toggle).not.toThrow();
+      });
+    });
+  });
 }).call(window);