IssueNotesRefactor: Make scroll into note an action.

app/assets/javascripts/notes/components/issue_notes.vue

@@ -94,12 +94,8 @@ export default {
       const $el = $(`#${hash}`);
 
       if (hash && $el) {
-        const isInViewport = gl.utils.isInViewport($el[0]);
         this.$store.commit('setTargetNoteHash', hash);
-
-        if (!isInViewport) {
-          gl.utils.scrollToElement($el);
-        }
+        this.$store.dispatch('scrollToNoteIfNeeded', $el);
       }
     },
   },

app/assets/javascripts/notes/stores/issue_notes_store.js

@@ -214,6 +214,13 @@ const actions = {
         }
       });
   },
+  scrollToNoteIfNeeded(context, el) {
+    const isInViewport = gl.utils.isInViewport(el[0]);
+
+    if (!isInViewport) {
+      gl.utils.scrollToElement(el);
+    }
+  },
 };
 
 export default {