Use constraint for #validation

d48658e3 · Shinya Maeda · 13bac4c2 · d48658e3
Commit d48658e3 authored Mar 30, 2017 by Shinya Maeda
Show whitespace changes
Inline Side-by-side

Showing with 4 additions and 2 deletions

lib/ci/cron_parser.rb lib/ci/cron_parser.rb +4 -2

No files found.
--- a/lib/ci/cron_parser.rb
+++ b/lib/ci/cron_parser.rb
@@ -12,8 +12,10 @@ module Ci
    end

    def validation
-      is_valid_cron = try_parse_cron(@cron, 'Europe/Istanbul').present?
-      is_valid_cron_time_zone = try_parse_cron('* * * * *', @cron_time_zone).present?
+      VALID_SYNTAX_TIME_ZONE = 'Europe/Istanbul'
+      VALID_SYNTAX_CRON = '* * * * *'
+      is_valid_cron = try_parse_cron(@cron, VALID_SYNTAX_TIME_ZONE).present?
+      is_valid_cron_time_zone = try_parse_cron(VALID_SYNTAX_CRON, @cron_time_zone).present?
      return is_valid_cron, is_valid_cron_time_zone
    end