Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Léo-Paul Géneau
gitlab-ce
Commits
eabe1680
Commit
eabe1680
authored
Jun 28, 2018
by
Clement Ho
Committed by
Mike Greiling
Jun 28, 2018
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Resolve "Sidebar on jobs and wikis is missing at small widths"
parent
763e6549
Changes
3
Show whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
7 additions
and
2 deletions
+7
-2
app/assets/javascripts/job.js
app/assets/javascripts/job.js
+1
-1
app/assets/javascripts/pages/projects/wikis/wikis.js
app/assets/javascripts/pages/projects/wikis/wikis.js
+1
-1
changelogs/unreleased/48471-sidebar-on-jobs-and-wikis-is-missing-at-small-widths.yml
...-sidebar-on-jobs-and-wikis-is-missing-at-small-widths.yml
+5
-0
No files found.
app/assets/javascripts/job.js
View file @
eabe1680
...
@@ -164,7 +164,7 @@ export default class Job extends LogOutputBehaviours {
...
@@ -164,7 +164,7 @@ export default class Job extends LogOutputBehaviours {
// eslint-disable-next-line class-methods-use-this
// eslint-disable-next-line class-methods-use-this
shouldHideSidebarForViewport
()
{
shouldHideSidebarForViewport
()
{
const
bootstrapBreakpoint
=
bp
.
getBreakpointSize
();
const
bootstrapBreakpoint
=
bp
.
getBreakpointSize
();
return
bootstrapBreakpoint
===
'
xs
'
||
bootstrapBreakpoint
===
'
sm
'
;
return
bootstrapBreakpoint
===
'
xs
'
;
}
}
toggleSidebar
(
shouldHide
)
{
toggleSidebar
(
shouldHide
)
{
...
...
app/assets/javascripts/pages/projects/wikis/wikis.js
View file @
eabe1680
...
@@ -48,7 +48,7 @@ export default class Wikis {
...
@@ -48,7 +48,7 @@ export default class Wikis {
static
sidebarCanCollapse
()
{
static
sidebarCanCollapse
()
{
const
bootstrapBreakpoint
=
bp
.
getBreakpointSize
();
const
bootstrapBreakpoint
=
bp
.
getBreakpointSize
();
return
bootstrapBreakpoint
===
'
xs
'
||
bootstrapBreakpoint
===
'
sm
'
;
return
bootstrapBreakpoint
===
'
xs
'
;
}
}
renderSidebar
()
{
renderSidebar
()
{
...
...
changelogs/unreleased/48471-sidebar-on-jobs-and-wikis-is-missing-at-small-widths.yml
0 → 100644
View file @
eabe1680
---
title
:
Fix sidebar collapse breapoints for job and wiki pages
merge_request
:
author
:
type
:
fixed
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment