Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Léo-Paul Géneau
gitlab-ce
Commits
fac3c917
Commit
fac3c917
authored
Jul 31, 2017
by
Clement Ho
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Add specific code review guidelines
parent
da967803
Changes
1
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
8 additions
and
0 deletions
+8
-0
doc/development/code_review.md
doc/development/code_review.md
+8
-0
No files found.
doc/development/code_review.md
View file @
fac3c917
...
@@ -9,8 +9,16 @@ There are a few rules to get your merge request accepted:
...
@@ -9,8 +9,16 @@ There are a few rules to get your merge request accepted:
**approved by a [backend maintainer][projects]**
.
**approved by a [backend maintainer][projects]**
.
1.
If your merge request includes only frontend changes [^1], it must be
1.
If your merge request includes only frontend changes [^1], it must be
**approved by a [frontend maintainer][projects]**
.
**approved by a [frontend maintainer][projects]**
.
1.
If your merge request includes UX changes [^1], it must
be
**approved by a [UX team member][team]**
.
1.
If your merge request includes adding a new JavaScript library [^1], it must be
**approved by a [frontend lead][team]**
.
1.
If your merge request includes frontend and backend changes [^1], it must
1.
If your merge request includes frontend and backend changes [^1], it must
be
**approved by a [frontend and a backend maintainer][projects]**
.
be
**approved by a [frontend and a backend maintainer][projects]**
.
1.
If your merge request includes UX and frontend changes [^1], it must
be
**approved by a [UX team member and a frontend maintainer][team]**
.
1.
If your merge request includes UX, frontend and backend changes [^1], it must
be
**approved by a [UX team member, a frontend and a backend maintainer][team]**
.
1.
To lower the amount of merge requests maintainers need to review, you can
1.
To lower the amount of merge requests maintainers need to review, you can
ask or assign any
[
reviewers
][
projects
]
for a first review.
ask or assign any
[
reviewers
][
projects
]
for a first review.
1.
If you need some guidance (e.g. it's your first merge request), feel free
1.
If you need some guidance (e.g. it's your first merge request), feel free
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment