XXX: Fix unique_by_network support to be more specific

stack/resilient/buildout.hash.cfg

@@ -30,7 +30,7 @@ md5sum = 1b8645835f04081861266436505fd28f
 
 [template-replicated]
 filename = template-replicated.cfg.in
-md5sum = 52762882e0d631f51d2c9e5f8b31c0b6
+md5sum = 67c863b15dbfa937babdbd620f95c1ff
 
 [template-parts]
 filename = template-parts.cfg.in

stack/resilient/template-replicated.cfg.in

@@ -48,9 +48,6 @@ config-{{ parameter_name }} = {{ dumps(parameter_value) }}
 {% for key, value in six.iteritems(monitor_dict) -%}
 config-{{ key }} = {{ value }}
 {% endfor -%}
-{% if sla_parameter_dict == {} -%}
-sla-mode = unique_by_network
-{% else %}
 {% set sla_key_main = "-sla-%s%s-" % (namebase, 0) -%}
 {% set sla_key_secondary = "-sla-%s-" % (0) -%}
 {% set sla_key_main_length = sla_key_main | length -%}
@@ -63,10 +60,13 @@ sla-mode = unique_by_network
 {%       do sla_dict.__setitem__(key[sla_key_secondary_length:], sla_parameter_dict.get(key)) -%}
 {%   endif -%}
 {% endfor -%}
+{% if sla_dict == {} %}
+sla-mode = unique_by_network
+{% else %}
 {%   for key, value in six.iteritems(sla_dict) -%}
 sla-{{ key }} = {{ value }}
-{%   endfor -%}
-{% endif -%}
+{%   endfor %}
+{% endif %}
 
 {% if 'monitor-base-url' in monitor_return and not monitor_parameter_dict.get('set-monitor-url', False) -%}
 {% do monitor_url_list.append('${request-' ~ namebase ~ ':connection-monitor-base-url}') -%}
@@ -100,9 +100,6 @@ config-on-notification = ${request-pbs-{{namebase}}-{{id}}:connection-feeds-url}
 {% for key, value in six.iteritems(monitor_dict) -%}
 config-{{ key }} = {{ value }}
 {% endfor -%}
-{% if sla_parameter_dict == {} -%}
-sla-mode = unique_by_network
-{% else %}
 {% set sla_key_main = "-sla-%s%s-" % (namebase, id) -%}
 {% set sla_key_secondary = "-sla-%s-" % (id) -%}
 {% set sla_key_main_length = sla_key_main | length -%}
@@ -115,9 +112,12 @@ sla-mode = unique_by_network
 {%       do sla_dict.__setitem__(key[sla_key_secondary_length:], sla_parameter_dict.get(key)) -%}
 {%   endif -%}
 {% endfor -%}
+{% if sla_dict == {} %}
+sla-mode = unique_by_network
+{% else %}
 {%   for key, value in six.iteritems(sla_dict) -%}
 sla-{{ key }} = {{ value }}
-{%   endfor -%}
+{%   endfor %}
 {% endif %}
 
 [publish-connection-information]
@@ -202,9 +202,6 @@ config-{{ key }} = {{ value }}
 {% endfor -%}
 return = ssh-key notification-url feeds-url  {{ monitor_return }}
 shared = false
-{% if sla_parameter_dict == {} -%}
-sla-mode = unique_by_network
-{% else %}
 {% set sla_key_main = "-sla-%s%s-" % ("pbs", id) -%}
 {% set sla_key_secondary = "-sla-%s-" % (id) -%}
 {% set sla_key_main_length = sla_key_main | length -%}
@@ -217,6 +214,9 @@ sla-mode = unique_by_network
 {%       do sla_dict.__setitem__(key[sla_key_secondary_length:], sla_parameter_dict.get(key)) -%}
 {%   endif -%}
 {% endfor -%}
+{% if sla_dict == {} %}
+sla-mode = unique_by_network
+{% else %}
 {%   for key, value in six.iteritems(sla_dict) -%}
 sla-{{ key }} = {{ value }}
 {%   endfor %}

[Thomas Gambier]

this has been committed in master as nexedi/slapos@9311f4f6