[kvm] use-tap is true by default

/cc @rafael @jm @alain.takoudjou 

Here we go

/reviewed-on nexedi/slapos!529

software/kvm/README.rst

@@ -59,8 +59,8 @@ KVM instance parameters:
     For port forwarding to IPv6 of slapos partition
 - use-nat (default: True)
     Add one interface using qemu User Network (NAT), this interface support nat-rules.
-- use-tap (default: False)
-    Add One interface that use tap interface
+- use-tap (default: True)
+    Add one interface that uses tap interface from the host
 - enable-vhost (default: False)
     Increase network speed by enabling vhost on qemu. (To use if the module is loaded on host machine)
 

software/kvm/buildout.hash.cfg

@@ -19,7 +19,7 @@ md5sum = 028b6a6456d744c11b1bb2c51ecd51b2
 
 [template-kvm]
 filename = instance-kvm.cfg.jinja2
-md5sum = c51026e815ca43b5de5ddc6cbd8bf1e2
+md5sum = c298aaa20a368ddc118b8bb22dc84dc3
 
 [template-kvm-cluster]
 filename = instance-kvm-cluster.cfg.jinja2.in

software/kvm/instance-kvm-input-schema.json

@@ -266,9 +266,9 @@
     },
     "use-tap": {
       "title": "Use QEMU TAP network interface",
-      "description": "Use QEMU TAP network interface, might require a bridge on SlapOS Node.",
+      "description": "Use QEMU TAP network interface, requires taps creation on SlapOS Node.",
       "type": "boolean",
-      "default": false
+      "default": true
     },
     "use-nat": {
       "title": "Use QEMU USER Mode interface (NAT)",
@@ -278,7 +278,7 @@
     },
     "nat-rules": {
       "title": "List of rules for NAT of QEMU user mode network stack.",
-      "description": "List of rules for NAT of QEMU user mode network stack, as space-separated list of ports (with optional protocol). For each port specified, it will redirect port x of the VM (example: \"80 udp:53\") to the port x + 10000 of the public IPv6 of the host (example: \"10080 udp:10053\"). Ignored if \"use-tap\" parameter is enabled.",
+      "description": "List of rules for NAT of QEMU user mode network stack, as space-separated list of ports (with optional protocol). For each port specified, it will redirect port x of the VM (example: \"80 udp:53\") to the port x + 10000 of the public IPv6 of the host (example: \"10080 udp:10053\").",
       "type": "string",
       "default": "22 80 443"
     },

software/kvm/instance-kvm.cfg.jinja2

 {% set enable_http = slapparameter_dict.get('enable-http-server', 'False').lower() -%}
-{% set use_tap = slapparameter_dict.get('use-tap', 'False').lower() -%}
+{% set use_tap = slapparameter_dict.get('use-tap', 'True').lower() -%}
 {% set use_nat = slapparameter_dict.get('use-nat', 'True').lower() -%}
 {% set wipe_disk = slapparameter_dict.get('wipe-disk-ondestroy', 'False').lower() -%}
 {% set nat_restrict = slapparameter_dict.get('nat-restrict-mode', 'False').lower() -%}
@@ -677,7 +677,7 @@ cpu-model = host
 
 nat-rules = 22 80 443
 use-nat = True
-use-tap = False
+use-tap = True
 nat-restrict-mode = False
 enable-vhost = False