fix a small bug in the file locking error logging

src/CHANGES.txt

@@ -109,7 +109,15 @@ Bugs Fixed
 - Fixed bug in ClientCache that occurred with objects larger than the total
   cache size.
 
-3.8.1b8 (2008-09-??)
+3.8.1b9 (2008-??-??)
+====================
+
+Bugs Fixed:
+
+- When an error occured attempting to lock a file and logging of said error was
+  enabled.
+
+3.8.1b8 (2008-09-22
 ====================
 
 Bugs Fixed:

src/ZODB/lock_file.py

@@ -82,7 +82,9 @@ class LockFile:
             fp.seek(1)
             pid = fp.read().strip()[:20]
             fp.close()
-            logger.exception("Error locking file", path, pid)
+            if not pid:
+                pid = 'UNKNOWN'
+            logger.exception("Error locking file %s; pid=%s", path, pid)
             raise
 
         self._fp = fp

src/ZODB/lock_file.txt

@@ -9,14 +9,20 @@ LockFile object with a file name:
     >>> import ZODB.lock_file
     >>> lock = ZODB.lock_file.LockFile('lock')
 
-If we try to lock the same name, we'll get a lock error:
+If we try to lock the same name, we'll get a lock error and it will be logged:
 
+    >>> import ZODB.tests.loggingsupport
+    >>> handler = ZODB.tests.loggingsupport.InstalledHandler('ZODB.lock_file')
     >>> try:
     ...     ZODB.lock_file.LockFile('lock')
     ... except ZODB.lock_file.LockError:
     ...     print "Can't lock file"
     Can't lock file
 
+    >>> for record in handler.records:
+    ...     print record.levelname, record.getMessage()
+    ERROR Error locking file lock; pid=UNKNOWN
+
 To release the lock, use it's close method:
 
     >>> lock.close()