fixup! Project management improvements
metadata was not committed, so next time VCS tab is used on this business template the path is marked as removed.
Showing
-
Owner
@rporchetto can you please check I'm correct here, the
PathTemplateItem
part was added in 9e75aa25 , but the part inbt
was missing.Good news is that this is detected by coding style test, since we now have coding style enabled for
erp5_project
, we'll catch this if it happens again:====================================================================== FAIL: test_rebuild_business_template (CodingStyleTest.CodingStyleTest erp5_project) Try to rebuild business template to catch packaging errors. ---------------------------------------------------------------------- Traceback (most recent call last): File "/srv/slapgrid/slappart1/srv/testnode/ata/soft/0dd65f833ebb9eb826694aa000f5dc56/parts/erp5/product/ERP5Type/tests/CodingStyleTestCase.py", line 127, in test_rebuild_business_template self.assertEqual(existing_files, new_files) AssertionError: Items in the first set but not the second: 'erp5_project/PathTemplateItem/portal_domains/date_milestone_domain.xml'
-
Owner
this is for !1087 (merged) , I rebase the changes and this commit is not longer in the merge request
-
Developer
thank you @jerome, indeed, the
portal_domains/date_milestone_domain
path was missing in the bt specification. I'm checking the rest of your comments.
Please register or sign in to comment