dms: drop PDF thumbnail view
Since 7f32f8cd (erp5_dms: Add PDF Reader using the pdf.js, 2016-06-24) we have a PDF preview with a javascript PDF view, which is much better way of viewing PDF. This commit made the Thumbnail preview obsolete, also it does not really work on ERP5JS, so remove the thumbnail preview.
-
mentioned in merge request !1610 (merged)
-
Developer
-
Owner
Thanks @georgios.dagkakis I did not notice. I guess this was for example for ingested emails with PDF attachments to show a preview of the PDF.
Did you notice because some feature is broken or just because of a traceback in the log when displaying this tab ? if I change this line by
tal:define="frame request/frame | python: 1;
it's another error
File "Script (Python)", line 28, in Base_createMailMessageAsString mime_type, content = embedded_file.getMimeTypeAndContent() File "<portal_components/document.erp5.File>", line 212, in getMimeTypeAndContent raise ValueError('Cannot find mimetype of the document.') ValueError: Cannot find mimetype of the document.
but after trying a bit it seems to be used to display an image preview of the attachment.
The minimum we could do is to change to remove
Event_renderHTMLPreviewAsImage
and use1
instead. Please let me know if you noticed something broken, if not I will just do this (unless you are willing to do it ?) -
Developer
Did you notice because some feature is broken or just because of a traceback in the log when displaying this tab ?
I just noticed the log, nothing visible for the user
The minimum we could do is to change to remove
Event_renderHTMLPreviewAsImage
and use1
instead. Please let me know if you noticed something broken, if not I will just do this (unless you are willing to do it ?)Yes, I think we can do this, feel free to proceed