erp5_mrp: Add needed trade phase and builder to use Manufacturing Order
-
mentioned in merge request !893 (closed)
-
Owner
The added trade phase categories does not seem to be referenced by anything in this commit and also not referenced by anything in erp5_mrp ( except this field TALES ).
How about just removing the categories from
erp5_mrp
and say that they are supposed to be added by another configuration business template ( such aserp5_configurator_standard_categories
)/cc @vpelletier @seb
-
Maintainer
Where would that be written explicitely?
-
Owner
I don't know where this is written explicitly, but if we look in
bt5/*/PathTemplateItem/portal_categories
we can see that most of the categories are defined in test/example configurations business templates.I was expecting that maybe there would be a "guideline" saying that generic business templates should not contain categories somewhere in https://www.erp5.com/bt5-Module.Creation.Guidelines or https://www.erp5.com/documentation/developer/guideline/ but I did not find this.
There are several documents mentioning that "configuration" is done with categories ( https://www.erp5.com/P-CLOUDIA-Category.Spreadsheet.HowTo or https://www.erp5.com/user-Howto.Configure.ERP5.for.SMB.With.Consultant.Configurator ), but they don't say anything about trade phase category.
I think one point of the big "new simulation" refactoring that was made some years ago was to allow to configure various phases, for example, instead of order, delivery then manufacturing, there could be no order step, and an extra "quality check" step, a "packaging" step etc,
trade_phase
is in my understanding something that can vary from one erp5 configuration to another, so it should not be included in default business templates but in configuration business templates.If really needed, the "good way" instead of hardcoding a category was to define a system preference, for example some forms in ERP5 trade allow selecting only clients, instead of using
role/client
we usegetPreferredClientRole
, that is defined in a preferences.Removing the paths from this bt should not cause any issues, or am I missing something ? (and there's no need to define a preference, because these categories does not seem to be referenced anywhere in the code)
-
Maintainer
There indeed no issues. It could be commited in a configurator bt5
-
Developer
we might indeed have erp5_configurator_standard_mrp_template to define there what starts to be not really generic, like categories and builder of MRP. Though scripts to select movement in simulation could stay in erp5_mrp. This is what is done for trade with erp5_configurator_standard_trade_template. I know mrp builders are already in erp5_mrp, but we could also think to move them.