Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
erp5
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Labels
Merge Requests
138
Merge Requests
138
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Analytics
Analytics
CI / CD
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Jobs
Commits
Open sidebar
nexedi
erp5
Commits
c7bfc260
Commit
c7bfc260
authored
May 18, 2018
by
Nicolas Wavrant
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Revert "[hal_json] Simplify mass-action logic of passing `query` and `uids`"
This reverts commit
3a811c0e
.
parent
953b0a0e
Changes
1
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
22 additions
and
16 deletions
+22
-16
bt5/erp5_hal_json_style/SkinTemplateItem/portal_skins/erp5_hal_json_style/ERP5Document_getHateoas.py
...rtal_skins/erp5_hal_json_style/ERP5Document_getHateoas.py
+22
-16
No files found.
bt5/erp5_hal_json_style/SkinTemplateItem/portal_skins/erp5_hal_json_style/ERP5Document_getHateoas.py
View file @
c7bfc260
...
@@ -1037,22 +1037,16 @@ def renderForm(traversed_document, form, response_dict, key_prefix=None, selecti
...
@@ -1037,22 +1037,16 @@ def renderForm(traversed_document, form, response_dict, key_prefix=None, selecti
if
form
.
pt
==
"form_dialog"
:
if
form
.
pt
==
"form_dialog"
:
# If there is a "form_id" in the REQUEST then it means that last view was actually a form
# If there is a "form_id" in the REQUEST then it means that last view was actually a form
# and we are most likely in a dialog. We save previous form into `last_form_id`
# and we are most likely in a dialog. We save previous form into `last_form_id` ...
last_form_id
=
extra_param_json
.
pop
(
"form_id"
,
""
)
or
REQUEST
.
get
(
"form_id"
,
""
)
or
form
.
id
last_form_id
=
extra_param_json
.
pop
(
"form_id"
,
""
)
or
REQUEST
.
get
(
"form_id"
,
""
)
last_listbox
=
None
# ... so we can do some magic with it (especially embedded listbox if exists)!
try
:
if
last_form_id
:
last_form
=
getattr
(
context
,
last_form_id
)
last_form
=
getattr
(
context
,
last_form_id
)
# So we can support Selections! Yay!
last_listbox
=
last_form
.
Base_getListbox
()
# If extra_param_json already contains necessary arrtibutes: mandatory `query` and optional `uids`
except
AttributeError
:
# then our job is done! If not we need to generate them to become parameters for Dialog method.
pass
if
last_form
.
pt
==
"form_list"
:
# on a module-level (form_list page template) always put a not-None query in the extra_param_json
extra_param_json
[
"query"
]
=
extra_param_json
.
get
(
"query"
,
query
)
or
""
# only if Dialog Method specifies UIDS then we generate them into the `extra_param_json`
if
"uids"
not
in
extra_param_json
:
method_args
=
selectKwargsForCallable
(
getattr
(
traversed_document
,
form
.
action
),
{},
{
'uids'
:
None
})
if
"uids"
in
method_args
:
extra_param_json
[
"uids"
]
=
[
int
(
getattr
(
document
,
"uid"
))
for
document
in
traversed_document
.
Base_searchUsingListbox
(
last_form
.
Base_getListbox
(),
extra_param_json
[
"query"
],
limit
=
DOCUMENT_COUNT_LIMIT
)]
REQUEST
.
set
(
"form_id"
,
last_form_id
)
# to be accessible in field rendering (namely ListBox)
REQUEST
.
set
(
"form_id"
,
last_form_id
)
# to be accessible in field rendering (namely ListBox)
# Form traversed_document
# Form traversed_document
...
@@ -1107,6 +1101,18 @@ def renderForm(traversed_document, form, response_dict, key_prefix=None, selecti
...
@@ -1107,6 +1101,18 @@ def renderForm(traversed_document, form, response_dict, key_prefix=None, selecti
# some dialog actions use custom cancel_url
# some dialog actions use custom cancel_url
if
REQUEST
.
get
(
'cancel_url'
,
None
):
if
REQUEST
.
get
(
'cancel_url'
,
None
):
renderHiddenField
(
response_dict
,
"cancel_url"
,
REQUEST
.
get
(
'cancel_url'
))
renderHiddenField
(
response_dict
,
"cancel_url"
,
REQUEST
.
get
(
'cancel_url'
))
# Let's support Selections!
# If extra_param_json already contains necessary arrtibutes: mandatory `query` and optional `uids`
# then our job is done! If not we need to generate them to become parameters for Dialog method.
if
"uids"
not
in
extra_param_json
:
method_args
=
selectKwargsForCallable
(
getattr
(
traversed_document
,
form
.
action
),
{},
{
'uids'
:
None
})
if
"uids"
in
method_args
:
extra_param_json
[
"uids"
]
=
[
int
(
getattr
(
document
,
"uid"
))
for
document
in
traversed_document
.
Base_searchUsingListbox
(
last_listbox
,
query
or
extra_param_json
.
get
(
"query"
,
None
),
limit
=
DOCUMENT_COUNT_LIMIT
)]
if
query
is
not
None
:
extra_param_json
[
"query"
]
=
query
else
:
else
:
# In form_view we place only form_id in the request form
# In form_view we place only form_id in the request form
renderHiddenField
(
response_dict
,
'form_id'
,
form
.
id
)
renderHiddenField
(
response_dict
,
'form_id'
,
form
.
id
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment