Commit a698011a authored by Juliusz Chroboczek's avatar Juliusz Chroboczek

Don't set rid when not simulcasting.

It turns out that the bandwidth limitation is not effective
in Firefox when the rid is set unless we're simulcasting.
parent 70163094
...@@ -1189,16 +1189,23 @@ function setUpStream(c, stream) { ...@@ -1189,16 +1189,23 @@ function setUpStream(c, stream) {
let simulcast = doSimulcast(); let simulcast = doSimulcast();
if(t.kind === 'video') { if(t.kind === 'video') {
let bps = getMaxVideoThroughput(); let bps = getMaxVideoThroughput();
// Firefox doesn't like us setting the RID if we're not
// simulcasting.
if(simulcast) {
encodings.push({ encodings.push({
rid: 'h', rid: 'h',
maxBitrate: bps || unlimitedRate, maxBitrate: bps || unlimitedRate,
}); });
if(simulcast)
encodings.push({ encodings.push({
rid: 'l', rid: 'l',
scaleResolutionDownBy: 2, scaleResolutionDownBy: 2,
maxBitrate: simulcastRate, maxBitrate: simulcastRate,
}); });
} else {
encodings.push({
maxBitrate: bps || unlimitedRate,
});
}
} else { } else {
if(c.label !== 'camera' || settings.hqaudio) { if(c.label !== 'camera' || settings.hqaudio) {
encodings.push({ encodings.push({
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment