Commit f34ec0ab authored by Juliusz Chroboczek's avatar Juliusz Chroboczek

Don't hide mismatches in the PeerConnection state automaton.

The previous behaviour led to silent failures, which was confusing.
parent f4811e8c
...@@ -569,9 +569,6 @@ func gotAnswer(c *webClient, id string, sdp string) error { ...@@ -569,9 +569,6 @@ func gotAnswer(c *webClient, id string, sdp string) error {
return ErrUnknownId return ErrUnknownId
} }
if down.pc.SignalingState() == webrtc.SignalingStateStable {
log.Printf("Got answer in stable state -- this shouldn't happen")
} else {
err := down.pc.SetRemoteDescription(webrtc.SessionDescription{ err := down.pc.SetRemoteDescription(webrtc.SessionDescription{
Type: webrtc.SDPTypeAnswer, Type: webrtc.SDPTypeAnswer,
SDP: sdp, SDP: sdp,
...@@ -579,7 +576,6 @@ func gotAnswer(c *webClient, id string, sdp string) error { ...@@ -579,7 +576,6 @@ func gotAnswer(c *webClient, id string, sdp string) error {
if err != nil { if err != nil {
return err return err
} }
}
for _, t := range down.tracks { for _, t := range down.tracks {
local := t.track.Codec() local := t.track.Codec()
...@@ -590,7 +586,7 @@ func gotAnswer(c *webClient, id string, sdp string) error { ...@@ -590,7 +586,7 @@ func gotAnswer(c *webClient, id string, sdp string) error {
} }
} }
err := down.flushICECandidates() err = down.flushICECandidates()
if err != nil { if err != nil {
log.Printf("ICE: %v", err) log.Printf("ICE: %v", err)
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment